All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 0/8] pinctrl/arm: dt-bindings: deprecate header with register constants
Date: Mon, 6 Jun 2022 13:59:23 -0500	[thread overview]
Message-ID: <20220606185923.GA900292-robh@kernel.org> (raw)
In-Reply-To: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org>

On Sun, Jun 05, 2022 at 06:05:00PM +0200, Krzysztof Kozlowski wrote:
> Hi,
> 
> Merging
> =======
> 1. I plan to take the DTS changes (patches 1-6) via Samsung SoC tree.
> 2. The driver change (patch 7) can go independently via pinctrl tree or via my
>    Samsung pinctrl tree.
> 3. The final bindings patch 8 will wait for next release, to avoid any cross
>    tree merges or warnings.
> 
> Changes since v2
> ================
> 1. Split last bindings patch per driver changes and bindings.
> 2. Add tags.
> 
> Changes since v1
> ================
> 1. Correct title (in the comment) of each header (Chanho).
> 2. Patch #7: Adjust warning message.
> 3. Add tags.
> 
> Description
> ===========
> The Samsung pin controller drivers were always expecting DTS to use raw
> register values for pin configuration (e.g. pull up/down, drive strength).  DTS
> had these values hard-coded all over, so at some point we decided for
> convenience to move them to dt-bindings header.  Less code duplication, some
> meaning added to raw number, etc.
> 
> However these constants do not fit the purpose of bindings.  They do not
> provide any abstraction, any hardware and driver independent ID.  With minor
> exceptions, the Linux drivers actually do not use the bindings header at
> all.  Because of this "dt-bindings ID" approach, these constants were re-used
> between chips, e.g. Exynos ones in S5PV210.  These does not make much sense
> because the values between Exynos and S5PV210 (or S3C24xx) are not related.  If
> it was an abstraction ID, this would be fine. But it's not.
> 
> Clean this up by:
> 1. Moving the constants to DTS-local headers.
> 2. Deprecating the bindings header.
> 
> Tested by comparing DTBs (dtx_diff, fdtdump).
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (8):
>   ARM: dts: s3c2410: use local header for pinctrl register values
>   ARM: dts: s3c64xx: use local header for pinctrl register values
>   ARM: dts: s5pv210: use local header for pinctrl register values
>   ARM: dts: exynos: use local header for pinctrl register values
>   arm64: dts: exynos: use local header for pinctrl register values
>   arm64: dts: fsd: use local header for pinctrl register values
>   pinctrl: samsung: do not use bindings header with constants
>   dt-bindings: pinctrl: samsung: deprecate header with register
>     constants

For the series:

Acked-by: Rob Herring <robh@kernel.org>


WARNING: multiple messages have this Message-ID
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 0/8] pinctrl/arm: dt-bindings: deprecate header with register constants
Date: Mon, 6 Jun 2022 13:59:23 -0500	[thread overview]
Message-ID: <20220606185923.GA900292-robh@kernel.org> (raw)
In-Reply-To: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org>

On Sun, Jun 05, 2022 at 06:05:00PM +0200, Krzysztof Kozlowski wrote:
> Hi,
> 
> Merging
> =======
> 1. I plan to take the DTS changes (patches 1-6) via Samsung SoC tree.
> 2. The driver change (patch 7) can go independently via pinctrl tree or via my
>    Samsung pinctrl tree.
> 3. The final bindings patch 8 will wait for next release, to avoid any cross
>    tree merges or warnings.
> 
> Changes since v2
> ================
> 1. Split last bindings patch per driver changes and bindings.
> 2. Add tags.
> 
> Changes since v1
> ================
> 1. Correct title (in the comment) of each header (Chanho).
> 2. Patch #7: Adjust warning message.
> 3. Add tags.
> 
> Description
> ===========
> The Samsung pin controller drivers were always expecting DTS to use raw
> register values for pin configuration (e.g. pull up/down, drive strength).  DTS
> had these values hard-coded all over, so at some point we decided for
> convenience to move them to dt-bindings header.  Less code duplication, some
> meaning added to raw number, etc.
> 
> However these constants do not fit the purpose of bindings.  They do not
> provide any abstraction, any hardware and driver independent ID.  With minor
> exceptions, the Linux drivers actually do not use the bindings header at
> all.  Because of this "dt-bindings ID" approach, these constants were re-used
> between chips, e.g. Exynos ones in S5PV210.  These does not make much sense
> because the values between Exynos and S5PV210 (or S3C24xx) are not related.  If
> it was an abstraction ID, this would be fine. But it's not.
> 
> Clean this up by:
> 1. Moving the constants to DTS-local headers.
> 2. Deprecating the bindings header.
> 
> Tested by comparing DTBs (dtx_diff, fdtdump).
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (8):
>   ARM: dts: s3c2410: use local header for pinctrl register values
>   ARM: dts: s3c64xx: use local header for pinctrl register values
>   ARM: dts: s5pv210: use local header for pinctrl register values
>   ARM: dts: exynos: use local header for pinctrl register values
>   arm64: dts: exynos: use local header for pinctrl register values
>   arm64: dts: fsd: use local header for pinctrl register values
>   pinctrl: samsung: do not use bindings header with constants
>   dt-bindings: pinctrl: samsung: deprecate header with register
>     constants

For the series:

Acked-by: Rob Herring <robh@kernel.org>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-06-06 18:59 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-05 16:05 [PATCH v3 0/8] pinctrl/arm: dt-bindings: deprecate header with register constants Krzysztof Kozlowski
2022-06-05 16:05 ` Krzysztof Kozlowski
2022-06-05 16:05 ` [PATCH v3 1/8] ARM: dts: s3c2410: use local header for pinctrl register values Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-07  6:39   ` (subset) " Krzysztof Kozlowski
2022-06-07  6:39     ` Krzysztof Kozlowski
2022-06-05 16:05 ` [PATCH v3 2/8] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-07  6:39   ` (subset) " Krzysztof Kozlowski
2022-06-07  6:39     ` Krzysztof Kozlowski
2022-06-05 16:05 ` [PATCH v3 3/8] ARM: dts: s5pv210: " Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-07  6:39   ` (subset) " Krzysztof Kozlowski
2022-06-07  6:39     ` Krzysztof Kozlowski
2022-06-05 16:05 ` [PATCH v3 4/8] ARM: dts: exynos: " Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-07  6:39   ` (subset) " Krzysztof Kozlowski
2022-06-07  6:39     ` Krzysztof Kozlowski
2022-06-05 16:05 ` [PATCH v3 5/8] arm64: " Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-07  6:39   ` (subset) " Krzysztof Kozlowski
2022-06-07  6:39     ` Krzysztof Kozlowski
2022-06-05 16:05 ` [PATCH v3 6/8] arm64: dts: fsd: " Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-07  6:39   ` (subset) " Krzysztof Kozlowski
2022-06-07  6:39     ` Krzysztof Kozlowski
2022-06-05 16:05 ` [PATCH v3 7/8] pinctrl: samsung: do not use bindings header with constants Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-07  6:39   ` (subset) " Krzysztof Kozlowski
2022-06-07  6:39     ` Krzysztof Kozlowski
2022-06-15 13:49   ` Linus Walleij
2022-06-15 13:49     ` Linus Walleij
2022-06-05 16:05 ` [PATCH v3 8/8] dt-bindings: pinctrl: samsung: deprecate header with register constants Krzysztof Kozlowski
2022-06-05 16:05   ` Krzysztof Kozlowski
2022-06-05 16:07   ` Krzysztof Kozlowski
2022-06-05 16:07     ` Krzysztof Kozlowski
2022-06-06 18:59 ` Rob Herring [this message]
2022-06-06 18:59   ` [PATCH v3 0/8] pinctrl/arm: dt-bindings: " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606185923.GA900292-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.