From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BE6C43334 for ; Mon, 6 Jun 2022 18:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229837AbiFFS73 (ORCPT ); Mon, 6 Jun 2022 14:59:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231641AbiFFS71 (ORCPT ); Mon, 6 Jun 2022 14:59:27 -0400 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE31AAFB3C; Mon, 6 Jun 2022 11:59:25 -0700 (PDT) Received: by mail-io1-f44.google.com with SMTP id n144so134683iod.4; Mon, 06 Jun 2022 11:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LBCu0rHUuV6/ftfk4QrcN/2mnb7WuKbppJnFTxyjW94=; b=nwnRN47R8roUVlUIUAOh/EgLE6E9Lvtk84fNSNA10m+0NHYtJTrTwMjvhstpmz/Tax 56cX7I886Q8yhdZLBxWWGteKFB5PESsldSdY2C5+NZGDtkIEE6CgPlVY/do9HccR7xVY dc1hCzuyY4mGqdZ5X9jPtXx28nClimi3wQ1fmryamAnAREAaebtUlA9TkSRE2dqm0mVl 6700YmXg5v38XHZMLIJkCwgxslhU+Zb/3/VM/IlReIUJfJRBBKa1KhuajwS7AvzSH463 dQSeZX9Bt/MfDxWGtnKdaOZj+qTFXVIz+9Df4i/IgMgJpegV+PEVLKLwpz+bwJtN7gbI wqOA== X-Gm-Message-State: AOAM532mgY9EYbCJxjyiri7okz+rFPKR20gP2HV4ImwUebjmJnQQ+WIg RZ65B2Cir/poAju1vBedtg== X-Google-Smtp-Source: ABdhPJweHrdLUcsa2RnGGF2haYRcX1atBS2HmAwJzesZ7+Tb0tRZgHJ+InjfDtx4dsAxjBZfbip76A== X-Received: by 2002:a05:6638:3787:b0:331:aaf5:950c with SMTP id w7-20020a056638378700b00331aaf5950cmr4180577jal.118.1654541965156; Mon, 06 Jun 2022 11:59:25 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id n5-20020a056e02100500b002d5366820acsm1585158ilj.18.2022.06.06.11.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 11:59:24 -0700 (PDT) Received: (nullmailer pid 1080359 invoked by uid 1000); Mon, 06 Jun 2022 18:59:23 -0000 Date: Mon, 6 Jun 2022 13:59:23 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 0/8] pinctrl/arm: dt-bindings: deprecate header with register constants Message-ID: <20220606185923.GA900292-robh@kernel.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, Jun 05, 2022 at 06:05:00PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Merging > ======= > 1. I plan to take the DTS changes (patches 1-6) via Samsung SoC tree. > 2. The driver change (patch 7) can go independently via pinctrl tree or via my > Samsung pinctrl tree. > 3. The final bindings patch 8 will wait for next release, to avoid any cross > tree merges or warnings. > > Changes since v2 > ================ > 1. Split last bindings patch per driver changes and bindings. > 2. Add tags. > > Changes since v1 > ================ > 1. Correct title (in the comment) of each header (Chanho). > 2. Patch #7: Adjust warning message. > 3. Add tags. > > Description > =========== > The Samsung pin controller drivers were always expecting DTS to use raw > register values for pin configuration (e.g. pull up/down, drive strength). DTS > had these values hard-coded all over, so at some point we decided for > convenience to move them to dt-bindings header. Less code duplication, some > meaning added to raw number, etc. > > However these constants do not fit the purpose of bindings. They do not > provide any abstraction, any hardware and driver independent ID. With minor > exceptions, the Linux drivers actually do not use the bindings header at > all. Because of this "dt-bindings ID" approach, these constants were re-used > between chips, e.g. Exynos ones in S5PV210. These does not make much sense > because the values between Exynos and S5PV210 (or S3C24xx) are not related. If > it was an abstraction ID, this would be fine. But it's not. > > Clean this up by: > 1. Moving the constants to DTS-local headers. > 2. Deprecating the bindings header. > > Tested by comparing DTBs (dtx_diff, fdtdump). > > Best regards, > Krzysztof > > Krzysztof Kozlowski (8): > ARM: dts: s3c2410: use local header for pinctrl register values > ARM: dts: s3c64xx: use local header for pinctrl register values > ARM: dts: s5pv210: use local header for pinctrl register values > ARM: dts: exynos: use local header for pinctrl register values > arm64: dts: exynos: use local header for pinctrl register values > arm64: dts: fsd: use local header for pinctrl register values > pinctrl: samsung: do not use bindings header with constants > dt-bindings: pinctrl: samsung: deprecate header with register > constants For the series: Acked-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 672FFC43334 for ; Mon, 6 Jun 2022 19:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VZlISbFN7OeoS9bVC7ljrTy77VUFeHJvtsfQbPrx0Tc=; b=qbNi2UvSup+eyq iqhRFjb0Ywxou39PQCh3RFYzm+W1OgwKhBxtNMlOGkfkgHESUcL0wycb0GjrmbIHLVtXVuTVJ1xS1 ktKnjjzTCmpHVfVtOMy4iboyqbHok8yZsrJXDg2hIL272TTOhizhykYqphFGb4hcEZMRlZou7qbzC byAa6RP+DOp52QYzYyx2eVHol4WL0CqoUjcFvk52NXZeBc8d62HCK6nli4OpBceiUzW0eqCpSLuaw RlZvuJ9MdXKXEfzQwRgSewj5iwohh+X/+C3UlPOoaecZd1YSthm6T4IVRdhFatMAVcVLL9Dv5zFfm Oxhm7HkuWko7cEfnV8AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyHwm-002NI3-N4; Mon, 06 Jun 2022 18:59:28 +0000 Received: from mail-io1-f53.google.com ([209.85.166.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyHwk-002NHU-BQ for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 18:59:27 +0000 Received: by mail-io1-f53.google.com with SMTP id y12so13206889ior.7 for ; Mon, 06 Jun 2022 11:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LBCu0rHUuV6/ftfk4QrcN/2mnb7WuKbppJnFTxyjW94=; b=sfffluCsu1FKqpxY720BKb+sd0FctHjWs9c0dBZcRgssFIToqOa8n++iQVT/Sb0uiH SNDm5BmHT9HxlrrQUJHKM1RDC5kBLpduP3Dbrluk/FwB09iJ1rUbJLwJfUfxg/34hi2B S9oUYfe/2lHSthyE35gkQimfeFLCVLqwppC7en2R89fOqyb9hncn7kODwPGRxZQORZmO GPhuccWz1U8mxtxQO3T1GcBPP9cYGRpXLyvksU6ngr3fR/VwSca0OFTt+sgOPrbpHUpm 7gV5IJ2xNHpexDf9nGVPQ4Iq2w72U/rKGsA8R9ieex1PtQH0IvNGQNGo2MZhgOlFpKcF 6zgg== X-Gm-Message-State: AOAM533sZUy0tIU8S3ZlzjOzDUy7Y4nR4Dgee7kLW/T/uBkt8N73Sy6w a1hC54KTxEE5jjV7t9T3pw== X-Google-Smtp-Source: ABdhPJweHrdLUcsa2RnGGF2haYRcX1atBS2HmAwJzesZ7+Tb0tRZgHJ+InjfDtx4dsAxjBZfbip76A== X-Received: by 2002:a05:6638:3787:b0:331:aaf5:950c with SMTP id w7-20020a056638378700b00331aaf5950cmr4180577jal.118.1654541965156; Mon, 06 Jun 2022 11:59:25 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id n5-20020a056e02100500b002d5366820acsm1585158ilj.18.2022.06.06.11.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 11:59:24 -0700 (PDT) Received: (nullmailer pid 1080359 invoked by uid 1000); Mon, 06 Jun 2022 18:59:23 -0000 Date: Mon, 6 Jun 2022 13:59:23 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 0/8] pinctrl/arm: dt-bindings: deprecate header with register constants Message-ID: <20220606185923.GA900292-robh@kernel.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_115926_428556_0F062BB6 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 05, 2022 at 06:05:00PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Merging > ======= > 1. I plan to take the DTS changes (patches 1-6) via Samsung SoC tree. > 2. The driver change (patch 7) can go independently via pinctrl tree or via my > Samsung pinctrl tree. > 3. The final bindings patch 8 will wait for next release, to avoid any cross > tree merges or warnings. > > Changes since v2 > ================ > 1. Split last bindings patch per driver changes and bindings. > 2. Add tags. > > Changes since v1 > ================ > 1. Correct title (in the comment) of each header (Chanho). > 2. Patch #7: Adjust warning message. > 3. Add tags. > > Description > =========== > The Samsung pin controller drivers were always expecting DTS to use raw > register values for pin configuration (e.g. pull up/down, drive strength). DTS > had these values hard-coded all over, so at some point we decided for > convenience to move them to dt-bindings header. Less code duplication, some > meaning added to raw number, etc. > > However these constants do not fit the purpose of bindings. They do not > provide any abstraction, any hardware and driver independent ID. With minor > exceptions, the Linux drivers actually do not use the bindings header at > all. Because of this "dt-bindings ID" approach, these constants were re-used > between chips, e.g. Exynos ones in S5PV210. These does not make much sense > because the values between Exynos and S5PV210 (or S3C24xx) are not related. If > it was an abstraction ID, this would be fine. But it's not. > > Clean this up by: > 1. Moving the constants to DTS-local headers. > 2. Deprecating the bindings header. > > Tested by comparing DTBs (dtx_diff, fdtdump). > > Best regards, > Krzysztof > > Krzysztof Kozlowski (8): > ARM: dts: s3c2410: use local header for pinctrl register values > ARM: dts: s3c64xx: use local header for pinctrl register values > ARM: dts: s5pv210: use local header for pinctrl register values > ARM: dts: exynos: use local header for pinctrl register values > arm64: dts: exynos: use local header for pinctrl register values > arm64: dts: fsd: use local header for pinctrl register values > pinctrl: samsung: do not use bindings header with constants > dt-bindings: pinctrl: samsung: deprecate header with register > constants For the series: Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel