From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC520C43334 for ; Tue, 7 Jun 2022 19:22:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354595AbiFGTWY (ORCPT ); Tue, 7 Jun 2022 15:22:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352545AbiFGSbE (ORCPT ); Tue, 7 Jun 2022 14:31:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8A517B87E; Tue, 7 Jun 2022 10:56:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 49ACAB8237A; Tue, 7 Jun 2022 17:56:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22FAEC36AFE; Tue, 7 Jun 2022 17:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624585; bh=C3p8V+CShGR7nozEVmR7aMQKSLK+SVYLvPNgHctlLf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N7FnVIV/TVOJz+Rr5SwBZQHKM53tu7Hvq7/2JRq6fwTry7dy1xXj/O5bN2v2oa7m9 Qi4ZVrfspTLsA2tuJ2j1EPR42ybHK4t+54AuglwEV/hKMp1jK5JFhbtrn8P5MWCK00 VT4wz3V15ZxRXW2E0rtTR7scGH93EDOqUtRy6kwXtcE47NA0k6YsJ75METwcBXGhea wQLvkUlx21MBWVa/ek9v3f5OiRrXFMHSdOimFBGYlov0rNy6+Z7GuK7Iky2ZXudM3F ZmDUtM5CQ3hjkwBbDutZ0Lwbb+Hq9RCNvj9u7ZheFwDy+RuL5eqOxq54StORxiw2lH XGZ3ycTZ9Lz/A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Huang Guobin , Jiri Slaby , Greg Kroah-Hartman , Sasha Levin , linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 08/51] tty: Fix a possible resource leak in icom_probe Date: Tue, 7 Jun 2022 13:55:07 -0400 Message-Id: <20220607175552.479948-8-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607175552.479948-1-sashal@kernel.org> References: <20220607175552.479948-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Guobin [ Upstream commit ee157a79e7c82b01ae4c25de0ac75899801f322c ] When pci_read_config_dword failed, call pci_release_regions() and pci_disable_device() to recycle the resource previously allocated. Reviewed-by: Jiri Slaby Signed-off-by: Huang Guobin Link: https://lore.kernel.org/r/20220331091005.3290753-1-huangguobin4@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/icom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c index 03a2fe9f4c9a..02b375ba2f07 100644 --- a/drivers/tty/serial/icom.c +++ b/drivers/tty/serial/icom.c @@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev, retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg); if (retval) { dev_err(&dev->dev, "PCI Config read FAILED\n"); - return retval; + goto probe_exit0; } pci_write_config_dword(dev, PCI_COMMAND, -- 2.35.1