From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE5DC43334 for ; Tue, 7 Jun 2022 19:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355993AbiFGTfC (ORCPT ); Tue, 7 Jun 2022 15:35:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353587AbiFGSpg (ORCPT ); Tue, 7 Jun 2022 14:45:36 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44861187C3E; Tue, 7 Jun 2022 10:59:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5D904CE2428; Tue, 7 Jun 2022 17:59:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0439FC34115; Tue, 7 Jun 2022 17:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624748; bh=93RaP5+sjMAjGExeJo5h97vFM+a0K8BZ5IZE4OzmE1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hAvbdtz73Is7OGp+TckSJj5lS0cwMR2Siaj/Mixw8/Wi1/HvxKWFfG1SV1bnLBSy6 7iBl+F7rfv8Q0YBJtSKHTRWSrFiRKJzSmrz1p2UfgTshxe4nYauoI2tCES2vzhDHYk 9q5dKVHGyZpaaHjgYskgbDEn9naOns9V/DUmb9xSGKboQt6vH5MOecmvapp9vCSY9R DiQwB9Z61ycucnHLI9iNGtNUWrRK1vyVosvJbrvDXhiCkawfcBHn2kxB1dZAqlgbt2 WQSxHVXm97GKZYGEnFANBK7VPmJR2wissZmeLpnjs9p6i/pafN76ex7/6LV3Ww87sb IPct/5zvMw3QQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhen Ni , Greg Kroah-Hartman , Sasha Levin , ok@artecdesign.ee, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 09/38] USB: host: isp116x: check return value after calling platform_get_resource() Date: Tue, 7 Jun 2022 13:58:04 -0400 Message-Id: <20220607175835.480735-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607175835.480735-1-sashal@kernel.org> References: <20220607175835.480735-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhen Ni [ Upstream commit 134a3408c2d3f7e23eb0e4556e0a2d9f36c2614e ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Zhen Ni Link: https://lore.kernel.org/r/20220302033716.31272-1-nizhen@uniontech.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/isp116x-hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 3055d9abfec3..3e5c54742bef 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1541,10 +1541,12 @@ static int isp116x_remove(struct platform_device *pdev) iounmap(isp116x->data_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); iounmap(isp116x->addr_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); usb_put_hcd(hcd); return 0; -- 2.35.1