All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Stitt <jstitt007@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	Justin Stitt <jstitt007@gmail.com>
Subject: [PATCH] include/uapi/linux/swab.h: add __u16 cast to __swab16 conditional
Date: Tue,  7 Jun 2022 15:20:06 -0700	[thread overview]
Message-ID: <20220607222006.22719-1-jstitt007@gmail.com> (raw)

if __HAVE_BUILTIN_BSWAP16__ is defined then __swab16 utilizes a __u16 cast.
This same cast should be used if __HAVE_BUILTIN_BSWAP16__ is not defined as
well. This should fix loads (at least a few) clang -Wformat warnings
specifically with `ntohs()`

Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Justin Stitt <jstitt007@gmail.com>
---
 include/uapi/linux/swab.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/swab.h b/include/uapi/linux/swab.h
index 7272f85d6d6a..f6be3f2e6fee 100644
--- a/include/uapi/linux/swab.h
+++ b/include/uapi/linux/swab.h
@@ -102,7 +102,7 @@ static inline __attribute_const__ __u32 __fswahb32(__u32 val)
 #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
 #else
 #define __swab16(x)				\
-	(__builtin_constant_p((__u16)(x)) ?	\
+	(__u16)(__builtin_constant_p((__u16)(x)) ?	\
 	___constant_swab16(x) :			\
 	__fswab16(x))
 #endif
-- 
2.30.2


             reply	other threads:[~2022-06-07 22:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 22:20 Justin Stitt [this message]
2022-06-07 22:27 ` [PATCH] include/uapi/linux/swab.h: add __u16 cast to __swab16 conditional Andrew Morton
2022-06-07 22:42   ` Nick Desaulniers
2022-06-07 23:21     ` Andrew Morton
2022-06-07 23:43       ` Nick Desaulniers
2022-06-08  4:54       ` Al Viro
2022-06-08 19:35         ` Nick Desaulniers
2022-06-10  7:19           ` David Laight
2022-06-07 23:20 ` Nick Desaulniers
2022-06-08  0:14   ` [PATCH v2] include/uapi/linux/swab.h: move explicit cast outside ternary Justin Stitt
2022-06-08 20:09     ` Andrew Morton
2022-06-08 21:16       ` Nick Desaulniers
2022-06-08 21:19     ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220607222006.22719-1-jstitt007@gmail.com \
    --to=jstitt007@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.