From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04CCAC43334 for ; Wed, 8 Jun 2022 02:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbiFHCzF (ORCPT ); Tue, 7 Jun 2022 22:55:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387000AbiFHCvW (ORCPT ); Tue, 7 Jun 2022 22:51:22 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9EF6219DE58; Tue, 7 Jun 2022 17:23:49 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 711D95EC606; Wed, 8 Jun 2022 10:23:16 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nyjTf-003xdV-96; Wed, 08 Jun 2022 10:23:15 +1000 Date: Wed, 8 Jun 2022 10:23:15 +1000 From: Dave Chinner To: =?iso-8859-1?Q?Lu=EDs?= Henriques Cc: fstests@vger.kernel.org, Jeff Layton , Xiubo Li , ceph-devel@vger.kernel.org Subject: Re: [PATCH 2/2] src/attr_replace_test: dynamically adjust the max xattr size Message-ID: <20220608002315.GT1098723@dread.disaster.area> References: <20220607151513.26347-1-lhenriques@suse.de> <20220607151513.26347-3-lhenriques@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220607151513.26347-3-lhenriques@suse.de> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=deDjYVbe c=1 sm=1 tr=0 ts=629febf4 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=8nJEP1OIZ-IA:10 a=JPEYwPQDsx4A:10 a=7-415B0cAAAA:8 a=Nl4EAiEQiwDYvX63o9gA:9 a=wPNLvfGTeEIA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Tue, Jun 07, 2022 at 04:15:13PM +0100, Luís Henriques wrote: > CephFS doesn't had a maximum xattr size. Instead, it imposes a maximum > size for the full set of an inode's xattrs names+values, which by default > is 64K but it can be changed by a cluster admin. > > Test generic/486 started to fail after fixing a ceph bug where this limit > wasn't being imposed. Adjust dynamically the size of the xattr being set > if the error returned is -ENOSPC. Ah, this shouldn't be getting anywhere near the 64kB limit unless ceph is telling userspace it's block size is > 64kB: size = sbuf.st_blksize * 3 / 4; ..... size = MIN(size, XATTR_SIZE_MAX); Regardless, the correct thing to do here is pass the max supported xattr size from the command line (because fstests knows what that it for each filesystem type) rather than hard coding XATTR_SIZE_MAX in the test. Cheers, Dave. -- Dave Chinner david@fromorbit.com