From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2051C43334 for ; Wed, 8 Jun 2022 09:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IXJIFH9v0S5ocFRtC9SZf9pmSM7G1N2e78Zcv59znPg=; b=MP+6tn3QiBXkzI 1B4nhs5bVWBKvSndcbB/ojBWOlJrBXtRKe+vXFytSndeNhKidDHAHhupeIy48mPa8IlUch/98SFMV vRtbAc4/TfeDTd/xdw+prbDUx+ClnNDv7IIl5foSz4Ms+OTrjJDzxOfgJhm4DnnsNsRH7OpCd8v2M w+wxE1Ul1Z9+DJaA25LcXCdbW5EppEu/BdHLruiHGLUAiK5z6fsQKtOuOMe8opYhsYbtYuOhaosRC 7ycGgvhWN15R7y1lMdmqRgFFxdJr/d08yRVoT0DyiH0SOuLHrBGur8AEXjLkpHFgtiEp5yGTcnbcG bREvY+KEJsZ3CnoTMQSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyrsX-00CKtv-Qa; Wed, 08 Jun 2022 09:21:30 +0000 Received: from mail-ua1-x935.google.com ([2607:f8b0:4864:20::935]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyrsS-00CKrt-PK for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 09:21:26 +0000 Received: by mail-ua1-x935.google.com with SMTP id d18so1891144uaw.2 for ; Wed, 08 Jun 2022 02:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=gj53TGrcFKvg3WdH/kBUkM4Hf1Vz6A2pmV6JoIO4uQg=; b=gcSeh2/XbP0fRf1MOxr9hzlled1viRBXIvwTte1bSf4dJpwUIsWSJKo1BbWJwW1fhN A2rKZjSrPRqnzvSFPpJmRO3SZdVqG738atkz4iEc+oWYs5sjTbEErC1Yl+d0yoZS+YWr +nJ22b4Vc/isMgBWLMEp7nD7FYrSVQUXm42Ti4oBeM33zB6+E4wLlQhauFt4V9n9pj7L KxVy9xKyug/HL1HDcrEaNVonYwHt+qg1VpJDHO8+qt7exQBp7hNXkL8ZMcqsaFTjir1g 85YXmxDIDspO/ov0x4lSP/XICksXKVyGdTSyxrMmpe12QeNQ2NKKc6Dy+Csb4OZIyhIC UtwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gj53TGrcFKvg3WdH/kBUkM4Hf1Vz6A2pmV6JoIO4uQg=; b=BRqTR0cDDs409WLnlKqf9QgoySiTFOAsBmXFzjnAwbbG33Vzi1GWMPMYiClzp14DU1 3aQCSJAKjdcl4sNI/rDwbdKVkgdvMUvuSNFbeq8YaqnE7xtQwRW8coZMjmrtNj4chsMX uE50ij7QhxD0dgLDxWyt8pLaMPgN8Z13ViThVzd4TgEO4nJC1POF9TXa98ViqwyxRv4z vSkV6aFN84bD/VHD5QTnxxRn/OPnNaJd+HiwdZ28p0GX9jJ/uL815v61tuwmaw5FjVC5 eqa+poPRH/a8907h5VZXLutk1WGeMW/sAc3+OwxHyNe5RfjX3qjk66oZjcrWP5PftAo/ Pkpg== X-Gm-Message-State: AOAM532c+B2YW0RW/h9c7VsFQQ+TigzsnIYmblTJHA0Cj/mgl9emXAcN JbaztGhqX50M7JHcO544YUI= X-Google-Smtp-Source: ABdhPJyGs8DWQ8wnxJdTEW/zlBdhQNuphjeSfXyBIMlzudn7ozMmCizNULarv7m5YEryAN0jhXtMWw== X-Received: by 2002:a9f:3189:0:b0:35c:c458:ee11 with SMTP id v9-20020a9f3189000000b0035cc458ee11mr36371517uad.31.1654680082621; Wed, 08 Jun 2022 02:21:22 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id v21-20020a056122121500b0035d31e4bb01sm2543501vkc.6.2022.06.08.02.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 02:21:21 -0700 (PDT) From: Florian Fainelli To: bcm-kernel-feedback-list@broadcom.com, Miaoqian Lin , Andrew Morton , Thomas Bogendoerfer , Kees Cook , Helge Deller , Bjorn Andersson , Andy Shevchenko , Gareth Powell , Brian Norris , Doug Berger , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm_probe Date: Wed, 8 Jun 2022 02:21:18 -0700 Message-Id: <20220608092118.1463835-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220526075325.27356-1-linmq006@gmail.com> References: <20220526075325.27356-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_022124_866093_0B0762BC X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 26 May 2022 11:53:22 +0400, Miaoqian Lin wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > In brcmstb_init_sram, it pass dn to of_address_to_resource(), > of_address_to_resource() will call of_find_device_by_node() to take > reference, so we should release the reference returned by > of_find_matching_node(). > > Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") > Signed-off-by: Miaoqian Lin > --- Applied to https://github.com/Broadcom/stblinux/commits/drivers/fixes, thanks! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2867FC43334 for ; Wed, 8 Jun 2022 09:52:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235400AbiFHJwL (ORCPT ); Wed, 8 Jun 2022 05:52:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235262AbiFHJvt (ORCPT ); Wed, 8 Jun 2022 05:51:49 -0400 Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D7323DDF2E for ; Wed, 8 Jun 2022 02:21:41 -0700 (PDT) Received: by mail-ua1-x933.google.com with SMTP id v19so1069138uae.0 for ; Wed, 08 Jun 2022 02:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=gj53TGrcFKvg3WdH/kBUkM4Hf1Vz6A2pmV6JoIO4uQg=; b=gcSeh2/XbP0fRf1MOxr9hzlled1viRBXIvwTte1bSf4dJpwUIsWSJKo1BbWJwW1fhN A2rKZjSrPRqnzvSFPpJmRO3SZdVqG738atkz4iEc+oWYs5sjTbEErC1Yl+d0yoZS+YWr +nJ22b4Vc/isMgBWLMEp7nD7FYrSVQUXm42Ti4oBeM33zB6+E4wLlQhauFt4V9n9pj7L KxVy9xKyug/HL1HDcrEaNVonYwHt+qg1VpJDHO8+qt7exQBp7hNXkL8ZMcqsaFTjir1g 85YXmxDIDspO/ov0x4lSP/XICksXKVyGdTSyxrMmpe12QeNQ2NKKc6Dy+Csb4OZIyhIC UtwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gj53TGrcFKvg3WdH/kBUkM4Hf1Vz6A2pmV6JoIO4uQg=; b=al+hWyxtnX0Y5nGgL+NvfOaBr/2jaMPDzqkKWCVU0BzHFqYVfw//7LE00n2wYtx11Z U9095jyXLjBhgfjDBGNf/1PCEi3ZQFhYTU2LVRX6tY1SNgJr95/eNWYS2hBuwcaBnOsx bViqcw9bCZdGZZHlmXddbUn2ibYdY7FlFFdiKv/gd5kjlr0KBeBUBpDWn62A2M66tYBZ o62STqKn2RmM1S8toLgPdnrS4URRfIOJLP+mNy1v4H5+ALNHgr+z/zqSkEk9Tu04vigj QLFyqSD3rXfDK9FifLX9WZPRIF/bScVuy1yMXw73GbMVaPMUddRN6B01nv2S25YnJTHT LTFQ== X-Gm-Message-State: AOAM5315Ixv2lfSVe782RxVfgsknmYXgb5Svyhvfp2mEZ9ET+rI9excx RIvUrC+Gy2DUFqAKzaE2bKs= X-Google-Smtp-Source: ABdhPJyGs8DWQ8wnxJdTEW/zlBdhQNuphjeSfXyBIMlzudn7ozMmCizNULarv7m5YEryAN0jhXtMWw== X-Received: by 2002:a9f:3189:0:b0:35c:c458:ee11 with SMTP id v9-20020a9f3189000000b0035cc458ee11mr36371517uad.31.1654680082621; Wed, 08 Jun 2022 02:21:22 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id v21-20020a056122121500b0035d31e4bb01sm2543501vkc.6.2022.06.08.02.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 02:21:21 -0700 (PDT) From: Florian Fainelli To: bcm-kernel-feedback-list@broadcom.com, Miaoqian Lin , Andrew Morton , Thomas Bogendoerfer , Kees Cook , Helge Deller , Bjorn Andersson , Andy Shevchenko , Gareth Powell , Brian Norris , Doug Berger , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm_probe Date: Wed, 8 Jun 2022 02:21:18 -0700 Message-Id: <20220608092118.1463835-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220526075325.27356-1-linmq006@gmail.com> References: <20220526075325.27356-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 May 2022 11:53:22 +0400, Miaoqian Lin wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > In brcmstb_init_sram, it pass dn to of_address_to_resource(), > of_address_to_resource() will call of_find_device_by_node() to take > reference, so we should release the reference returned by > of_find_matching_node(). > > Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") > Signed-off-by: Miaoqian Lin > --- Applied to https://github.com/Broadcom/stblinux/commits/drivers/fixes, thanks! -- Florian