From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2CBC433EF for ; Wed, 8 Jun 2022 14:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241237AbiFHOdo (ORCPT ); Wed, 8 Jun 2022 10:33:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241005AbiFHOdl (ORCPT ); Wed, 8 Jun 2022 10:33:41 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D8DB2348D0 for ; Wed, 8 Jun 2022 07:33:40 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id o8so789640wro.3 for ; Wed, 08 Jun 2022 07:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WG0Tg8LMw+6v7cVOptDrWGidi6Emu/7DP7YsEfxFl6U=; b=w5ns9byp/YevaOrUVFMpt6yWKTxidJfob2R42ggpIXdfZryqVTt3BWo/JEXVWZr1j/ 8MQNNoSDO31sJw5ZxAGkWLRTguwolkAR3GkglPLBkfmQicHsLq0mpDWMII4t1rzJpDSJ 1qHXNvuzp6rjxNOWug5lHVQ1Il0O3D1ScFGdxV1xsT2LMfxiK259cV7VikZuqUCgPH4Y abglkbFh7NIHE458XQ+pUluGsmU1Zvwx68tYsCfUfH4jlgyCZa/rIEjXR31fayXJJLKS imGwHjwGsoi0YKCMsil6mG/1USLI9QpcLwjnixUtFthbfRihxmZjOD7OcuAzV4fAmJI9 /Umw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WG0Tg8LMw+6v7cVOptDrWGidi6Emu/7DP7YsEfxFl6U=; b=WA5NAAUOuQ0GbD96Re4nJwrJnjoJW+bzXfADZrZPyNNok/4dp9+sTyITKghuVEAd3X XoZDWSEFUmlvDBCCjBiXT0chbKdaEjAIKvYMoCj4SyoqPL9eRf0E9SE9cwJKaAYEZwLs zpAZdIXR0V/3HDNQ04Mj+WqVBr4gYPUWbz1Z/ihN/TGY565KvZTAr5JE4qma26V9eDEk 8zX5j/kfiHNJum2rQLWkeHgTz2K3GqOyCpPLTOioiyBuABSo3C85Xk0EePewzD6f3Fve /PRW3IwpLvdjnxw5P0LID1m9L/gZO6as0hqfDXqt+yrH7sgDW2syOKjGOZg8QS4s/Zh7 Nzcg== X-Gm-Message-State: AOAM530MVw/06hSmzIHE/MVZKXjZSheE1+vboNk61vGNLzOW5g1G711b zJwOuNlj3x0hL4kK0Bo46uraBg== X-Google-Smtp-Source: ABdhPJxvKQxEHFDay/r4QAKbU2kqfhMU+/AqDh0VaknrdyOg+5OV5Q/qtMdENt7I/tH2UsYyr2+h+A== X-Received: by 2002:a5d:5410:0:b0:218:5b98:425 with SMTP id g16-20020a5d5410000000b002185b980425mr4976962wrv.243.1654698818607; Wed, 08 Jun 2022 07:33:38 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id o7-20020a5d62c7000000b0020fe86d340fsm21422134wrv.55.2022.06.08.07.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 07:33:38 -0700 (PDT) Date: Wed, 8 Jun 2022 15:33:36 +0100 From: Daniel Thompson To: Stephen Kitt Cc: Lee Jones , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] backlight: arcxcnn: Use backlight helper Message-ID: <20220608143336.duk2g75jjnwxxa2g@maple.lan> References: <20220607190925.1134737-1-steve@sk2.org> <20220607190925.1134737-3-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607190925.1134737-3-steve@sk2.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 09:09:23PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Helge Deller > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org Reviewed-by: Daniel Thompson Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACE32C433EF for ; Wed, 8 Jun 2022 14:33:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 002D510E495; Wed, 8 Jun 2022 14:33:40 +0000 (UTC) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 131DC10E495 for ; Wed, 8 Jun 2022 14:33:40 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id k16so28643294wrg.7 for ; Wed, 08 Jun 2022 07:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WG0Tg8LMw+6v7cVOptDrWGidi6Emu/7DP7YsEfxFl6U=; b=w5ns9byp/YevaOrUVFMpt6yWKTxidJfob2R42ggpIXdfZryqVTt3BWo/JEXVWZr1j/ 8MQNNoSDO31sJw5ZxAGkWLRTguwolkAR3GkglPLBkfmQicHsLq0mpDWMII4t1rzJpDSJ 1qHXNvuzp6rjxNOWug5lHVQ1Il0O3D1ScFGdxV1xsT2LMfxiK259cV7VikZuqUCgPH4Y abglkbFh7NIHE458XQ+pUluGsmU1Zvwx68tYsCfUfH4jlgyCZa/rIEjXR31fayXJJLKS imGwHjwGsoi0YKCMsil6mG/1USLI9QpcLwjnixUtFthbfRihxmZjOD7OcuAzV4fAmJI9 /Umw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WG0Tg8LMw+6v7cVOptDrWGidi6Emu/7DP7YsEfxFl6U=; b=Oq/BXq0G9J8rN6L6+qVN/qv9REwkzuRh2Uaavg8Lu4KOajP89Lh4tcN1JAD1o6a1L8 ft24hV90+jtwuvhD6fEgI+ZSMUZg7ImKxSTbULrwzT8h8kDzdmFCZldigPPWP04799RF Di+sUQ4veATjOXyD6wgiJlHmqrimen0HLXHPPUcBxBYFa2Yx3O3tpBKPyl/PkdCtW7md OU76WRQMEKwyVGPiijxtyzQbSnIF+lj2ApoaBz8afMxB8TXn2qXwzIB/oYxLYleMdocU SaKV5hQXIPSXqKaljJ9O0tHMY0QS6/iiJ07IDIyf9wr55S1r0TVJsC9jvOoa3w2g3Zin 5eoQ== X-Gm-Message-State: AOAM530eRrU/AQJVC0B0Y9KI3r/1fnexAc1F9qJHsYImbFlyj/qiJfed ZOA8rQR7omw8NFZSt+wc0ZC5TA== X-Google-Smtp-Source: ABdhPJxvKQxEHFDay/r4QAKbU2kqfhMU+/AqDh0VaknrdyOg+5OV5Q/qtMdENt7I/tH2UsYyr2+h+A== X-Received: by 2002:a5d:5410:0:b0:218:5b98:425 with SMTP id g16-20020a5d5410000000b002185b980425mr4976962wrv.243.1654698818607; Wed, 08 Jun 2022 07:33:38 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id o7-20020a5d62c7000000b0020fe86d340fsm21422134wrv.55.2022.06.08.07.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 07:33:38 -0700 (PDT) Date: Wed, 8 Jun 2022 15:33:36 +0100 From: Daniel Thompson To: Stephen Kitt Subject: Re: [PATCH 2/4] backlight: arcxcnn: Use backlight helper Message-ID: <20220608143336.duk2g75jjnwxxa2g@maple.lan> References: <20220607190925.1134737-1-steve@sk2.org> <20220607190925.1134737-3-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607190925.1134737-3-steve@sk2.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jingoo Han , Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 07, 2022 at 09:09:23PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Helge Deller > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org Reviewed-by: Daniel Thompson Daniel.