From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC08C433EF for ; Wed, 8 Jun 2022 22:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbiFHWtR (ORCPT ); Wed, 8 Jun 2022 18:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbiFHWtQ (ORCPT ); Wed, 8 Jun 2022 18:49:16 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA74228716; Wed, 8 Jun 2022 15:49:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 18F51CE2C8A; Wed, 8 Jun 2022 22:49:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5C22C34116; Wed, 8 Jun 2022 22:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654728551; bh=KoDfYZU8H3/Jk6nelCnyzGy1ViLp+HOvc80VTERRhLk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c47L61jNlPTTvhMermxgEoTOR9tWN65ALmSIUqWA/wuOeo+x67eQrpqH+NwJc5S+h PXtQCy08WczMlRL1nrqYaTzNO8rQ7ucEMUfc1fak2OFB8n3dUP4d+rjMPwR2VNbPH0 Mf6l5WTxg4u1Kcn783ubkdYv2krRDz2t1vUTXPBVPXt9B8mkQ0GMHULzam2VTrceSn vNzj7lGKeQ8LZvsupIlQG5hs80ef3vrgPzzmPrVZUmCHf0eyTLpjvNj41LJJPA7k1D MGP0elVE6cT4SScOWE7iEvpStoF4640FLL1sX7CvK+m4RK4FHM2MPS5Q45TdRfX4j3 QUGUYhF+ECwLQ== Date: Wed, 8 Jun 2022 15:49:08 -0700 From: Jakub Kicinski To: Saravana Kannan Cc: Geert Uytterhoeven , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Len Brown , Pavel Machek , Joerg Roedel , Will Deacon , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Linus Walleij , David Ahern , Android Kernel Team , Linux Kernel Mailing List , Linux PM list , Linux IOMMU , netdev , "open list:GPIO SUBSYSTEM" , Linux-Renesas , Niklas =?UTF-8?B?U8O2ZGVybHVuZA==?= , Laurent Pinchart , Rob Herring , Vladimir Oltean , Florian Fainelli , Thomas Bogendoerfer Subject: Re: [PATCH v2 0/9] deferred_probe_timeout logic clean up Message-ID: <20220608154908.4ddb9795@kernel.org> In-Reply-To: References: <20220601070707.3946847-1-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 8 Jun 2022 14:07:44 -0700 Saravana Kannan wrote: > David/Jakub, > > Do the IP4 autoconfig changes look reasonable to you? I'm no expert in this area, I'd trust the opinion of the embedded folks (adding Florian as well) more than myself. It's unclear to me why we'd wait_for_init_devices_probe() after the first failed iteration, sleep, and then allow 11 more iterations with wait_for_device_probe(). Let me also add Thomas since he wrote e2ffe3ff6f5e ("net: ipconfig: Wait for deferred device probes"). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50779C43334 for ; Wed, 8 Jun 2022 22:49:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id EB478408DB; Wed, 8 Jun 2022 22:49:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CjaCKCdDcFkO; Wed, 8 Jun 2022 22:49:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id E0A14400A6; Wed, 8 Jun 2022 22:49:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 98D29C0039; Wed, 8 Jun 2022 22:49:14 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id BDC54C002D for ; Wed, 8 Jun 2022 22:49:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A64F58141D for ; Wed, 8 Jun 2022 22:49:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id voip3A_-htxm for ; Wed, 8 Jun 2022 22:49:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1E217813FF for ; Wed, 8 Jun 2022 22:49:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C261361735; Wed, 8 Jun 2022 22:49:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5C22C34116; Wed, 8 Jun 2022 22:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654728551; bh=KoDfYZU8H3/Jk6nelCnyzGy1ViLp+HOvc80VTERRhLk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c47L61jNlPTTvhMermxgEoTOR9tWN65ALmSIUqWA/wuOeo+x67eQrpqH+NwJc5S+h PXtQCy08WczMlRL1nrqYaTzNO8rQ7ucEMUfc1fak2OFB8n3dUP4d+rjMPwR2VNbPH0 Mf6l5WTxg4u1Kcn783ubkdYv2krRDz2t1vUTXPBVPXt9B8mkQ0GMHULzam2VTrceSn vNzj7lGKeQ8LZvsupIlQG5hs80ef3vrgPzzmPrVZUmCHf0eyTLpjvNj41LJJPA7k1D MGP0elVE6cT4SScOWE7iEvpStoF4640FLL1sX7CvK+m4RK4FHM2MPS5Q45TdRfX4j3 QUGUYhF+ECwLQ== Date: Wed, 8 Jun 2022 15:49:08 -0700 From: Jakub Kicinski To: Saravana Kannan Subject: Re: [PATCH v2 0/9] deferred_probe_timeout logic clean up Message-ID: <20220608154908.4ddb9795@kernel.org> In-Reply-To: References: <20220601070707.3946847-1-saravanak@google.com> MIME-Version: 1.0 Cc: Andrew Lunn , Ulf Hansson , "Rafael J. Wysocki" , Vladimir Oltean , Linus Walleij , Eric Dumazet , Pavel Machek , Will Deacon , Thomas Bogendoerfer , Laurent Pinchart , Kevin Hilman , Russell King , Geert Uytterhoeven , Paolo Abeni , Android Kernel Team , Len Brown , Linux PM list , "open list:GPIO SUBSYSTEM" , Rob Herring , Florian Fainelli , Niklas =?UTF-8?B?U8O2ZGVybHVuZA==?= , Greg Kroah-Hartman , David Ahern , Linux Kernel Mailing List , Linux-Renesas , Linux IOMMU , netdev , "David S. Miller" , Heiner Kallweit X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, 8 Jun 2022 14:07:44 -0700 Saravana Kannan wrote: > David/Jakub, > > Do the IP4 autoconfig changes look reasonable to you? I'm no expert in this area, I'd trust the opinion of the embedded folks (adding Florian as well) more than myself. It's unclear to me why we'd wait_for_init_devices_probe() after the first failed iteration, sleep, and then allow 11 more iterations with wait_for_device_probe(). Let me also add Thomas since he wrote e2ffe3ff6f5e ("net: ipconfig: Wait for deferred device probes"). _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu