From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD39AC43334 for ; Wed, 8 Jun 2022 18:55:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232775AbiFHSzB (ORCPT ); Wed, 8 Jun 2022 14:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229752AbiFHSy5 (ORCPT ); Wed, 8 Jun 2022 14:54:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BDAC1216E2; Wed, 8 Jun 2022 11:54:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBE4261BFD; Wed, 8 Jun 2022 18:54:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCE74C34116; Wed, 8 Jun 2022 18:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654714496; bh=4DkBSx4PBlnqbuIvbhb4BY8MQw6NCv8/SsM4J3UI200=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nk2FUfxEP+uq3OPC6Dt0OjmJBwVFkRhSYXWUqZCTKRS1QEn7Oj6wz15yH1dfa+Um8 /QxZ8R3hevC4EyX8LfK/sKFeav+F0Efn0n551rE6G+cqrq1Q4wPtS58Ih15LTaRy89 FNxo3h2Nby46ARYYtazJVL+UIiR9LprPxwmS7SzyIFwhG9L07Z515sqVoaALr9pc/W CGGFIou/eiDJgdZcIvisYj8xTAXySksWdIckimvcK2obq1i6xDi+SqkXnafvtdCmzm GfQ2WsLCjxdImBQV4T6cqOXqdvkrXPnQwt6XbUDJXlrYqOX/bLEDfTdlxwWlYxMs3e dWBrpCBCWH0PQ== Date: Wed, 8 Jun 2022 13:54:53 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Message-ID: <20220608185453.GA410841@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1651801629-30223-6-git-send-email-hongxing.zhu@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2022 at 09:47:06AM +0800, Richard Zhu wrote: > The driver should undo any enables it did itself. The regulator disable > shouldn't be basing decisions on regulator_is_enabled(). > > To keep the balance of the regulator usage counter, disable the regulator > just behind of imx6_pcie_assert_core_reset() in resume and shutdown. In subject, "Refine" doesn't tell me anything about what's happening here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 426B5C43334 for ; Wed, 8 Jun 2022 18:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=0cDReBAa8h3CUNUvTxUi2rUOjXC3XcyvX1W2bfR2uPY=; b=3I8U/pJ6TgCpmT 5nFG4DjjnLszBDf8UfUGG0wrqL1N7ULpKZApYAfqBB3yGS3/kg1cWQONsgqKcQpO9XQGgu97QfiuD kxPzs/yBlMamzb68cvw+tCZiddddEooMfSC+ca5K/NMsxcVpqBJfHSbLomEHxFgaE3XVOQ4Gz5z3W 6CMjD48BKzPML5ioEZVNxHcDZRAM0GvVgJLIj0ZDUTHzx7oejlMd5YKl7Q8puiWCzCSywv5w4OMJk OCXgC1wsuCM20kdbWkcZHw1dV4IHHyEe7w98yuf/kQ5nkj4FtNNt3L1BWdGBPor+IujEb4/FoV2ot lUpJdcq4FkiFD0HWiYMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz0pa-00Ej9j-Jk; Wed, 08 Jun 2022 18:55:02 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz0pX-00Ej8a-2b for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 18:55:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 883ADB82616; Wed, 8 Jun 2022 18:54:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCE74C34116; Wed, 8 Jun 2022 18:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654714496; bh=4DkBSx4PBlnqbuIvbhb4BY8MQw6NCv8/SsM4J3UI200=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nk2FUfxEP+uq3OPC6Dt0OjmJBwVFkRhSYXWUqZCTKRS1QEn7Oj6wz15yH1dfa+Um8 /QxZ8R3hevC4EyX8LfK/sKFeav+F0Efn0n551rE6G+cqrq1Q4wPtS58Ih15LTaRy89 FNxo3h2Nby46ARYYtazJVL+UIiR9LprPxwmS7SzyIFwhG9L07Z515sqVoaALr9pc/W CGGFIou/eiDJgdZcIvisYj8xTAXySksWdIckimvcK2obq1i6xDi+SqkXnafvtdCmzm GfQ2WsLCjxdImBQV4T6cqOXqdvkrXPnQwt6XbUDJXlrYqOX/bLEDfTdlxwWlYxMs3e dWBrpCBCWH0PQ== Date: Wed, 8 Jun 2022 13:54:53 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Message-ID: <20220608185453.GA410841@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1651801629-30223-6-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_115459_304130_23BBD06F X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 06, 2022 at 09:47:06AM +0800, Richard Zhu wrote: > The driver should undo any enables it did itself. The regulator disable > shouldn't be basing decisions on regulator_is_enabled(). > > To keep the balance of the regulator usage counter, disable the regulator > just behind of imx6_pcie_assert_core_reset() in resume and shutdown. In subject, "Refine" doesn't tell me anything about what's happening here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel