From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686CCC433EF for ; Thu, 9 Jun 2022 15:19:28 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7717640689; Thu, 9 Jun 2022 17:19:27 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8961340220 for ; Thu, 9 Jun 2022 17:19:25 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id CDAFD20BE67A; Thu, 9 Jun 2022 08:19:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CDAFD20BE67A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1654787964; bh=pjv0VooGI1AGKXAbBLdfoMgngqQQPUKQxNKMnnlTik4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ST/rN4T9HNgnKsVKxjTOAp9wnLDxmyyBceBgHFcRKE3g216Lm1lknnxw2+FG5jHAm yRa/Fpi7A5m/h+J4p5IcDvV/e/03zQJCj1GPG3Z1h0lg9MHGPexBjgHeUW4ARILC4P iv6WRJUBXgS60hP3451hJzoac2z5JPBouTEstQJo= Date: Thu, 9 Jun 2022 08:19:24 -0700 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v4 0/4] clean up zero-length arrays Message-ID: <20220609151924.GA24583@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20220602150834.643745-1-bruce.richardson@intel.com> <20220603111625.562070-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603111625.562070-1-bruce.richardson@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org does this mean we now *require* a C99 compiler? (which i have no problem with) Series-acked-by: Tyler Retzlaff On Fri, Jun 03, 2022 at 12:16:21PM +0100, Bruce Richardson wrote: > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > V4: removed change from struct ipsec_encap_pdb in common/dpaax, which > caused build errors > > V3: Fixed issues in mlx5 drivers: > * fixed incorrect coccinelle replacement of 2-D zero-length arrays > * undid removal of "0" in tx elts[] which caused issues with Werror-pedantic > > V2: rebased to fix apply conflict > > Bruce Richardson (4): > cocci: add script for zero-length arrays in structs > drivers: replace zero-length arrays with undimensioned ones > lib: replace zero-length arrays with undimensioned ones > app: examples: replace zero-length arrays with undimensioned ones > > app/test/test_table_tables.c | 2 +- > devtools/cocci/zero_length_array.cocci | 21 +++++++++++++++++++ > drivers/bus/dpaa/include/netcfg.h | 4 ++-- > drivers/bus/vmbus/rte_vmbus_reg.h | 4 ++-- > drivers/common/cnxk/roc_se.h | 2 +- > drivers/common/dpaax/dpaax_iova_table.h | 2 +- > drivers/common/mlx5/mlx5_prm.h | 10 ++++----- > drivers/crypto/ipsec_mb/ipsec_mb_private.h | 4 ++-- > drivers/crypto/virtio/virtio_ring.h | 4 ++-- > drivers/crypto/virtio/virtqueue.h | 2 +- > drivers/net/atlantic/hw_atl/hw_atl_utils.h | 2 +- > drivers/net/cxgbe/clip_tbl.h | 2 +- > drivers/net/cxgbe/l2t.h | 2 +- > drivers/net/cxgbe/mps_tcam.h | 2 +- > drivers/net/cxgbe/smt.h | 2 +- > drivers/net/enic/base/vnic_devcmd.h | 2 +- > drivers/net/hinic/hinic_pmd_tx.h | 2 +- > drivers/net/nfp/nfpcore/nfp_nsp.h | 2 +- > drivers/net/virtio/virtio_ring.h | 4 ++-- > drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +- > drivers/net/virtio/virtio_user/vhost_vdpa.c | 2 +- > drivers/net/virtio/virtqueue.h | 2 +- > drivers/regex/mlx5/mlx5_rxp.h | 4 ++-- > examples/ip_reassembly/main.c | 2 +- > examples/ptpclient/ptpclient.c | 4 ++-- > lib/cryptodev/cryptodev_pmd.h | 2 +- > lib/cryptodev/rte_cryptodev.h | 2 +- > lib/eventdev/rte_event_timer_adapter.h | 2 +- > lib/ip_frag/ip_reassembly.h | 2 +- > lib/ipsec/sa.h | 2 +- > lib/rib/rte_rib.c | 2 +- > lib/rib/rte_rib6.c | 2 +- > lib/table/rte_swx_table_learner.c | 4 ++-- > lib/table/rte_table_hash_key16.c | 4 ++-- > lib/table/rte_table_hash_key32.c | 4 ++-- > lib/table/rte_table_hash_key8.c | 4 ++-- > lib/vhost/rte_vhost.h | 4 ++-- > 37 files changed, 73 insertions(+), 52 deletions(-) > create mode 100644 devtools/cocci/zero_length_array.cocci > > -- > 2.34.1