From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F16CCA473 for ; Thu, 9 Jun 2022 16:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244358AbiFIQ0E (ORCPT ); Thu, 9 Jun 2022 12:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239526AbiFIQZ6 (ORCPT ); Thu, 9 Jun 2022 12:25:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8F34196; Thu, 9 Jun 2022 09:25:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5213360BD3; Thu, 9 Jun 2022 16:25:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D961C34114; Thu, 9 Jun 2022 16:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654791953; bh=GUCfjj07MT21bODoY17PnMWnqynvpsdI6YTnfv/B07o=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=SZyyFGAm1zl4BW7SYoFMufNROhh/TWjXza+m9Cb/8LVsrN2baONmnwuYXzFnJsDde 0mP0h1dGYQVtmXVyEqDtXaKGlOUOZ1k/EgTu/WfB2+edgj4Jh03pGJec8wO5kaBTfD +wAkMVSBYZRRM/p+hF1BkfN87wDzJHFrRTkzMAUnAx6q18rHUgnfDEc6XviyPOR0Su G9IKS45WM6owg29rxC228tyuGO54WQ6N4ElJzxhHwQ1rTvbKiTC9Pe4JvSy7FbdgWP Hj3wHj9+8Utuh8LSeMmpKpKWQ88p5P8Ngw7+BVx7wSaZtKvxlx7GCuK+/OA1WmT1BJ Bwo0YL/VTFXeQ== Date: Thu, 9 Jun 2022 11:25:52 -0500 From: Bjorn Helgaas To: Hongxing Zhu Cc: "l.stach@pengutronix.de" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "lorenzo.pieralisi@arm.com" , "jingoohan1@gmail.com" , "festevam@gmail.com" , "francesco.dolcini@toradex.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" , dl-linux-imx Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper places Message-ID: <20220609162552.GA514635@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 06:20:16AM +0000, Hongxing Zhu wrote: > > -----Original Message----- > > From: Bjorn Helgaas > > Sent: 2022年6月9日 2:58 > > To: Hongxing Zhu > > Cc: l.stach@pengutronix.de; bhelgaas@google.com; robh+dt@kernel.org; > > broonie@kernel.org; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com; > > festevam@gmail.com; francesco.dolcini@toradex.com; > > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > > > > Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the > > proper places > > > > On Fri, May 06, 2022 at 09:47:08AM +0800, Richard Zhu wrote: > > > To make it more reasonable, move the phy_power_on/phy_init callbacks > > > to the proper places. > > > - move the phy_power_on() out of imx6_pcie_clk_enable(). > > > - move the phy_init() out of imx6_pcie_deassert_core_reset(). > > > > I'm not sure what "make it more reasonable" is telling me. In > > subject line and commit log, please say something more specific > > than "the proper places." > > > > It's probably more important to say where they are moving *to* > > than where they're moving *out of*. > Thanks for your comments. > In another review loop listed below, Lucas used said that it's not > good to hide PHY init in imx6_pcie_assert_core_reset() So, I make a > try to move the phy_init() out of imx6_pcie_assert_core_reset(). > And move phy_power_on() out of imx6_pcie_clk_enable() accordingly. > https://patchwork.kernel.org/project/linux-pci/patch/1646289275-17813-1-git-send-email-hongxing.zhu@nxp.com/ > Okay, I would specific that they are moving *to* later. > > > > In order to save power consumption, turn off the clocks and > > > regulators when the imx6_pcie_host_init() return error. > > > > Is the power savings the *reason* for this change? I can't tell > > from the commit log. > > The error handling of the imx6_pcie_host_init() is not mentioned in > the subject. Should I split these changes into two patches? If they can be split, they probably should be split. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB7B7C433EF for ; Thu, 9 Jun 2022 16:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=vRbOCBKZshjqrqVXeflSlZQPvAcP7MiFMFRd08BUQ/U=; b=eLAcbCpNlXGjH/ NCVklx13vg1vXHG7Oc5L69LcbgOcxq5k4zbhUgai62sn+b9+BswIlM3pkSyZmEuYiPGavDyx3+q8D EY67XCU+hfXcolOn4EvnJJFp9MeNHesdBow3I1dwDtRxo8KqDcfrAdbKXKd+lGz28t+kewThqZ5Jv E26Jh8Tt65U0oEnTEMHa725lVakn2Abgcwi2g0YLXxY1s3OJhOqrQ28WBZMIl1kwQ2JJxVKx/mJSf wSy4e9JXOsCpM4h7543YcrroGLy7X5t4tlNanTFG0wI9IYnwInHlslzb16cxseTjLZOesL+y5g23q 3Tg4CEfu8SVwyd8mSPXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzKyu-002rpv-H8; Thu, 09 Jun 2022 16:26:00 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzKyq-002rp3-Fb for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2022 16:25:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0A52B82E31; Thu, 9 Jun 2022 16:25:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D961C34114; Thu, 9 Jun 2022 16:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654791953; bh=GUCfjj07MT21bODoY17PnMWnqynvpsdI6YTnfv/B07o=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=SZyyFGAm1zl4BW7SYoFMufNROhh/TWjXza+m9Cb/8LVsrN2baONmnwuYXzFnJsDde 0mP0h1dGYQVtmXVyEqDtXaKGlOUOZ1k/EgTu/WfB2+edgj4Jh03pGJec8wO5kaBTfD +wAkMVSBYZRRM/p+hF1BkfN87wDzJHFrRTkzMAUnAx6q18rHUgnfDEc6XviyPOR0Su G9IKS45WM6owg29rxC228tyuGO54WQ6N4ElJzxhHwQ1rTvbKiTC9Pe4JvSy7FbdgWP Hj3wHj9+8Utuh8LSeMmpKpKWQ88p5P8Ngw7+BVx7wSaZtKvxlx7GCuK+/OA1WmT1BJ Bwo0YL/VTFXeQ== Date: Thu, 9 Jun 2022 11:25:52 -0500 From: Bjorn Helgaas To: Hongxing Zhu Cc: "l.stach@pengutronix.de" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "lorenzo.pieralisi@arm.com" , "jingoohan1@gmail.com" , "festevam@gmail.com" , "francesco.dolcini@toradex.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" , dl-linux-imx Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper places Message-ID: <20220609162552.GA514635@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_092556_852422_4C4BEC9E X-CRM114-Status: GOOD ( 22.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMDksIDIwMjIgYXQgMDY6MjA6MTZBTSArMDAwMCwgSG9uZ3hpbmcgWmh1IHdy b3RlOgo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEJqb3JuIEhlbGdh YXMgPGhlbGdhYXNAa2VybmVsLm9yZz4KPiA+IFNlbnQ6IDIwMjLlubQ25pyIOeaXpSAyOjU4Cj4g PiBUbzogSG9uZ3hpbmcgWmh1IDxob25neGluZy56aHVAbnhwLmNvbT4KPiA+IENjOiBsLnN0YWNo QHBlbmd1dHJvbml4LmRlOyBiaGVsZ2Fhc0Bnb29nbGUuY29tOyByb2JoK2R0QGtlcm5lbC5vcmc7 Cj4gPiBicm9vbmllQGtlcm5lbC5vcmc7IGxvcmVuem8ucGllcmFsaXNpQGFybS5jb207IGppbmdv b2hhbjFAZ21haWwuY29tOwo+ID4gZmVzdGV2YW1AZ21haWwuY29tOyBmcmFuY2VzY28uZG9sY2lu aUB0b3JhZGV4LmNvbTsKPiA+IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsKPiA+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5v cmc7IGtlcm5lbEBwZW5ndXRyb25peC5kZTsgZGwtbGludXgtaW14Cj4gPiA8bGludXgtaW14QG54 cC5jb20+Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHY5IDcvOF0gUENJOiBpbXg2OiBNb3ZlIHRo ZSBwaHkgZHJpdmVyIGNhbGxiYWNrcyB0byB0aGUKPiA+IHByb3BlciBwbGFjZXMKPiA+IAo+ID4g T24gRnJpLCBNYXkgMDYsIDIwMjIgYXQgMDk6NDc6MDhBTSArMDgwMCwgUmljaGFyZCBaaHUgd3Jv dGU6Cj4gPiA+IFRvIG1ha2UgaXQgbW9yZSByZWFzb25hYmxlLCBtb3ZlIHRoZSBwaHlfcG93ZXJf b24vcGh5X2luaXQgY2FsbGJhY2tzCj4gPiA+IHRvIHRoZSBwcm9wZXIgcGxhY2VzLgo+ID4gPiAt IG1vdmUgdGhlIHBoeV9wb3dlcl9vbigpIG91dCBvZiBpbXg2X3BjaWVfY2xrX2VuYWJsZSgpLgo+ ID4gPiAtIG1vdmUgdGhlIHBoeV9pbml0KCkgb3V0IG9mIGlteDZfcGNpZV9kZWFzc2VydF9jb3Jl X3Jlc2V0KCkuCj4gPiAKPiA+IEknbSBub3Qgc3VyZSB3aGF0ICJtYWtlIGl0IG1vcmUgcmVhc29u YWJsZSIgaXMgdGVsbGluZyBtZS4gIEluCj4gPiBzdWJqZWN0IGxpbmUgYW5kIGNvbW1pdCBsb2cs IHBsZWFzZSBzYXkgc29tZXRoaW5nIG1vcmUgc3BlY2lmaWMKPiA+IHRoYW4gInRoZSBwcm9wZXIg cGxhY2VzLiIKPiA+IAo+ID4gSXQncyBwcm9iYWJseSBtb3JlIGltcG9ydGFudCB0byBzYXkgd2hl cmUgdGhleSBhcmUgbW92aW5nICp0byoKPiA+IHRoYW4gd2hlcmUgdGhleSdyZSBtb3ZpbmcgKm91 dCBvZiouCgo+IFRoYW5rcyBmb3IgeW91ciBjb21tZW50cy4KPiBJbiBhbm90aGVyIHJldmlldyBs b29wIGxpc3RlZCBiZWxvdywgTHVjYXMgdXNlZCBzYWlkIHRoYXQgaXQncyBub3QKPiBnb29kIHRv IGhpZGUgUEhZIGluaXQgaW4gaW14Nl9wY2llX2Fzc2VydF9jb3JlX3Jlc2V0KCkgU28sIEkgbWFr ZSBhCj4gdHJ5IHRvIG1vdmUgdGhlIHBoeV9pbml0KCkgb3V0IG9mIGlteDZfcGNpZV9hc3NlcnRf Y29yZV9yZXNldCgpLgo+IEFuZCBtb3ZlIHBoeV9wb3dlcl9vbigpIG91dCBvZiBpbXg2X3BjaWVf Y2xrX2VuYWJsZSgpIGFjY29yZGluZ2x5Lgo+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcv cHJvamVjdC9saW51eC1wY2kvcGF0Y2gvMTY0NjI4OTI3NS0xNzgxMy0xLWdpdC1zZW5kLWVtYWls LWhvbmd4aW5nLnpodUBueHAuY29tLwo+IE9rYXksIEkgd291bGQgc3BlY2lmaWMgdGhhdCB0aGV5 IGFyZSBtb3ZpbmcgKnRvKiBsYXRlci4KPiAKPiA+ID4gSW4gb3JkZXIgdG8gc2F2ZSBwb3dlciBj b25zdW1wdGlvbiwgdHVybiBvZmYgdGhlIGNsb2NrcyBhbmQKPiA+ID4gcmVndWxhdG9ycyB3aGVu IHRoZSBpbXg2X3BjaWVfaG9zdF9pbml0KCkgcmV0dXJuIGVycm9yLgo+ID4gCj4gPiBJcyB0aGUg cG93ZXIgc2F2aW5ncyB0aGUgKnJlYXNvbiogZm9yIHRoaXMgY2hhbmdlPyAgSSBjYW4ndCB0ZWxs Cj4gPiBmcm9tIHRoZSBjb21taXQgbG9nLgo+Cj4gVGhlIGVycm9yIGhhbmRsaW5nIG9mIHRoZSBp bXg2X3BjaWVfaG9zdF9pbml0KCkgaXMgbm90IG1lbnRpb25lZCBpbgo+IHRoZSBzdWJqZWN0LiAg U2hvdWxkIEkgc3BsaXQgdGhlc2UgY2hhbmdlcyBpbnRvIHR3byBwYXRjaGVzPwoKSWYgdGhleSBj YW4gYmUgc3BsaXQsIHRoZXkgcHJvYmFibHkgc2hvdWxkIGJlIHNwbGl0LgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=