From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A91A2C43334 for ; Thu, 9 Jun 2022 17:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245466AbiFIRUP (ORCPT ); Thu, 9 Jun 2022 13:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237908AbiFIRUL (ORCPT ); Thu, 9 Jun 2022 13:20:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26F8510A626; Thu, 9 Jun 2022 10:20:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D3DF2B82CF1; Thu, 9 Jun 2022 17:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A294C34114; Thu, 9 Jun 2022 17:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654795207; bh=4NBmqBaLVY+yEmiNx4pjhS4d00HTDgx39QqkUmgT31Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=hX5PbRpEXk03UpYoLoF3BSzu2mTvSdWIS2Gtshh1PrRcCxQbELdYJnLUugLyF2GkH kZgNxJ/29o/0r79EIUvzKXv/hIN/FQB1ef+v6M7yEHREzK80bqS/PczhbaYWEcbJ/I v2EXX0d37HVcN7M1opZzMOadRxlBQjO/Zun4KGa6cQ7M0WcyXkg4RyT0xeZ4+HidTs lcOUN/HEKjGmk0cly2IGUSdbu7x3p7DGoEpa61PuJBRaWA6qQHdRcx86aTQS3a96Y3 Pxz6eS821Q8/bcHVOq5wkADwMwoj/zeGbygiuTTXV4uHGLXkIQc13bPKqA8nZWF3Ov jq1HQ5szGRpPg== Date: Thu, 9 Jun 2022 12:20:05 -0500 From: Bjorn Helgaas To: Hongxing Zhu Cc: "l.stach@pengutronix.de" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "lorenzo.pieralisi@arm.com" , "jingoohan1@gmail.com" , "festevam@gmail.com" , "francesco.dolcini@toradex.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" , dl-linux-imx Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Message-ID: <20220609172005.GA514802@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 06:19:47AM +0000, Hongxing Zhu wrote: > > -----Original Message----- > > From: Bjorn Helgaas > > Sent: 2022年6月9日 2:55 > > To: Hongxing Zhu > > Cc: l.stach@pengutronix.de; bhelgaas@google.com; robh+dt@kernel.org; > > broonie@kernel.org; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com; > > festevam@gmail.com; francesco.dolcini@toradex.com; > > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > > > > Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage > > > > On Fri, May 06, 2022 at 09:47:06AM +0800, Richard Zhu wrote: > > > The driver should undo any enables it did itself. The regulator > > > disable shouldn't be basing decisions on regulator_is_enabled(). The driver should disable things if an error occurs after it has enabled something, or if it enabled something during probe and we're now detaching the driver. That doesn't look like the case here. > > > To keep the balance of the regulator usage counter, disable the > > > regulator just behind of imx6_pcie_assert_core_reset() in resume and > > > shutdown. > > > > In subject, "Refine" doesn't tell me anything about what's happening here. > > Thanks for your comments. > How about the following one? > PCI: imx6: Do regulator disable without the regulator_is_enabled check That's too low-level, like describing the C code line by line. I'm hoping for something about the purpose for the patch so "git log --oneline" can tell a coherent story. Apparently this is about disabling the power regulator when the slot isn't being used, so maybe it could say something about that. $ git grep -Ep "regulator_(en|dis)able" drivers/pci/controller/ shows that in other drivers, this being done in probe/remove/suspend/resume-type paths. imx6 should be similar. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87D16C43334 for ; Thu, 9 Jun 2022 17:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=MXrKX1JydN1A7EjjSz48aa4oq4oB9DjfIDOMwx8Q8Sk=; b=49jGGb60d32Cel pJbUiyFzaQjewhUCt7+mCr2rRCbMKuzIX5xi9FGotiWQd6hCYZtqBVkYqs2U4tULY7C0f4FWlQZ6D Zvcx+wdVeTvVlzOrGm6lKrqEEmO0fw6qpWV+hfSxteZYUSr/nWtaxMi+ZV0kZqi72o42ra9D2spLX 0eO2IrW6b3plKHOq6maw0dGgTxJNfDeXKpchpV33rtKmOj84tgAt/WSMaB2qEZNGQsIanW/Gkck11 OZVwKfR2gvrl9qki6sTo9Q4Iy6iYoOG4kiPxcQgasE5PITkREcvwcCfJi0N+BeyVEytYrsAFzOuNX dBx0c7pWv+yddrYbnWNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzLy2-0039Gd-QP; Thu, 09 Jun 2022 17:29:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzLpI-0034ws-Sy for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2022 17:20:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 339EF61AC4; Thu, 9 Jun 2022 17:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A294C34114; Thu, 9 Jun 2022 17:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654795207; bh=4NBmqBaLVY+yEmiNx4pjhS4d00HTDgx39QqkUmgT31Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=hX5PbRpEXk03UpYoLoF3BSzu2mTvSdWIS2Gtshh1PrRcCxQbELdYJnLUugLyF2GkH kZgNxJ/29o/0r79EIUvzKXv/hIN/FQB1ef+v6M7yEHREzK80bqS/PczhbaYWEcbJ/I v2EXX0d37HVcN7M1opZzMOadRxlBQjO/Zun4KGa6cQ7M0WcyXkg4RyT0xeZ4+HidTs lcOUN/HEKjGmk0cly2IGUSdbu7x3p7DGoEpa61PuJBRaWA6qQHdRcx86aTQS3a96Y3 Pxz6eS821Q8/bcHVOq5wkADwMwoj/zeGbygiuTTXV4uHGLXkIQc13bPKqA8nZWF3Ov jq1HQ5szGRpPg== Date: Thu, 9 Jun 2022 12:20:05 -0500 From: Bjorn Helgaas To: Hongxing Zhu Cc: "l.stach@pengutronix.de" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "lorenzo.pieralisi@arm.com" , "jingoohan1@gmail.com" , "festevam@gmail.com" , "francesco.dolcini@toradex.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" , dl-linux-imx Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Message-ID: <20220609172005.GA514802@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_102009_033876_E74590E7 X-CRM114-Status: GOOD ( 20.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMDksIDIwMjIgYXQgMDY6MTk6NDdBTSArMDAwMCwgSG9uZ3hpbmcgWmh1IHdy b3RlOgo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEJqb3JuIEhlbGdh YXMgPGhlbGdhYXNAa2VybmVsLm9yZz4KPiA+IFNlbnQ6IDIwMjLlubQ25pyIOeaXpSAyOjU1Cj4g PiBUbzogSG9uZ3hpbmcgWmh1IDxob25neGluZy56aHVAbnhwLmNvbT4KPiA+IENjOiBsLnN0YWNo QHBlbmd1dHJvbml4LmRlOyBiaGVsZ2Fhc0Bnb29nbGUuY29tOyByb2JoK2R0QGtlcm5lbC5vcmc7 Cj4gPiBicm9vbmllQGtlcm5lbC5vcmc7IGxvcmVuem8ucGllcmFsaXNpQGFybS5jb207IGppbmdv b2hhbjFAZ21haWwuY29tOwo+ID4gZmVzdGV2YW1AZ21haWwuY29tOyBmcmFuY2VzY28uZG9sY2lu aUB0b3JhZGV4LmNvbTsKPiA+IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsKPiA+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5v cmc7IGtlcm5lbEBwZW5ndXRyb25peC5kZTsgZGwtbGludXgtaW14Cj4gPiA8bGludXgtaW14QG54 cC5jb20+Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHY5IDUvOF0gUENJOiBpbXg2OiBSZWZpbmUg dGhlIHJlZ3VsYXRvciB1c2FnZQo+ID4gCj4gPiBPbiBGcmksIE1heSAwNiwgMjAyMiBhdCAwOTo0 NzowNkFNICswODAwLCBSaWNoYXJkIFpodSB3cm90ZToKPiA+ID4gVGhlIGRyaXZlciBzaG91bGQg dW5kbyBhbnkgZW5hYmxlcyBpdCBkaWQgaXRzZWxmLiBUaGUgcmVndWxhdG9yCj4gPiA+IGRpc2Fi bGUgc2hvdWxkbid0IGJlIGJhc2luZyBkZWNpc2lvbnMgb24gcmVndWxhdG9yX2lzX2VuYWJsZWQo KS4KClRoZSBkcml2ZXIgc2hvdWxkIGRpc2FibGUgdGhpbmdzIGlmIGFuIGVycm9yIG9jY3VycyBh ZnRlciBpdCBoYXMKZW5hYmxlZCBzb21ldGhpbmcsIG9yIGlmIGl0IGVuYWJsZWQgc29tZXRoaW5n IGR1cmluZyBwcm9iZSBhbmQgd2UncmUKbm93IGRldGFjaGluZyB0aGUgZHJpdmVyLiAgVGhhdCBk b2Vzbid0IGxvb2sgbGlrZSB0aGUgY2FzZSBoZXJlLgoKPiA+ID4gVG8ga2VlcCB0aGUgYmFsYW5j ZSBvZiB0aGUgcmVndWxhdG9yIHVzYWdlIGNvdW50ZXIsIGRpc2FibGUgdGhlCj4gPiA+IHJlZ3Vs YXRvciBqdXN0IGJlaGluZCBvZiBpbXg2X3BjaWVfYXNzZXJ0X2NvcmVfcmVzZXQoKSBpbiByZXN1 bWUgYW5kCj4gPiA+IHNodXRkb3duLgo+ID4gCj4gPiBJbiBzdWJqZWN0LCAiUmVmaW5lIiBkb2Vz bid0IHRlbGwgbWUgYW55dGhpbmcgYWJvdXQgd2hhdCdzIGhhcHBlbmluZyBoZXJlLgo+Cj4gVGhh bmtzIGZvciB5b3VyIGNvbW1lbnRzLgo+IEhvdyBhYm91dCB0aGUgZm9sbG93aW5nIG9uZT8KPiBQ Q0k6IGlteDY6IERvIHJlZ3VsYXRvciBkaXNhYmxlIHdpdGhvdXQgdGhlIHJlZ3VsYXRvcl9pc19l bmFibGVkIGNoZWNrCgpUaGF0J3MgdG9vIGxvdy1sZXZlbCwgbGlrZSBkZXNjcmliaW5nIHRoZSBD IGNvZGUgbGluZSBieSBsaW5lLgpJJ20gaG9waW5nIGZvciBzb21ldGhpbmcgYWJvdXQgdGhlIHB1 cnBvc2UgZm9yIHRoZSBwYXRjaCBzbwoiZ2l0IGxvZyAtLW9uZWxpbmUiIGNhbiB0ZWxsIGEgY29o ZXJlbnQgc3RvcnkuCgpBcHBhcmVudGx5IHRoaXMgaXMgYWJvdXQgZGlzYWJsaW5nIHRoZSBwb3dl ciByZWd1bGF0b3Igd2hlbiB0aGUgc2xvdAppc24ndCBiZWluZyB1c2VkLCBzbyBtYXliZSBpdCBj b3VsZCBzYXkgc29tZXRoaW5nIGFib3V0IHRoYXQuCgogICQgZ2l0IGdyZXAgLUVwICJyZWd1bGF0 b3JfKGVufGRpcylhYmxlIiBkcml2ZXJzL3BjaS9jb250cm9sbGVyLwoKc2hvd3MgdGhhdCBpbiBv dGhlciBkcml2ZXJzLCB0aGlzIGJlaW5nIGRvbmUgaW4KcHJvYmUvcmVtb3ZlL3N1c3BlbmQvcmVz dW1lLXR5cGUgcGF0aHMuICBpbXg2IHNob3VsZCBiZSBzaW1pbGFyLgoKQmpvcm4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK