From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B99F3C43334 for ; Fri, 10 Jun 2022 07:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243263AbiFJHgH (ORCPT ); Fri, 10 Jun 2022 03:36:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346684AbiFJHgC (ORCPT ); Fri, 10 Jun 2022 03:36:02 -0400 Received: from relay03.th.seeweb.it (relay03.th.seeweb.it [5.144.164.164]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F69812B03F; Fri, 10 Jun 2022 00:35:59 -0700 (PDT) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id DC1E31F714; Fri, 10 Jun 2022 09:35:54 +0200 (CEST) Date: Fri, 10 Jun 2022 09:35:47 +0200 From: Marijn Suijten To: Dmitry Baryshkov Cc: phone-devel@vger.kernel.org, Stephen Boyd , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Michael Turquette , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rajeev Nandan , Vladimir Lypak , Arnd Bergmann , Jonathan Marek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Bjorn Andersson Subject: Re: [PATCH v2 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls Message-ID: <20220610073547.meftbrcxk274kxhq@SoMainline.org> Mail-Followup-To: Marijn Suijten , Dmitry Baryshkov , phone-devel@vger.kernel.org, Stephen Boyd , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Michael Turquette , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rajeev Nandan , Vladimir Lypak , Arnd Bergmann , Jonathan Marek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Bjorn Andersson References: <20220601220747.1145095-1-marijn.suijten@somainline.org> <20220601220747.1145095-5-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2022-06-02 13:14:26, Dmitry Baryshkov wrote: > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > wrote: > > > > Patch 613cbd1da3c9 ("drm/msm/dsi: use devm_clk_*register to registe DSI > > PHY clocks") introduced the devm_ prefix to clk_hw registration calls, > > without updating the indentation of the arguments on the following > > lines. > > > > Similarly e55b3fbbbbc8 ("drm/msm/dsi: drop PLL accessor functions") > > moved from pll_write to dsi_phy_write without updating the indentation > > of followup arguments either. > > > > Preparing for a series that heavily touches the clk calls, reflow and > > reindent function calls that are adhering to an 80-char column limit by > > spanning multiple lines. Where function names are very long the > > arguments are indented with a fixed number of two tab characters instead > > of aligning with the opening parenthesis of the function call. > > > > I'm not a fan of reindenting the code, but let's do it. I don't like it either, but it's better than trying to figure out how to add and flow new arguments into the call-site while also leaving the indentation in the same broken state. At the same time it seems more consistent to fix up most faults rather than only touching clk calls. It's unfortunate that there's no proper autoformatter for C, that is consistently used across the kernel tree. Makes for a lot of mundane, error-prone, manual work. But alas. - Marijn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23B39C43334 for ; Fri, 10 Jun 2022 07:36:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27BC510E6D5; Fri, 10 Jun 2022 07:36:00 +0000 (UTC) Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [IPv6:2001:4b7a:2000:18::165]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12F9510E347; Fri, 10 Jun 2022 07:35:58 +0000 (UTC) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id DC1E31F714; Fri, 10 Jun 2022 09:35:54 +0200 (CEST) Date: Fri, 10 Jun 2022 09:35:47 +0200 From: Marijn Suijten To: Dmitry Baryshkov Subject: Re: [PATCH v2 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls Message-ID: <20220610073547.meftbrcxk274kxhq@SoMainline.org> Mail-Followup-To: Marijn Suijten , Dmitry Baryshkov , phone-devel@vger.kernel.org, Stephen Boyd , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Michael Turquette , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rajeev Nandan , Vladimir Lypak , Arnd Bergmann , Jonathan Marek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Stephen Boyd , Bjorn Andersson References: <20220601220747.1145095-1-marijn.suijten@somainline.org> <20220601220747.1145095-5-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Michael Turquette , Konrad Dybcio , dri-devel@lists.freedesktop.org, Bjorn Andersson , AngeloGioacchino Del Regno , phone-devel@vger.kernel.org, linux-clk@vger.kernel.org, Jonathan Marek , linux-arm-msm@vger.kernel.org, Arnd Bergmann , Rajeev Nandan , Abhinav Kumar , Stephen Boyd , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, Sean Paul , Stephen Boyd , Vladimir Lypak , linux-kernel@vger.kernel.org, Jami Kettunen , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2022-06-02 13:14:26, Dmitry Baryshkov wrote: > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > wrote: > > > > Patch 613cbd1da3c9 ("drm/msm/dsi: use devm_clk_*register to registe DSI > > PHY clocks") introduced the devm_ prefix to clk_hw registration calls, > > without updating the indentation of the arguments on the following > > lines. > > > > Similarly e55b3fbbbbc8 ("drm/msm/dsi: drop PLL accessor functions") > > moved from pll_write to dsi_phy_write without updating the indentation > > of followup arguments either. > > > > Preparing for a series that heavily touches the clk calls, reflow and > > reindent function calls that are adhering to an 80-char column limit by > > spanning multiple lines. Where function names are very long the > > arguments are indented with a fixed number of two tab characters instead > > of aligning with the opening parenthesis of the function call. > > > > I'm not a fan of reindenting the code, but let's do it. I don't like it either, but it's better than trying to figure out how to add and flow new arguments into the call-site while also leaving the indentation in the same broken state. At the same time it seems more consistent to fix up most faults rather than only touching clk calls. It's unfortunate that there's no proper autoformatter for C, that is consistently used across the kernel tree. Makes for a lot of mundane, error-prone, manual work. But alas. - Marijn