All of lore.kernel.org
 help / color / mirror / Atom feed
From: LinoSanfilippo@gmx.de
To: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca
Cc: stefanb@linux.vnet.ibm.com, linux@mniewoehner.de,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	l.sanfilippo@kunbus.com, LinoSanfilippo@gmx.de, lukas@wunner.de,
	p.rosenberger@kunbus.com
Subject: [PATCH v5 10/10] tpm, tpm_tis: Enable interrupt test
Date: Fri, 10 Jun 2022 13:08:46 +0200	[thread overview]
Message-ID: <20220610110846.8307-11-LinoSanfilippo@gmx.de> (raw)
In-Reply-To: <20220610110846.8307-1-LinoSanfilippo@gmx.de>

From: Lino Sanfilippo <l.sanfilippo@kunbus.com>

The test for interrupts in tpm_tis_send() is skipped if the flag
TPM_CHIP_FLAG_IRQ is not set. Since the current code never sets the flag
initially the test is never executed.

Fix this by setting the flag in tpm_tis_gen_interrupt() right after
interrupts have been enabled.

Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
---
 drivers/char/tpm/tpm_tis_core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index e5edf745fb23..be229c173f10 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -774,11 +774,16 @@ static int tpm_tis_gen_interrupt(struct tpm_chip *chip)
 	if (ret < 0)
 		return ret;
 
+	chip->flags |= TPM_CHIP_FLAG_IRQ;
+
 	if (chip->flags & TPM_CHIP_FLAG_TPM2)
 		ret = tpm2_get_tpm_pt(chip, 0x100, &cap2, desc);
 	else
 		ret = tpm1_getcap(chip, TPM_CAP_PROP_TIS_TIMEOUT, &cap, desc, 0);
 
+	if (ret)
+		chip->flags &= ~TPM_CHIP_FLAG_IRQ;
+
 	release_locality(chip, 0);
 
 	return ret;
-- 
2.36.1


  parent reply	other threads:[~2022-06-10 11:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 11:08 [PATCH v5 00/10] TPM IRQ fixes LinoSanfilippo
2022-06-10 11:08 ` [PATCH v5 01/10] tpm, tpm_tis: Avoid cache incoherency in test for interrupts LinoSanfilippo
2022-06-15 14:32   ` Jarkko Sakkinen
2022-06-15 22:06     ` Lino Sanfilippo
2022-06-10 11:08 ` [PATCH v5 02/10] tpm, tpm_tis: Claim locality before writing TPM_INT_ENABLE register LinoSanfilippo
2022-06-15 14:33   ` Jarkko Sakkinen
2022-06-10 11:08 ` [PATCH v5 03/10] tpm, tpm_tis: Disable interrupts if tpm_tis_probe_irq() failed LinoSanfilippo
2022-06-15 18:11   ` Jarkko Sakkinen
2022-06-10 11:08 ` [PATCH v5 04/10] tpm, tmp_tis: Claim locality before writing interrupt registers LinoSanfilippo
2022-06-15 18:13   ` Jarkko Sakkinen
2022-06-10 11:08 ` [PATCH v5 05/10] tpm, tpm_tis: Store result of interrupt capability query LinoSanfilippo
2022-06-15 18:18   ` Jarkko Sakkinen
2022-06-15 22:07     ` Lino Sanfilippo
2022-06-10 11:08 ` [PATCH v5 06/10] tpm, tpm_tis: Only handle supported interrupts in wait_for_tpm_stat() LinoSanfilippo
2022-06-15 18:21   ` Jarkko Sakkinen
2022-06-15 22:08     ` Lino Sanfilippo
2022-06-10 11:08 ` [PATCH v5 07/10] tmp, tmp_tis: Implement usage counter for locality LinoSanfilippo
2022-06-15 18:23   ` Jarkko Sakkinen
2022-06-15 22:22     ` Lino Sanfilippo
2022-06-10 11:08 ` [PATCH v5 08/10] tpm, tpm_tis: Request threaded interrupt handler LinoSanfilippo
2022-06-15 18:24   ` Jarkko Sakkinen
2022-06-10 11:08 ` [PATCH v5 09/10] tpm, tpm_tis: Claim locality in " LinoSanfilippo
2022-06-15 18:25   ` Jarkko Sakkinen
2022-06-10 11:08 ` LinoSanfilippo [this message]
2022-06-15 18:26   ` [PATCH v5 10/10] tpm, tpm_tis: Enable interrupt test Jarkko Sakkinen
2022-06-15 21:54     ` Michael Niewöhner
2022-06-15 23:30       ` Lino Sanfilippo
2022-06-16 13:03         ` Michael Niewöhner
2022-06-16 13:13           ` Lino Sanfilippo
2022-06-16 13:04     ` Michael Niewöhner
2022-06-26  5:19       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610110846.8307-11-LinoSanfilippo@gmx.de \
    --to=linosanfilippo@gmx.de \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@mniewoehner.de \
    --cc=lukas@wunner.de \
    --cc=p.rosenberger@kunbus.com \
    --cc=peterhuewe@gmx.de \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.