From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A2F6CCA47F for ; Fri, 10 Jun 2022 19:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348112AbiFJTBP (ORCPT ); Fri, 10 Jun 2022 15:01:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243528AbiFJTBO (ORCPT ); Fri, 10 Jun 2022 15:01:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DB312C36B9; Fri, 10 Jun 2022 12:01:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2D556222E; Fri, 10 Jun 2022 19:01:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1352DC34114; Fri, 10 Jun 2022 19:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654887672; bh=Hnvop1nQB2a1YvXC9KrSU6WdMwLevAsVoA6EE55HKf0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=j2V8JdBRB9od3csLhFaWyYbQv4LOFTb655urrswTus3Zufk/CEtBBoyna10Gf0yzw g2Q25Psjl8EgSp54TApA8f2BEC4zmE/5LyPX/9sWAd+T/8SbBiqlZnpRS8NJmLdfLJ YXccNmbOugAmc0N1Y4Y3Zqb3FiKyYm8NFPBK6NqoIj0m2eVqVFUeBXoiZHdMKm2T3t UlUApgeWIfxWnmUOGL1W8187VMKi/0/uYDgZMax5vUo8xdYFSmcp0F5suozphejrz8 WDs2WSLXWc27b2R5mOv8MNt7/VTjNxoQHJIWnHepHV54LX80fhopqJX0VAsjrJGjXj z8wubT/wkWYcA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220610074632.abtec5kulbclund4@SoMainline.org> References: <20220601220747.1145095-1-marijn.suijten@somainline.org> <20220601220747.1145095-4-marijn.suijten@somainline.org> <20220609221211.684C1C34114@smtp.kernel.org> <20220610074632.abtec5kulbclund4@SoMainline.org> Subject: Re: [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw() From: Stephen Boyd Cc: Dmitry Baryshkov , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Michael Turquette , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rajeev Nandan , Vladimir Lypak , Arnd Bergmann , Jonathan Marek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org To: Marijn Suijten Date: Fri, 10 Jun 2022 12:01:10 -0700 User-Agent: alot/0.10 Message-Id: <20220610190112.1352DC34114@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Marijn Suijten (2022-06-10 00:46:32) > On 2022-06-09 15:12:09, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > > wrote: > > > > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed= -factor.c > > > > index 54942d758ee6..fabb98d0cdb2 100644 > > > > --- a/drivers/clk/clk-fixed-factor.c > > > > +++ b/drivers/clk/clk-fixed-factor.c > > > > @@ -148,17 +151,50 @@ struct clk_hw *devm_clk_hw_register_fixed_fac= tor_index(struct device *dev, > > > > const char *name, unsigned int index, unsigned long= flags, > > > > unsigned int mult, unsigned int div) > > > > { > > > > - return __clk_hw_register_fixed_factor(dev, NULL, name, NULL= , index, > > > > - flags, mult, div, tru= e); > > > > + return __clk_hw_register_fixed_factor(dev, NULL, name, NULL= , NULL, > > > > + index, flags, mult, d= iv, true); > > >=20 > > > Here (and several times later) you are inserting an argument and then > > > moving arguments to the next line. My slight preference would be to > > > just insert the arg (and maybe break the line if it gets too long) w/o > > > touching the next lines. >=20 > That'll definitely look odd, as we'll end up with index floating on a > single line, all on its own. Pretty sure Dmitry is suggesting to make the line longer, not put the index on a line by itself. Ignore the 80-column limit. >=20 > > I'd just add the argument at the end because when it is added in the > > middle it makes the diff more difficult to read. >=20 > How strong is this feeling, against keeping argument ordering consistent > with other implementations of similar __clk_hw_register_* functions? >=20 Not super strong. Just try to minimize the diff to make the reviewer's job easier. In this case it would be inserting NULL before 'index' and not modifying the next line so the diff is one line instead of two. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22A9FC433EF for ; Fri, 10 Jun 2022 19:01:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43BAE10FAA8; Fri, 10 Jun 2022 19:01:14 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54BB710FA6C; Fri, 10 Jun 2022 19:01:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2D3B61EA7; Fri, 10 Jun 2022 19:01:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1352DC34114; Fri, 10 Jun 2022 19:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654887672; bh=Hnvop1nQB2a1YvXC9KrSU6WdMwLevAsVoA6EE55HKf0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=j2V8JdBRB9od3csLhFaWyYbQv4LOFTb655urrswTus3Zufk/CEtBBoyna10Gf0yzw g2Q25Psjl8EgSp54TApA8f2BEC4zmE/5LyPX/9sWAd+T/8SbBiqlZnpRS8NJmLdfLJ YXccNmbOugAmc0N1Y4Y3Zqb3FiKyYm8NFPBK6NqoIj0m2eVqVFUeBXoiZHdMKm2T3t UlUApgeWIfxWnmUOGL1W8187VMKi/0/uYDgZMax5vUo8xdYFSmcp0F5suozphejrz8 WDs2WSLXWc27b2R5mOv8MNt7/VTjNxoQHJIWnHepHV54LX80fhopqJX0VAsjrJGjXj z8wubT/wkWYcA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220610074632.abtec5kulbclund4@SoMainline.org> References: <20220601220747.1145095-1-marijn.suijten@somainline.org> <20220601220747.1145095-4-marijn.suijten@somainline.org> <20220609221211.684C1C34114@smtp.kernel.org> <20220610074632.abtec5kulbclund4@SoMainline.org> Subject: Re: [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw() From: Stephen Boyd To: Marijn Suijten Date: Fri, 10 Jun 2022 12:01:10 -0700 User-Agent: alot/0.10 Message-Id: <20220610190112.1352DC34114@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Michael Turquette , Konrad Dybcio , dri-devel@lists.freedesktop.org, AngeloGioacchino Del Regno , phone-devel@vger.kernel.org, linux-clk@vger.kernel.org, Jonathan Marek , linux-arm-msm@vger.kernel.org, Arnd Bergmann , Rajeev Nandan , Abhinav Kumar , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, Sean Paul , Jami Kettunen , Vladimir Lypak , linux-kernel@vger.kernel.org, Dmitry Baryshkov , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Marijn Suijten (2022-06-10 00:46:32) > On 2022-06-09 15:12:09, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > > wrote: > > > > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed= -factor.c > > > > index 54942d758ee6..fabb98d0cdb2 100644 > > > > --- a/drivers/clk/clk-fixed-factor.c > > > > +++ b/drivers/clk/clk-fixed-factor.c > > > > @@ -148,17 +151,50 @@ struct clk_hw *devm_clk_hw_register_fixed_fac= tor_index(struct device *dev, > > > > const char *name, unsigned int index, unsigned long= flags, > > > > unsigned int mult, unsigned int div) > > > > { > > > > - return __clk_hw_register_fixed_factor(dev, NULL, name, NULL= , index, > > > > - flags, mult, div, tru= e); > > > > + return __clk_hw_register_fixed_factor(dev, NULL, name, NULL= , NULL, > > > > + index, flags, mult, d= iv, true); > > >=20 > > > Here (and several times later) you are inserting an argument and then > > > moving arguments to the next line. My slight preference would be to > > > just insert the arg (and maybe break the line if it gets too long) w/o > > > touching the next lines. >=20 > That'll definitely look odd, as we'll end up with index floating on a > single line, all on its own. Pretty sure Dmitry is suggesting to make the line longer, not put the index on a line by itself. Ignore the 80-column limit. >=20 > > I'd just add the argument at the end because when it is added in the > > middle it makes the diff more difficult to read. >=20 > How strong is this feeling, against keeping argument ordering consistent > with other implementations of similar __clk_hw_register_* functions? >=20 Not super strong. Just try to minimize the diff to make the reviewer's job easier. In this case it would be inserting NULL before 'index' and not modifying the next line so the diff is one line instead of two.