From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97200C433EF for ; Mon, 13 Jun 2022 06:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbiFMGy7 (ORCPT ); Mon, 13 Jun 2022 02:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232446AbiFMGy6 (ORCPT ); Mon, 13 Jun 2022 02:54:58 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74D47140E2 for ; Sun, 12 Jun 2022 23:54:57 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0dyH-0000QP-4Z; Mon, 13 Jun 2022 08:54:45 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o0dyG-000FHU-7y; Mon, 13 Jun 2022 08:54:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o0dyE-00Fz7Y-95; Mon, 13 Jun 2022 08:54:42 +0200 Date: Mon, 13 Jun 2022 08:54:40 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Robert Foss Cc: Jagan Teki , Rob Herring , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Sam Ravnborg , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-amarula@amarulasolutions.com, Christopher Vollo Subject: Re: [PATCH v3 2/2] drm: bridge: Add TI DLPC3433 DSI to DMD bridge Message-ID: <20220613065440.2vjccaixikrayvhy@pengutronix.de> References: <20220603140349.3563612-1-jagan@amarulasolutions.com> <20220603140349.3563612-2-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7zzbapx7jiwfpevh" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --7zzbapx7jiwfpevh Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Fri, Jun 03, 2022 at 04:37:51PM +0200, Robert Foss wrote: > On Fri, 3 Jun 2022 at 16:04, Jagan Teki wrot= e: > > +static int dlpc3433_remove(struct i2c_client *client) > > +{ > > + struct dlpc *dlpc =3D i2c_get_clientdata(client); > > + > > + drm_bridge_remove(&dlpc->bridge); > > + of_node_put(dlpc->host_node); > > + > > + return 0; > > +} > > + [...] > > +static struct i2c_driver dlpc3433_driver =3D { > > + .probe_new =3D dlpc3433_probe, > > + .remove =3D dlpc3433_remove, > > + .id_table =3D dlpc3433_id, > > + .driver =3D { > > + .name =3D "ti-dlpc3433", > > + .of_match_table =3D dlpc3433_match_table, > > + }, > > +}; > > +module_i2c_driver(dlpc3433_driver); >=20 > Applied to drm-misc-next. just a quick note that there is an easy conflict between this patch and my effort to make i2c remove callbacks return void. I intend to post my series on top of v5.20-rc1, so if this patch goes in before, everything is fine. See https://lore.kernel.org/linux-i2c/20220609091018.q52fhowlsdbdkct5@pengutron= ix.de/ for some more details. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --7zzbapx7jiwfpevh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmKm3ywACgkQwfwUeK3K 7AnabAf/X/oSsZpM9JxCRjMVlq5KKzcTRkez4HeVTkYGWiG3O1fL+TjuvGTkYZ48 YpoSz2U6epz0bVRj/IuSZkmh5Pg/dXSSzYv+RhSSSGzF0XSihGkrItnVK5S9r+dl l4WibdSVE3he1EhMk0dbMRYbpo/mAajMsGsWlY1k9cCP21hZbFcCpI1OsbgTgw0U BVTXCQFpy2OqbIwug15754e3dbS1B0mmTcp9sNWiSY1ZZ7B/LcOtB6dePVkOXaba ySRB/h378863X0D869Mcj1H+e1jw8iiRAFP0mdYRpjUYkrK0Bh4kHAxfQGdd5Ez3 bEgmWpwZ40yrQyypYJcd1qh6SgMkpg== =Izfm -----END PGP SIGNATURE----- --7zzbapx7jiwfpevh-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4A52C43334 for ; Mon, 13 Jun 2022 06:54:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66EFC10E190; Mon, 13 Jun 2022 06:54:58 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C7E510E190 for ; Mon, 13 Jun 2022 06:54:57 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0dyH-0000QP-4Z; Mon, 13 Jun 2022 08:54:45 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o0dyG-000FHU-7y; Mon, 13 Jun 2022 08:54:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o0dyE-00Fz7Y-95; Mon, 13 Jun 2022 08:54:42 +0200 Date: Mon, 13 Jun 2022 08:54:40 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Robert Foss Subject: Re: [PATCH v3 2/2] drm: bridge: Add TI DLPC3433 DSI to DMD bridge Message-ID: <20220613065440.2vjccaixikrayvhy@pengutronix.de> References: <20220603140349.3563612-1-jagan@amarulasolutions.com> <20220603140349.3563612-2-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7zzbapx7jiwfpevh" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Christopher Vollo , Neil Armstrong , linux-amarula@amarulasolutions.com, dri-devel@lists.freedesktop.org, Rob Herring , Laurent Pinchart , Andrzej Hajda , Sam Ravnborg , Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --7zzbapx7jiwfpevh Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Fri, Jun 03, 2022 at 04:37:51PM +0200, Robert Foss wrote: > On Fri, 3 Jun 2022 at 16:04, Jagan Teki wrot= e: > > +static int dlpc3433_remove(struct i2c_client *client) > > +{ > > + struct dlpc *dlpc =3D i2c_get_clientdata(client); > > + > > + drm_bridge_remove(&dlpc->bridge); > > + of_node_put(dlpc->host_node); > > + > > + return 0; > > +} > > + [...] > > +static struct i2c_driver dlpc3433_driver =3D { > > + .probe_new =3D dlpc3433_probe, > > + .remove =3D dlpc3433_remove, > > + .id_table =3D dlpc3433_id, > > + .driver =3D { > > + .name =3D "ti-dlpc3433", > > + .of_match_table =3D dlpc3433_match_table, > > + }, > > +}; > > +module_i2c_driver(dlpc3433_driver); >=20 > Applied to drm-misc-next. just a quick note that there is an easy conflict between this patch and my effort to make i2c remove callbacks return void. I intend to post my series on top of v5.20-rc1, so if this patch goes in before, everything is fine. See https://lore.kernel.org/linux-i2c/20220609091018.q52fhowlsdbdkct5@pengutron= ix.de/ for some more details. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --7zzbapx7jiwfpevh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmKm3ywACgkQwfwUeK3K 7AnabAf/X/oSsZpM9JxCRjMVlq5KKzcTRkez4HeVTkYGWiG3O1fL+TjuvGTkYZ48 YpoSz2U6epz0bVRj/IuSZkmh5Pg/dXSSzYv+RhSSSGzF0XSihGkrItnVK5S9r+dl l4WibdSVE3he1EhMk0dbMRYbpo/mAajMsGsWlY1k9cCP21hZbFcCpI1OsbgTgw0U BVTXCQFpy2OqbIwug15754e3dbS1B0mmTcp9sNWiSY1ZZ7B/LcOtB6dePVkOXaba ySRB/h378863X0D869Mcj1H+e1jw8iiRAFP0mdYRpjUYkrK0Bh4kHAxfQGdd5Ez3 bEgmWpwZ40yrQyypYJcd1qh6SgMkpg== =Izfm -----END PGP SIGNATURE----- --7zzbapx7jiwfpevh--