From: <Gireesh.Hiremath@in.bosch.com>
To: <krzysztof.kozlowski+dt@linaro.org>
Cc: <m.felsch@pengutronix.de>, <linux-omap@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-input@vger.kernel.org>, <bcousson@baylibre.com>,
<tony@atomide.com>, <robh+dt@kernel.org>,
<dmitry.torokhov@gmail.com>, <mkorpershoek@baylibre.com>,
<davidgow@google.com>, <swboyd@chromium.org>,
<fengping.yu@mediatek.com>, <y.oudjana@protonmail.com>,
<rdunlap@infradead.org>, <colin.king@intel.com>,
<Gireesh.Hiremath@in.bosch.com>, <sjoerd.simons@collabora.co.uk>,
<VinayKumar.Shettar@in.bosch.com>,
<Govindaraji.Sivanantham@in.bosch.com>,
<anaclaudia.dias@de.bosch.com>
Subject: Re: [v2,2/4] Input: mt-matrix-keypad: Add Bosch mt matrix keypad driver
Date: Mon, 13 Jun 2022 08:06:38 +0000 [thread overview]
Message-ID: <20220613080638.1339-1-Gireesh.Hiremath@in.bosch.com> (raw)
In-Reply-To: <20220506072737.1590-2-Gireesh.Hiremath@in.bosch.com>
From: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>
Hi Krzysztof,
>You wrote pretty long message explaining how the device works, but I
>still do not see the answer to questions - why it cannot be part of
>matrix keypad?
Following are the difference between matrix keypad and Bosch keypad
make us to add another keypad driver.
matrix keypad:
- By hardware schematic, a column GPIO line will intersect only
with row GPIO lines, not with the other column GPIO lines
- so, row and column GPIO property are fixed, because of this
- key scanning work based on interrupt mode
- and key press is determined based on setting column as output,
row GPIO as input and set interrupt to monitor the changes in state,
serve the key pressed in ISR
Bosch keypad:
- By hardware schematic column GPIO line can intersect with row GPIO line
as well as other column GPIO lines
- so, all GPIO act as row as well as column, because of this
- key scanning based on polling mode
- a key pressed is determined by setting one of GPIO line as output and
other as input and poll for change in the state of input GPIO lines.
Setting one of a GPIO line as output and remaining GPIO lines as input is on
round robin bases.
>
>"It looks like this driver has smaller number of features than
>matrix-keypad, so it should be integrated into the matrix-keypad.
>matrix-keypad features are superset to this one."
>
>"But anyway this should be just merged into matrix-keypad. It's a
>simpler set of that binding."
This keypad driver specific to Bosch measuring tool or similar devices.
Please let me know to send latest patch which resolves build warning
and gpiod API support.
Best regards,
Gireesh Hiremath
next prev parent reply other threads:[~2022-06-13 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 7:27 [PATCH v2 1/4] ARM: dts: am335x: Guardian: switch to AM33XX_PADCONF pinmux macro Gireesh.Hiremath
2022-05-06 7:27 ` [PATCH v2 2/4] Input: mt-matrix-keypad: Add Bosch mt matrix keypad driver Gireesh.Hiremath
2022-05-07 15:46 ` Krzysztof Kozlowski
2022-05-10 14:13 ` Gireesh.Hiremath
2022-05-11 16:46 ` Krzysztof Kozlowski
2022-05-12 4:43 ` kernel test robot
2022-06-13 8:06 ` Gireesh.Hiremath [this message]
2022-06-15 8:28 ` [v2,2/4] " Marco Felsch
2022-06-15 20:58 ` Krzysztof Kozlowski
2022-08-19 6:56 ` Gireesh.Hiremath
2022-05-06 7:27 ` [PATCH v2 3/4] ARM: dts: am335x: Guardian: add keymap to mt matrix keypad Gireesh.Hiremath
2022-05-06 7:27 ` [PATCH v2 4/4] dt-bindings: input: mt-matrix-keypad: add guardian mt matrix keypad bindings definition Gireesh.Hiremath
2022-05-07 15:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613080638.1339-1-Gireesh.Hiremath@in.bosch.com \
--to=gireesh.hiremath@in.bosch.com \
--cc=Govindaraji.Sivanantham@in.bosch.com \
--cc=VinayKumar.Shettar@in.bosch.com \
--cc=anaclaudia.dias@de.bosch.com \
--cc=bcousson@baylibre.com \
--cc=colin.king@intel.com \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mkorpershoek@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=swboyd@chromium.org \
--cc=tony@atomide.com \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.