All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Lingshan <lingshan.zhu@intel.com>
To: jasowang@redhat.com, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, parav@nvidia.com,
	xieyongji@bytedance.com, gautam.dawar@amd.com,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH V2 3/6] vDPA: allow userspace to query features of a vDPA device
Date: Mon, 13 Jun 2022 18:16:49 +0800	[thread overview]
Message-ID: <20220613101652.195216-4-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220613101652.195216-1-lingshan.zhu@intel.com>

This commit adds a new vDPA netlink attribution
VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query
features of vDPA devices through this new attr.

Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
 drivers/vdpa/vdpa.c       | 13 +++++++++----
 include/uapi/linux/vdpa.h |  1 +
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index ebf2f363fbe7..9b0e39b2f022 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -815,7 +815,7 @@ static int vdpa_dev_net_mq_config_fill(struct vdpa_device *vdev,
 static int vdpa_dev_net_config_fill(struct vdpa_device *vdev, struct sk_buff *msg)
 {
 	struct virtio_net_config config = {};
-	u64 features;
+	u64 features_device, features_driver;
 	u16 val_u16;
 
 	vdpa_get_config_unlocked(vdev, 0, &config, sizeof(config));
@@ -832,12 +832,17 @@ static int vdpa_dev_net_config_fill(struct vdpa_device *vdev, struct sk_buff *ms
 	if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MTU, val_u16))
 		return -EMSGSIZE;
 
-	features = vdev->config->get_driver_features(vdev);
-	if (nla_put_u64_64bit(msg, VDPA_ATTR_DEV_NEGOTIATED_FEATURES, features,
+	features_driver = vdev->config->get_driver_features(vdev);
+	if (nla_put_u64_64bit(msg, VDPA_ATTR_DEV_NEGOTIATED_FEATURES, features_driver,
+			      VDPA_ATTR_PAD))
+		return -EMSGSIZE;
+
+	features_device = vdev->config->get_device_features(vdev);
+	if (nla_put_u64_64bit(msg, VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, features_device,
 			      VDPA_ATTR_PAD))
 		return -EMSGSIZE;
 
-	return vdpa_dev_net_mq_config_fill(vdev, msg, features, &config);
+	return vdpa_dev_net_mq_config_fill(vdev, msg, features_driver, &config);
 }
 
 static int
diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h
index 25c55cab3d7c..39f1c3d7c112 100644
--- a/include/uapi/linux/vdpa.h
+++ b/include/uapi/linux/vdpa.h
@@ -47,6 +47,7 @@ enum vdpa_attr {
 	VDPA_ATTR_DEV_NEGOTIATED_FEATURES,	/* u64 */
 	VDPA_ATTR_DEV_MGMTDEV_MAX_VQS,		/* u32 */
 	VDPA_ATTR_DEV_SUPPORTED_FEATURES,	/* u64 */
+	VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES,	/* u64 */
 
 	VDPA_ATTR_DEV_QUEUE_INDEX,              /* u32 */
 	VDPA_ATTR_DEV_VENDOR_ATTR_NAME,		/* string */
-- 
2.31.1


  parent reply	other threads:[~2022-06-13 10:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 10:16 [PATCH V2 0/6] ifcvf/vDPA: support query device config space through netlink Zhu Lingshan
2022-06-13 10:16 ` [PATCH V2 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation Zhu Lingshan
2022-06-13 10:16 ` [PATCH V2 2/6] vDPA/ifcvf: support userspace to query features and MQ of a management device Zhu Lingshan
2022-06-13 10:16 ` Zhu Lingshan [this message]
2022-06-13 20:37   ` [PATCH V2 3/6] vDPA: allow userspace to query features of a vDPA device Parav Pandit via Virtualization
2022-06-13 20:37     ` Parav Pandit
2022-06-13 20:42   ` Parav Pandit via Virtualization
2022-06-13 20:42     ` Parav Pandit
2022-06-14  2:53     ` Zhu, Lingshan
2022-06-14 18:38       ` Parav Pandit
2022-06-14 18:38         ` Parav Pandit via Virtualization
2022-06-15  6:54         ` Zhu, Lingshan
2022-06-13 10:16 ` [PATCH V2 4/6] vDPA: !FEATURES_OK should not block querying device config space Zhu Lingshan
2022-06-13 20:31   ` Parav Pandit via Virtualization
2022-06-13 20:31     ` Parav Pandit
2022-06-14  2:53     ` Zhu, Lingshan
2022-06-13 10:16 ` [PATCH V2 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0 Zhu Lingshan
2022-06-13 20:36   ` Parav Pandit via Virtualization
2022-06-13 20:36     ` Parav Pandit
2022-06-14  2:33     ` Zhu, Lingshan
2022-06-14 19:26       ` Parav Pandit
2022-06-14 19:26         ` Parav Pandit via Virtualization
2022-06-15  6:34         ` Zhu, Lingshan
2022-06-13 10:16 ` [PATCH V2 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa.c Zhu Lingshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613101652.195216-4-lingshan.zhu@intel.com \
    --to=lingshan.zhu@intel.com \
    --cc=gautam.dawar@amd.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.