All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com,
	mark.cave-ayland@ilande.co.uk
Subject: [PATCH 06/11] ppc/pnv: make pnv_ics_resend() use chip8->phbs[]
Date: Mon, 13 Jun 2022 12:44:51 -0300	[thread overview]
Message-ID: <20220613154456.359674-7-danielhb@linux.ibm.com> (raw)
In-Reply-To: <20220613154456.359674-1-danielhb@linux.ibm.com>

pnv_ics_resend() is scrolling through all the child objects of the chip
to search for the PHBs. It's faster and simpler to just use the phbs[]
array.

pnv_ics_resend_child() was folded into pnv_ics_resend() since it's too
simple to justify its own function.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.ibm.com>
---
 hw/ppc/pnv.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 05a8d5034f..d70deffa1d 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1993,28 +1993,20 @@ PnvChip *pnv_get_chip(PnvMachineState *pnv, uint32_t chip_id)
     return NULL;
 }
 
-static int pnv_ics_resend_child(Object *child, void *opaque)
-{
-    PnvPHB3 *phb3 = (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3);
-
-    if (phb3) {
-        ics_resend(&phb3->lsis);
-        ics_resend(ICS(&phb3->msis));
-    }
-    return 0;
-}
-
 static void pnv_ics_resend(XICSFabric *xi)
 {
     PnvMachineState *pnv = PNV_MACHINE(xi);
-    int i;
+    int i, j;
 
     for (i = 0; i < pnv->num_chips; i++) {
-        PnvChip *chip = pnv->chips[i];
         Pnv8Chip *chip8 = PNV8_CHIP(pnv->chips[i]);
 
-        ics_resend(&chip8->psi.ics);
-        object_child_foreach(OBJECT(chip), pnv_ics_resend_child, NULL);
+        for (j = 0; j < chip8->num_phbs; j++) {
+            PnvPHB3 *phb3 = &chip8->phbs[j];
+
+            ics_resend(&phb3->lsis);
+            ics_resend(ICS(&phb3->msis));
+        }
     }
 }
 
-- 
2.36.1



  parent reply	other threads:[~2022-06-13 15:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 15:44 [PATCH 00/11] pnv-phb related cleanups Daniel Henrique Barboza
2022-06-13 15:44 ` [PATCH 01/11] ppc/pnv: move root port attach to pnv_phb4_realize() Daniel Henrique Barboza
2022-06-14  9:08   ` Frederic Barrat
2022-06-14 12:02   ` Cédric Le Goater
2022-06-14 14:10     ` Daniel Henrique Barboza
2022-06-13 15:44 ` [PATCH 02/11] ppc/pnv: attach phb3/phb4 root ports in QOM tree Daniel Henrique Barboza
2022-06-14  9:09   ` Frederic Barrat
2022-06-14  9:53     ` Cédric Le Goater
2022-06-14 12:03   ` Cédric Le Goater
2022-06-13 15:44 ` [PATCH 03/11] ppc/pnv: use dev->parent_bus->parent to get the PHB Daniel Henrique Barboza
2022-06-14  9:10   ` Frederic Barrat
2022-06-17 20:02     ` Daniel Henrique Barboza
2022-06-14 12:10   ` Cédric Le Goater
2022-06-17 21:15     ` Daniel Henrique Barboza
2022-06-13 15:44 ` [PATCH 04/11] ppc/pnv: use dev instead of pci->qdev in root_port_realize() Daniel Henrique Barboza
2022-06-14  9:10   ` Frederic Barrat
2022-06-13 15:44 ` [PATCH 05/11] ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array Daniel Henrique Barboza
2022-06-14  9:13   ` Frederic Barrat
2022-06-14  9:52   ` Cédric Le Goater
2022-06-13 15:44 ` Daniel Henrique Barboza [this message]
2022-06-14  9:24   ` [PATCH 06/11] ppc/pnv: make pnv_ics_resend() use chip8->phbs[] Frederic Barrat
2022-06-14  9:54     ` Cédric Le Goater
2022-06-14 15:11     ` Daniel Henrique Barboza
2022-06-13 15:44 ` [PATCH 07/11] ppc/pnv: make pnv_chip_power8_pic_print_info() " Daniel Henrique Barboza
2022-06-14  9:36   ` Frederic Barrat
2022-06-13 15:44 ` [PATCH 08/11] ppc/pnv: turn chip8->phbs[] into a PnvPHB3* array Daniel Henrique Barboza
2022-06-14  9:53   ` Frederic Barrat
2022-06-14 15:39     ` Daniel Henrique Barboza
2022-06-14 15:52       ` Frederic Barrat
2022-06-14 16:11       ` Cédric Le Goater
2022-06-13 15:44 ` [PATCH 09/11] ppc/pnv: add PHB object/bus parenting helpers Daniel Henrique Barboza
2022-06-13 15:44 ` [PATCH 10/11] ppc/pnv: move PHB3 initialization to realize time Daniel Henrique Barboza
2022-06-14 10:14   ` Frederic Barrat
2022-06-13 15:44 ` [PATCH 11/11] ppc/pnv: move PHB4 parent fixup to phb4_realize() Daniel Henrique Barboza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613154456.359674-7-danielhb@linux.ibm.com \
    --to=danielhb@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=fbarrat@linux.ibm.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.