From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9224F1851 for ; Tue, 14 Jun 2022 08:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655196745; x=1686732745; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uH4ff7NiOtlPYhbofcE9VrwdjpymwMxUzxgV23W6Uv4=; b=D6IjoRT9r2MFSAIMaR6ZQKKtOrN9Su8xUNrK+uOr0v5vmcW+Yo13y7tq Za0glEVejEN4Vqu1dTr3RkJPRKTowFl7Z+ek3H/FPOz3KqGQF24P8/TJO oDY0P/z+DlWrv/ROiqc0HU/Qnf0JQP4c/wwozMvCFxla6/WZX/M6ym/6M fM97S9zrMRYLmxqRU0FQmMhlL3bfQF+UztjQRyY1OYENCxcKrr3qnVN4b ZgK5OBoC6jjI9tWfhrc7iXVfdDiTRKO8sqC3WbftealtyesFmVL3TRQgi GjpPVJM/y65SxZ0y71swi9xS8UfLKFZLK7mQeDYnf/mkun/CM5INjShOO Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="277336060" X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="277336060" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 01:52:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="617917192" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 14 Jun 2022 01:52:22 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o12Hd-000Lgc-N1; Tue, 14 Jun 2022 08:52:21 +0000 Date: Tue, 14 Jun 2022 16:51:24 +0800 From: kernel test robot To: Micah Morton , linux-security-module@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, keescook@chromium.org, jmorris@namei.org, serge@hallyn.com, linux-kernel@vger.kernel.org, Micah Morton Subject: Re: [PATCH 1/2] security: Add LSM hook to setgroups() syscall Message-ID: <202206141619.gvenMkdS-lkp@intel.com> References: <20220613202807.447694-1-mortonm@chromium.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220613202807.447694-1-mortonm@chromium.org> Hi Micah, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on jmorris-security/next-testing kees/for-next/pstore v5.19-rc2 next-20220614] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Micah-Morton/security-Add-LSM-hook-to-setgroups-syscall/20220614-050341 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 config: x86_64-randconfig-a002-20220613 (https://download.01.org/0day-ci/archive/20220614/202206141619.gvenMkdS-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c97436f8b6e2718286e8496faf53a2c800e281cf) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/b21cba6f759a2a60439de4d0f85323ed745b3ade git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Micah-Morton/security-Add-LSM-hook-to-setgroups-syscall/20220614-050341 git checkout b21cba6f759a2a60439de4d0f85323ed745b3ade # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> kernel/groups.c:143:6: error: assigning to 'struct cred *' from 'typeof (*(get_current()->cred)) *' (aka 'const struct cred *') discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] old = current_cred(); ^ ~~~~~~~~~~~~~~ >> kernel/groups.c:147:2: error: use of undeclared identifier 'retval' retval = security_task_fix_setgroups(new, old); ^ kernel/groups.c:148:6: error: use of undeclared identifier 'retval' if (retval < 0) ^ kernel/groups.c:155:9: error: use of undeclared identifier 'retval' return retval; ^ 4 errors generated. vim +143 kernel/groups.c 126 127 /** 128 * set_current_groups - Change current's group subscription 129 * @group_info: The group list to impose 130 * 131 * Validate a group subscription and, if valid, impose it upon current's task 132 * security record. 133 */ 134 int set_current_groups(struct group_info *group_info) 135 { 136 struct cred *new; 137 struct cred *old; 138 139 new = prepare_creds(); 140 if (!new) 141 return -ENOMEM; 142 > 143 old = current_cred(); 144 145 set_groups(new, group_info); 146 > 147 retval = security_task_fix_setgroups(new, old); 148 if (retval < 0) 149 goto error; 150 151 return commit_creds(new); 152 153 error: 154 abort_creds(new); 155 return retval; 156 } 157 -- 0-DAY CI Kernel Test Service https://01.org/lkp