From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E9A3C43334 for ; Tue, 14 Jun 2022 17:45:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 11DF984362; Tue, 14 Jun 2022 19:45:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="BAekQV7m"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BB13984376; Tue, 14 Jun 2022 19:45:05 +0200 (CEST) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 23FBD8431D for ; Tue, 14 Jun 2022 19:45:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rui.silva@linaro.org Received: by mail-wm1-x333.google.com with SMTP id m16-20020a7bca50000000b0039c8a224c95so4306076wml.2 for ; Tue, 14 Jun 2022 10:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LKrmKrwKWW+vEh5FGuaA2e+aWEzRcMJ2y5+S4HJZpt8=; b=BAekQV7mWxmQHqqWrXrzJE7Ro+dE5E4Ymoxs3haajRxZi6Q+2Vr1x3ciPRoaY9uBD/ 5Y5HDNv6QNt7OJcvPrafVXlR20tEiSupk980dZE3ulLoXYglu6/lXEnTDowHGcD6OXrW QgXjnEdn2GbvW3oTLvaj+P3ZiAh2NLgtNgx/jlNVe7jSASLPA6Es7tEHs1xola8bnL5I LYekVmxyp/NTXFQUn0Byopocm4Id+OwOSWC2+03bf31eolF2FKEeCF7uoZZtPeiEuO3Y cY0fN85jynB2SU+p2CqmP8L6Daex4BHgWwJnnCAQ91sgx4VvwJqToX2M+xa+mNFPE3bK qZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LKrmKrwKWW+vEh5FGuaA2e+aWEzRcMJ2y5+S4HJZpt8=; b=FqgnAlGHzAJyT/aBcyttR6QdjXgHFdG7yhN7kGHf5XPTwKflW/4u0euswmqgQ/hx6L Kt5WGYQ2wFO2If1Uz4uKejMKoQ1v9/cYyuuFV4N73Almin9WTRcXlPeWNDPQn4/6gkrz n9ahpwze+u2D6m3fkvS+BsOWCE+ASBQg6Ip9ZK+FKDc8jywGOsQOIrNXUKA7GmJfKsDE I9vpo+rBa5Rc/z9mRXCHQ5z35m9kHaYDSNQG04sCZhEeF0F8jOd4mPu0aRt/YV3KEDui +5rWlk84Ako8uVn98cE6wQKZNZD7wmQ1Cw3UIiyrMmuJwAa3iIcsgVzyhMagnUx21P/K ErWw== X-Gm-Message-State: AOAM530DGxswI1f4GETL1V0jLYJ6GcrOZ9T1dqY+dcqVEhENWdtfSxru GTW0ETiuhr/zuVPYnn+KdvSLiwnpPcf0+BZq X-Google-Smtp-Source: ABdhPJw0OEM7BH4qeloy/oJQRVYLtDvLyEA31jx1noz1ojXQntfE6omiLti9ipLsJL57thJl9WRyuQ== X-Received: by 2002:a1c:25c4:0:b0:39c:9a08:452f with SMTP id l187-20020a1c25c4000000b0039c9a08452fmr5275726wml.199.1655228700284; Tue, 14 Jun 2022 10:45:00 -0700 (PDT) Received: from arch-thunder (a109-49-33-111.cpe.netcabo.pt. [109.49.33.111]) by smtp.gmail.com with ESMTPSA id a24-20020a1cf018000000b0039c64d0c4e8sm13550507wmb.45.2022.06.14.10.44.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:44:59 -0700 (PDT) Date: Tue, 14 Jun 2022 18:44:58 +0100 From: Rui Miguel Silva To: u-boot@lists.denx.de Subject: Re: [PATCH v3 0/3] usb: add isp1760 hcd support Message-ID: <20220614174458.axnj6jqaozn26uug@arch-thunder> References: <20220525132251.240868-1-rui.silva@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220525132251.240868-1-rui.silva@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi *, On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva wrote: > Add support for the usb isp1760 host controller family, which > for example is present in MPS3 FPGA board from Arm (isp1763). > > First we move some helper functions and defines to a more > common place to be shared by several urb users. (patch 1/3) > > Then add the driver itself, is a ported version of the kernel > actual driver, which I am also the maintainer. (patch 2/3) > > And last, enable it for the corstone1000 platform that uses > that MPS3 board for its implementation (patch 3/3). > Any chance this series get some feedback? Thanks in advance, Cheers, Rui > > Cheers, > Rui > > v2[3] -> v3: > - when you think you have amend commit and fix stay > uncommitted. > s/[HC_FIELD_MAX] = {};/[HC_FIELD_MAX] = {},/ > v1[0] -> v2: > - gentle ping > - merge fix from kernel upstream [1] > > PS: This should go on top of the corstone1000 platform enable > series [2] > > 0: https://lore.kernel.org/u-boot/20220512142016.2025129-1-rui.silva@linaro.org/ > 1: https://lore.kernel.org/linux-usb/20220516091424.391209-1-linus.walleij@linaro.org/ > 2: https://lore.kernel.org/u-boot/20220511095541.1461937-1-rui.silva@linaro.org/T/#t > 3: https://lore.kernel.org/u-boot/20220523090119.1212016-1-rui.silva@linaro.org/ > > Rui Miguel Silva (3): > usb: common: move urb code to common > usb: add isp1760 family driver > corstone1000: enable isp1763 usb controller and mmc > > Makefile | 1 + > configs/corstone1000_defconfig | 3 + > drivers/usb/Kconfig | 2 + > drivers/usb/common/Makefile | 3 + > drivers/usb/common/usb_urb.c | 160 ++ > drivers/usb/host/r8a66597-hcd.c | 30 +- > drivers/usb/isp1760/Kconfig | 12 + > drivers/usb/isp1760/Makefile | 6 + > drivers/usb/isp1760/isp1760-core.c | 380 +++ > drivers/usb/isp1760/isp1760-core.h | 96 + > drivers/usb/isp1760/isp1760-hcd.c | 2477 +++++++++++++++++ > drivers/usb/isp1760/isp1760-hcd.h | 81 + > drivers/usb/isp1760/isp1760-if.c | 125 + > drivers/usb/isp1760/isp1760-regs.h | 292 ++ > drivers/usb/isp1760/isp1760-uboot.c | 75 + > drivers/usb/isp1760/isp1760-uboot.h | 27 + > drivers/usb/musb-new/musb_core.c | 2 +- > drivers/usb/musb-new/musb_host.c | 2 +- > drivers/usb/musb-new/musb_host.h | 2 +- > drivers/usb/musb-new/musb_uboot.c | 38 +- > drivers/usb/musb-new/musb_uboot.h | 2 +- > include/configs/corstone1000.h | 6 + > .../linux/usb/usb_urb_compat.h | 47 +- > include/usb_defs.h | 32 + > 24 files changed, 3825 insertions(+), 76 deletions(-) > create mode 100644 drivers/usb/common/usb_urb.c > create mode 100644 drivers/usb/isp1760/Kconfig > create mode 100644 drivers/usb/isp1760/Makefile > create mode 100644 drivers/usb/isp1760/isp1760-core.c > create mode 100644 drivers/usb/isp1760/isp1760-core.h > create mode 100644 drivers/usb/isp1760/isp1760-hcd.c > create mode 100644 drivers/usb/isp1760/isp1760-hcd.h > create mode 100644 drivers/usb/isp1760/isp1760-if.c > create mode 100644 drivers/usb/isp1760/isp1760-regs.h > create mode 100644 drivers/usb/isp1760/isp1760-uboot.c > create mode 100644 drivers/usb/isp1760/isp1760-uboot.h > rename drivers/usb/musb-new/usb-compat.h => include/linux/usb/usb_urb_compat.h (59%) > > -- > 2.36.1 >