From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 015AEC433EF for ; Wed, 15 Jun 2022 05:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242197AbiFOFnM (ORCPT ); Wed, 15 Jun 2022 01:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345820AbiFOFnK (ORCPT ); Wed, 15 Jun 2022 01:43:10 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51BE527CE0 for ; Tue, 14 Jun 2022 22:43:08 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Lo1-0002xc-BZ; Wed, 15 Jun 2022 07:43:05 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o1Lnx-000cl8-Bh; Wed, 15 Jun 2022 07:43:02 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o1Lnx-00GO9I-Rg; Wed, 15 Jun 2022 07:43:01 +0200 Date: Wed, 15 Jun 2022 07:43:01 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: linux-gpio@vger.kernel.org, Marek Vasut , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Mark Brown , Robin Murphy Subject: Re: [PATCH] gpio: ucb1400: Remove platform setup and teardown support Message-ID: <20220615054301.cnb6fdwciuzt3l67@pengutronix.de> References: <20220614194802.269738-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="asyd52ppd76oscsq" Content-Disposition: inline In-Reply-To: <20220614194802.269738-1-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-gpio@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --asyd52ppd76oscsq Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, [Cc +=3D pxa maintainers and a few people I talked to about this driver in irc yesterday] On Tue, Jun 14, 2022 at 09:48:02PM +0200, Uwe Kleine-K=F6nig wrote: > There is no user of these callbacks. The motivation for this change is > to stop returning an error code from the remove callback. >=20 > This is a preparation for making platform remove callbacks return void. >=20 > Signed-off-by: Uwe Kleine-K=F6nig A side note to this driver: In the probe routine there is a check at the start: struct ucb1400_gpio *ucb =3D dev_get_platdata(&dev->dev); if (!(ucb && ucb->gpio_offset)) { err =3D -EINVAL; goto err; } So the driver doesn't bind unless there is platdata and it has gpio_offset !=3D 0. (The decade before last called and wants its fixed gpio numbers back :-) platdata is assembled in drivers/mfd/ucb1400_core.c:ucb1400_core_probe() using: struct ucb1400_pdata *pdata =3D dev_get_platdata(dev); ... if (pdata) ucb_gpio.gpio_offset =3D pdata->gpio_offset; All machines using this ucb1400 mfd (i.e. arch/arm/mach-pxa/balloon3.c, arch/arm/mach-pxa/colibri-pxa270.c, arch/arm/mach-pxa/vpac270.c) all don't set the .gpio_offset member in their ucb1400_pdata. So the gpio driver is effectively unused and alternatively could just be removed entirely. Also there seems to be some pending spring cleanup, so the pxa boards might just be removed soon, which looks like a good opportunity to drop the driver, too. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --asyd52ppd76oscsq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmKpcWIACgkQwfwUeK3K 7Ak7Bgf/VMMHo1bjXsw8AH0KsnCHmXkyjXiIUe6L1fS/kq6TkrJ/n79Xisqd0Bpj pqzH0165G6uJTF5kRWLZrqtb2LSmseXIGDC+thPeYX3l8jeTGBcmNu77IxmFBnCE tVrb+eKTiuSGR5Sxl4M/c2EfzDfgvlQ7s98rYhOrg6A9nvk1++KHuBewtZUk0rdk v6wFv3p5O2++Bj9W5YxV7WaEHKSUdWHF5QxeMO7YoJjMUdmVcgiue4gYpvsqObj7 7SHrEQhHs0rHmPdnTR8rbJJ8hSRRpwMCm4uzxrVRJ1JjqHATuliN1aCoIlO0VD+F A++rbxcPPIMIqjcoMb2ONXyEY4C05A== =5q0o -----END PGP SIGNATURE----- --asyd52ppd76oscsq-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B447C43334 for ; Wed, 15 Jun 2022 05:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ubi9szRdwZwsQS6X4NHrCZVXaBBgx1CLbqOb5S3cNBk=; b=tIFovC4SVncxfDzHySFjWx+GzH Fyxg+ONU3TT8SkB8vJGha6jdHF0gNinF4cEXrowRZbSHKzulkZUCcDlbX85MGwoK6tm+MnPuMR4+Q mRLLtaScNMu/s5cYe9aT16HkVSXEtrIs9todFyXEQSr2CFL5wrKod4uK4nGKIxwkeGY96nAY/GisB a1ZNO4/bAm9B0hBhM94/tZqoSdv63nULWmcp8/RRxLOkr+d//ln9ngpWsluz6LLDNlXPFIF2ES32L kvYl7Kc0jeYPTDs7+zWJEpeBFLDOYpOqYhVbRYM6byIKOJnVlCNuji5M/nv6qcxL6Io0SYcQpbZRz XFyHoZbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1LoD-00Cgyu-JV; Wed, 15 Jun 2022 05:43:17 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1LoA-00Cgu8-BN for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 05:43:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Lo1-0002xc-BZ; Wed, 15 Jun 2022 07:43:05 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o1Lnx-000cl8-Bh; Wed, 15 Jun 2022 07:43:02 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o1Lnx-00GO9I-Rg; Wed, 15 Jun 2022 07:43:01 +0200 Date: Wed, 15 Jun 2022 07:43:01 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: linux-gpio@vger.kernel.org, Marek Vasut , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Mark Brown , Robin Murphy Subject: Re: [PATCH] gpio: ucb1400: Remove platform setup and teardown support Message-ID: <20220615054301.cnb6fdwciuzt3l67@pengutronix.de> References: <20220614194802.269738-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20220614194802.269738-1-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_224314_426902_9AE6367C X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4068316746383822140==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4068316746383822140== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="asyd52ppd76oscsq" Content-Disposition: inline --asyd52ppd76oscsq Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, [Cc +=3D pxa maintainers and a few people I talked to about this driver in irc yesterday] On Tue, Jun 14, 2022 at 09:48:02PM +0200, Uwe Kleine-K=F6nig wrote: > There is no user of these callbacks. The motivation for this change is > to stop returning an error code from the remove callback. >=20 > This is a preparation for making platform remove callbacks return void. >=20 > Signed-off-by: Uwe Kleine-K=F6nig A side note to this driver: In the probe routine there is a check at the start: struct ucb1400_gpio *ucb =3D dev_get_platdata(&dev->dev); if (!(ucb && ucb->gpio_offset)) { err =3D -EINVAL; goto err; } So the driver doesn't bind unless there is platdata and it has gpio_offset !=3D 0. (The decade before last called and wants its fixed gpio numbers back :-) platdata is assembled in drivers/mfd/ucb1400_core.c:ucb1400_core_probe() using: struct ucb1400_pdata *pdata =3D dev_get_platdata(dev); ... if (pdata) ucb_gpio.gpio_offset =3D pdata->gpio_offset; All machines using this ucb1400 mfd (i.e. arch/arm/mach-pxa/balloon3.c, arch/arm/mach-pxa/colibri-pxa270.c, arch/arm/mach-pxa/vpac270.c) all don't set the .gpio_offset member in their ucb1400_pdata. So the gpio driver is effectively unused and alternatively could just be removed entirely. Also there seems to be some pending spring cleanup, so the pxa boards might just be removed soon, which looks like a good opportunity to drop the driver, too. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --asyd52ppd76oscsq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmKpcWIACgkQwfwUeK3K 7Ak7Bgf/VMMHo1bjXsw8AH0KsnCHmXkyjXiIUe6L1fS/kq6TkrJ/n79Xisqd0Bpj pqzH0165G6uJTF5kRWLZrqtb2LSmseXIGDC+thPeYX3l8jeTGBcmNu77IxmFBnCE tVrb+eKTiuSGR5Sxl4M/c2EfzDfgvlQ7s98rYhOrg6A9nvk1++KHuBewtZUk0rdk v6wFv3p5O2++Bj9W5YxV7WaEHKSUdWHF5QxeMO7YoJjMUdmVcgiue4gYpvsqObj7 7SHrEQhHs0rHmPdnTR8rbJJ8hSRRpwMCm4uzxrVRJ1JjqHATuliN1aCoIlO0VD+F A++rbxcPPIMIqjcoMb2ONXyEY4C05A== =5q0o -----END PGP SIGNATURE----- --asyd52ppd76oscsq-- --===============4068316746383822140== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4068316746383822140==--