From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DF4C43334 for ; Wed, 15 Jun 2022 06:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353225AbiFOG34 (ORCPT ); Wed, 15 Jun 2022 02:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236311AbiFOG34 (ORCPT ); Wed, 15 Jun 2022 02:29:56 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99CFF3A5E9; Tue, 14 Jun 2022 23:29:55 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id F0D3D67373; Wed, 15 Jun 2022 08:29:52 +0200 (CEST) Date: Wed, 15 Jun 2022 08:29:52 +0200 From: Christoph Hellwig To: "Tian, Kevin" Cc: Christoph Hellwig , Kirti Wankhede , Tony Krowiak , Halil Pasic , Jason Herne , Eric Farman , Matthew Rosato , Zhenyu Wang , "Wang, Zhi A" , Alex Williamson , "linux-s390@vger.kernel.org" , "intel-gvt-dev@lists.freedesktop.org" , Jason Gunthorpe , "kvm@vger.kernel.org" Subject: Re: [PATCH 13/13] vfio/mdev: add mdev available instance checking to the core Message-ID: <20220615062952.GC22728@lst.de> References: <20220614045428.278494-1-hch@lst.de> <20220614045428.278494-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Tue, Jun 14, 2022 at 10:32:11AM +0000, Tian, Kevin wrote: > > Signed-off-by: Jason Gunthorpe > > [count instances per-parent instead of per-type] > > per-parent counting works only if the parent doesn't have overlapping > instances between types. This is probably worth a clarification in doc. Yes. Two cases right now just have a single type, and the third wants this per-parent counting. The original patch from Jason actually got this wrong.