From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B50C433EF for ; Wed, 15 Jun 2022 12:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347893AbiFOMSu (ORCPT ); Wed, 15 Jun 2022 08:18:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237953AbiFOMSr (ORCPT ); Wed, 15 Jun 2022 08:18:47 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56ED22F03D; Wed, 15 Jun 2022 05:18:46 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 090C01F74D; Wed, 15 Jun 2022 12:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655295525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UroC0bQeOgm/lmndX3Yv0QRy5Q23FpQDQZM2YeUr9VI=; b=EbkKBQZ5HOGjbcOnX3Esop2r9vFBrrGNPjUtWs8Jk2hwBzGQeEaAUB+849N8eD3tUNpOG2 EheFCPhZba7k2eFFoOfGys3gylB5u6F95qhE64gO4kH9HdmIaMeYACRTtTC8OwXPXmMKAB e+uYiMkF6OcTGrJ5HH0BqRt+MMw/r5U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655295525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UroC0bQeOgm/lmndX3Yv0QRy5Q23FpQDQZM2YeUr9VI=; b=yfL0snb4mMdN3JdZUgxzcQVUCu3oC7bM2bdXAt3+MyHvK7IqJLsA6Ob/8L3o2tkpyEDNn/ /IqWY8CNt8m2TgDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D6FAB139F3; Wed, 15 Jun 2022 12:18:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Nq93NCTOqWIzCAAAMHmgww (envelope-from ); Wed, 15 Jun 2022 12:18:44 +0000 Date: Wed, 15 Jun 2022 15:18:44 +0300 From: "Ivan T. Ivanov" To: madvenka@linux.microsoft.com Cc: jpoimboe@redhat.com, peterz@infradead.org, chenzhongjin@huawei.com, mark.rutland@arm.com, broonie@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 00/20] arm64: livepatch: Use ORC for dynamic frame pointer validation Message-ID: <20220615121844.34v7cos5kcz2hufk@suse> References: <20220524001637.1707472-1-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524001637.1707472-1-madvenka@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Madhavan, And thank you for your work on this! > My github repo for this version is here: > > https://github.com/madvenka786/linux/tree/orc_v2 > > Please feel free to clone and check it out. And, please let me know if you > find any issues. > > > TBD > === > > - I need to perform more rigorous testing with different scenarios. This > is work in progress. Any ideas or suggestions are welcome. > I have run following [1] livepatch tests on kernel build from your repository. Overall results looks good, but when I run klp_tc_13.shI there is something which I still can not understand completely. It is because of kaslr. [ 36.817617] livepatch: enabling patch 'klp_tc_13_livepatch' [ 36.819602] branch_imm_common: offset out of range [ 36.820113] branch_imm_common: offset out of range [ 36.820643] ------------[ ftrace bug ]------------ [ 36.821172] ftrace failed to modify [ 36.821173] [] orig_do_read_active_livepatch_id+0x4/0xa8 [klp_test_support_mod] [ 36.822465] actual: e4:01:00:94 [ 36.822821] Updating ftrace call site to call a different ftrace function [ 36.823537] ftrace record flags: e4000002 [ 36.823953] (2) R [ 36.823953] expected tramp: ffffdde96882e224 [ 36.824619] ------------[ cut here ]------------ [ 36.825125] WARNING: CPU: 0 PID: 950 at kernel/trace/ftrace.c:2085 ftrace_bug+0x98/0x280 [ 36.826027] Modules linked in: klp_tc_13_livepatch(OK+) klp_test_support_mod(O) crct10dif_ce [ 36.826943] CPU: 0 PID: 950 Comm: insmod Tainted: G O K 5.18.0-rc1-00020-g1ffee6fdcfda #39 [ 36.827987] Hardware name: linux,dummy-virt (DT) [ 36.828546] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 36.829348] pc : ftrace_bug+0x98/0x280 [ 36.829790] lr : ftrace_bug+0x228/0x280 [ 36.830224] sp : ffff8000084038e0 [ 36.830620] x29: ffff8000084038e0 x28: ffff00000485a920 x27: ffffdde931176804 [ 36.831419] x26: ffffdde93117d1a0 x25: ffff00000485a900 x24: ffffdde96aea1000 [ 36.832226] x23: 0000000000000000 x22: 0000000000000001 x21: ffffdde96a124da0 [ 36.833024] x20: ffff0000045620f0 x19: ffffdde96b54a358 x18: ffffffffffffffff [ 36.833818] x17: 5b20386178302f34 x16: 78302b64695f6863 x15: ffffdde96a3078f8 [ 36.834621] x14: 0000000000000000 x13: 3432326532383836 x12: ffffdde96ae9b3d8 [ 36.835425] x11: 0000000000000001 x10: 0000000000000001 x9 : ffffdde96891305c [ 36.836221] x8 : c0000000ffffefff x7 : 0000000000017fe8 x6 : ffffdde96ae83398 [ 36.837023] x5 : 0000000000057fa8 x4 : 0000000000000000 x3 : 00000000ffffefff [ 36.837836] x2 : e32439832ffb9700 x1 : 0000000000000000 x0 : 0000000000000022 [ 36.838635] Call trace: [ 36.838923] ftrace_bug+0x98/0x280 [ 36.839319] ftrace_replace_code+0xa0/0xb8 [ 36.839768] ftrace_modify_all_code+0xc0/0x160 [ 36.840273] arch_ftrace_update_code+0x14/0x20 [ 36.840780] ftrace_run_update_code+0x24/0x78 [ 36.841283] ftrace_startup_enable+0x50/0x60 [ 36.841781] ftrace_startup+0xb4/0x178 [ 36.842214] register_ftrace_function+0x68/0x88 [ 36.842738] klp_patch_object+0x1c8/0x330 [ 36.843196] klp_enable_patch+0x468/0x828 Regards, Ivan [1] https://github.com/lpechacek/qa_test_klp For this to work on aarch64 you will need fixes from PR#13 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43912C43334 for ; Wed, 15 Jun 2022 12:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B0ZMT3VUTFOhwz2FbFGa1uP3eoDOEaN2FZmDP9wX+CE=; b=OvMX17FB0lrrpW 3/QGYMZdj/KutdMBe3+AKoeGMsOI1qlbA3CGdfqzjs8HgVF1+5UmUkCrSkWx1lUdIOs0/KxQVmiaS FOGYaaOjeGMR/I+d3nrFyUIG8mv/dT+OXmc8nrVsn5XLH+kyieFsTb5GKzwuICQodt5Y1W62syKwD YbHQqTobzWlcwF2x64l9QMZjPpOu+Xjmb7u8R89OfGzWOm+UxBiNJ6k2r/TSyEcoX8xHJCncao84o xaP1cpZc0xp2Zujc8evEvCrzg/NVc+E2SKX+mZDIIu8sUbsXm0R+/LL79OurCU8npHrMCvLdQVsop wI9YtmPHlDPkzZLiWR/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Rz2-00EQna-2b; Wed, 15 Jun 2022 12:18:52 +0000 Received: from smtp-out2.suse.de ([195.135.220.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1Ryy-00EQlp-Qj for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 12:18:50 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 090C01F74D; Wed, 15 Jun 2022 12:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655295525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UroC0bQeOgm/lmndX3Yv0QRy5Q23FpQDQZM2YeUr9VI=; b=EbkKBQZ5HOGjbcOnX3Esop2r9vFBrrGNPjUtWs8Jk2hwBzGQeEaAUB+849N8eD3tUNpOG2 EheFCPhZba7k2eFFoOfGys3gylB5u6F95qhE64gO4kH9HdmIaMeYACRTtTC8OwXPXmMKAB e+uYiMkF6OcTGrJ5HH0BqRt+MMw/r5U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655295525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UroC0bQeOgm/lmndX3Yv0QRy5Q23FpQDQZM2YeUr9VI=; b=yfL0snb4mMdN3JdZUgxzcQVUCu3oC7bM2bdXAt3+MyHvK7IqJLsA6Ob/8L3o2tkpyEDNn/ /IqWY8CNt8m2TgDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D6FAB139F3; Wed, 15 Jun 2022 12:18:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Nq93NCTOqWIzCAAAMHmgww (envelope-from ); Wed, 15 Jun 2022 12:18:44 +0000 Date: Wed, 15 Jun 2022 15:18:44 +0300 From: "Ivan T. Ivanov" To: madvenka@linux.microsoft.com Cc: jpoimboe@redhat.com, peterz@infradead.org, chenzhongjin@huawei.com, mark.rutland@arm.com, broonie@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 00/20] arm64: livepatch: Use ORC for dynamic frame pointer validation Message-ID: <20220615121844.34v7cos5kcz2hufk@suse> References: <20220524001637.1707472-1-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220524001637.1707472-1-madvenka@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_051849_075760_7F8EFF48 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Madhavan, And thank you for your work on this! > My github repo for this version is here: > > https://github.com/madvenka786/linux/tree/orc_v2 > > Please feel free to clone and check it out. And, please let me know if you > find any issues. > > > TBD > === > > - I need to perform more rigorous testing with different scenarios. This > is work in progress. Any ideas or suggestions are welcome. > I have run following [1] livepatch tests on kernel build from your repository. Overall results looks good, but when I run klp_tc_13.shI there is something which I still can not understand completely. It is because of kaslr. [ 36.817617] livepatch: enabling patch 'klp_tc_13_livepatch' [ 36.819602] branch_imm_common: offset out of range [ 36.820113] branch_imm_common: offset out of range [ 36.820643] ------------[ ftrace bug ]------------ [ 36.821172] ftrace failed to modify [ 36.821173] [] orig_do_read_active_livepatch_id+0x4/0xa8 [klp_test_support_mod] [ 36.822465] actual: e4:01:00:94 [ 36.822821] Updating ftrace call site to call a different ftrace function [ 36.823537] ftrace record flags: e4000002 [ 36.823953] (2) R [ 36.823953] expected tramp: ffffdde96882e224 [ 36.824619] ------------[ cut here ]------------ [ 36.825125] WARNING: CPU: 0 PID: 950 at kernel/trace/ftrace.c:2085 ftrace_bug+0x98/0x280 [ 36.826027] Modules linked in: klp_tc_13_livepatch(OK+) klp_test_support_mod(O) crct10dif_ce [ 36.826943] CPU: 0 PID: 950 Comm: insmod Tainted: G O K 5.18.0-rc1-00020-g1ffee6fdcfda #39 [ 36.827987] Hardware name: linux,dummy-virt (DT) [ 36.828546] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 36.829348] pc : ftrace_bug+0x98/0x280 [ 36.829790] lr : ftrace_bug+0x228/0x280 [ 36.830224] sp : ffff8000084038e0 [ 36.830620] x29: ffff8000084038e0 x28: ffff00000485a920 x27: ffffdde931176804 [ 36.831419] x26: ffffdde93117d1a0 x25: ffff00000485a900 x24: ffffdde96aea1000 [ 36.832226] x23: 0000000000000000 x22: 0000000000000001 x21: ffffdde96a124da0 [ 36.833024] x20: ffff0000045620f0 x19: ffffdde96b54a358 x18: ffffffffffffffff [ 36.833818] x17: 5b20386178302f34 x16: 78302b64695f6863 x15: ffffdde96a3078f8 [ 36.834621] x14: 0000000000000000 x13: 3432326532383836 x12: ffffdde96ae9b3d8 [ 36.835425] x11: 0000000000000001 x10: 0000000000000001 x9 : ffffdde96891305c [ 36.836221] x8 : c0000000ffffefff x7 : 0000000000017fe8 x6 : ffffdde96ae83398 [ 36.837023] x5 : 0000000000057fa8 x4 : 0000000000000000 x3 : 00000000ffffefff [ 36.837836] x2 : e32439832ffb9700 x1 : 0000000000000000 x0 : 0000000000000022 [ 36.838635] Call trace: [ 36.838923] ftrace_bug+0x98/0x280 [ 36.839319] ftrace_replace_code+0xa0/0xb8 [ 36.839768] ftrace_modify_all_code+0xc0/0x160 [ 36.840273] arch_ftrace_update_code+0x14/0x20 [ 36.840780] ftrace_run_update_code+0x24/0x78 [ 36.841283] ftrace_startup_enable+0x50/0x60 [ 36.841781] ftrace_startup+0xb4/0x178 [ 36.842214] register_ftrace_function+0x68/0x88 [ 36.842738] klp_patch_object+0x1c8/0x330 [ 36.843196] klp_enable_patch+0x468/0x828 Regards, Ivan [1] https://github.com/lpechacek/qa_test_klp For this to work on aarch64 you will need fixes from PR#13 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel