All of lore.kernel.org
 help / color / mirror / Atom feed
From: Youwan Wang <wangyouwan@uniontech.com>
To: linux-bluetooth@vger.kernel.org
Cc: Youwan Wang <wangyouwan@uniontech.com>
Subject: [PATCH] obexd: Fix crash of transfer pointer has being freed
Date: Wed, 15 Jun 2022 20:49:02 +0800	[thread overview]
Message-ID: <20220615124902.17347-1-wangyouwan@uniontech.com> (raw)

PC1 -> PC2 in the process of transferring the file,
PC2 terminate the reception.
It is found that PC1 will receive the Rcvd
Forbiden message.
transfer_response func is called and go to failed:
transfer_complete func is called and go to transfer_free

Invalid read of size 8
    at 0x129C9B: put_get_data (gobex-transfer.c:138)
    by 0x128675: get_body (gobex-packet.c:397)
    by 0x128675: g_obex_packet_encode (gobex-packet.c:451)
    by 0x1264ED: write_data (gobex.c:461)
    by 0x1264ED: write_data (gobex.c:431)
    by 0x49B7E97: g_main_context_dispatch ()
    by 0x49B8287: ??? ()
    by 0x49B8581: g_main_loop_run ()
    by 0x120834: main (main.c:322)
  Address 0x7300028 is 56 bytes inside a block of size 64 free'd
    at 0x48369AB: free (vg_replace_malloc.c:530)
    by 0x12A404: transfer_response (gobex-transfer.c:245)
    by 0x126B02: handle_response (gobex.c:1128)
    by 0x127087: incoming_data (gobex.c:1373)
    by 0x49B7E97: g_main_context_dispatch ()
    by 0x49B8287: ??? ()
    by 0x49B8581: g_main_loop_run ()
    by 0x120834: main (main.c:322)
  Block was alloc'd at
    at 0x4837B65: calloc (vg_replace_malloc.c:752)
    by 0x49BD9D8: g_malloc0 ()
    by 0x129A49: transfer_new (gobex-transfer.c:258)
    by 0x12A612: g_obex_put_req_pkt (gobex-transfer.c:282)
    by 0x12A612: g_obex_put_req_pkt (gobex-transfer.c:271)
    by 0x145862: transfer_start_put (transfer.c:880)
    by 0x145862: obc_transfer_start (transfer.c:911)
    by 0x13B487: session_process_transfer (session.c:836)
    by 0x13C128: session_process_queue (session.c:887)
    by 0x13C128: session_process_queue (session.c:872)
    by 0x13C18F: session_process (session.c:820)
    by 0x49B7E97: g_main_context_dispatch (in /usr/lib/x86_64-linux-gnu/)
    by 0x49B8287: ??? (in /usr/lib/x86_64-linux-gnu/)
    by 0x49B8581: g_main_loop_run (in /usr/lib/x86_64-linux-gnu/)
    by 0x120834: main (main.c:322)
---
 gobex/gobex-transfer.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gobex/gobex-transfer.c b/gobex/gobex-transfer.c
index c94d018b2..8e97fc73e 100644
--- a/gobex/gobex-transfer.c
+++ b/gobex/gobex-transfer.c
@@ -197,6 +197,14 @@ static void transfer_response(GObex *obex, GError *err, GObexPacket *rsp,
 	}
 
 	rspcode = g_obex_packet_get_operation(rsp, &final);
+	if (rspcode == G_OBEX_RSP_FORBIDDEN) {
+		err = g_error_new(G_OBEX_ERROR, rspcode, "%s",
+						g_obex_strerror(rspcode));
+		g_obex_debug(G_OBEX_DEBUG_ERROR, "%s", err->message);
+		g_error_free(err);
+		return;
+	}
+
 	if (rspcode != G_OBEX_RSP_SUCCESS && rspcode != G_OBEX_RSP_CONTINUE) {
 		err = g_error_new(G_OBEX_ERROR, rspcode, "%s",
 						g_obex_strerror(rspcode));
-- 
2.20.1




             reply	other threads:[~2022-06-15 12:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 12:49 Youwan Wang [this message]
2022-06-15 14:39 ` obexd: Fix crash of transfer pointer has being freed bluez.test.bot
2022-06-17 22:58 ` [PATCH] " Luiz Augusto von Dentz
2022-06-29 23:52   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220615124902.17347-1-wangyouwan@uniontech.com \
    --to=wangyouwan@uniontech.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.