From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B845EC433EF for ; Wed, 15 Jun 2022 13:29:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352372AbiFON3N (ORCPT ); Wed, 15 Jun 2022 09:29:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245504AbiFON2w (ORCPT ); Wed, 15 Jun 2022 09:28:52 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B01B513CC9; Wed, 15 Jun 2022 06:28:50 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 8196E1C0BC8; Wed, 15 Jun 2022 15:28:49 +0200 (CEST) Date: Wed, 15 Jun 2022 15:28:41 +0200 From: Pavel Machek To: David Wang Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edward_chen@jabil.com, ben_pai@jabil.com Subject: Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC Message-ID: <20220615132841.GC1429@bug> References: <20220531011100.882643-1-David_Wang6097@jabil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220531011100.882643-1-David_Wang6097@jabil.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > The initial introduction of the jabil server with AST2600 BMC SoC. > + led-0 { > + label = "identify"; > + color = ; > + function = LED_FUNCTION_INDICATOR; > + retain-state-shutdown; > + gpios = <&gpio0 ASPEED_GPIO(B, 7) GPIO_ACTIVE_LOW>; > + }; > + > + led-1 { > + label = "status_amber"; > + label = "status_green"; > + label = "status_susack"; > + led-4 { > + label = "power-amber"; > + label = "fan1-fault"; Please take a look at LED documentation and try to come up with something more in line with existing conventions. Also please cc linux-leds list. Best regards, Pavel