From: Eric Farman <farman@linux.ibm.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
Eric Farman <farman@linux.ibm.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Subject: [PATCH v2 00/10] s390/vfio-ccw rework
Date: Wed, 15 Jun 2022 22:33:08 +0200 [thread overview]
Message-ID: <20220615203318.3830778-1-farman@linux.ibm.com> (raw)
Last autumn, Jason Gunthorpe proposed some rework of vfio-ccw [1],
to better fit with the new mdev API (thank you!). Part of that
series was pulled for kernel 5.16 [2], but the complexities of
the remaining patches got them hung up behind other work.
I dusted off that work a couple weeks ago (see v1), but am going
to split that further with the goal of this part to clean up the
existing device lifecycle and FSM used by vfio-ccw. The remaining
work runs into conflicts with other work (notably [2]), so I'd
like to propose this first group without that hangup. This makes
the behavior/usage of the FSM state a lot more consistent than
it is today.
This is all internal to vfio-ccw, with the exception of removal
of mdev_uuid from include/linux/mdev.h in patch 1.
@Kirti, I can drop that hunk if that's a concern for you.
One potential conflict still exists on patch 6, with [3].
v1->v2:
- Rebased to v5.19-rc2
- Patch 1: Remove mdev.h from vfio_ccw_fsm.c
- Patch 4: Earlier patches removed meaningful users of private->mdev,
leaving this as a very simple cleanup
- [JG,MR] Added r-b's (Thank You!)
- [MR] Patch 1: Update commit message
- [MR] Patch 2: Add comment regarding interrupt types changing FSM state
- [MR] Patch 5: Drop Fixes tag
- [JG] Drop patch for clearing drvdata on mdev remove
- [EF] Defer items to later series
- The "if !private" patch, and JG's associated comment on patch 7;
entire process requires further investigation
- The vfio-mdev rework patches (to [2])
- The "tie vfio_ccw_private to mdev lifecycle" patches
v1: https://lore.kernel.org/r/20220602171948.2790690-1-farman@linux.ibm.com/
Footnotes:
[1] https://lore.kernel.org/r/0-v3-57c1502c62fd+2190-ccw_mdev_jgg@nvidia.com/
[2] https://lore.kernel.org/r/20220603063328.3715-1-hch@lst.de/
[3] https://lore.kernel.org/r/165471414407.203056.474032786990662279.stgit@omen/
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Eric Farman (9):
vfio/ccw: Fix FSM state if mdev probe fails
vfio/ccw: Do not change FSM state in subchannel event
vfio/ccw: Remove private->mdev
vfio/ccw: Pass enum to FSM event jumptable
vfio/ccw: Flatten MDEV device (un)register
vfio/ccw: Create an OPEN FSM Event
vfio/ccw: Create a CLOSE FSM event
vfio/ccw: Refactor vfio_ccw_mdev_reset
vfio/ccw: Move FSM open/close to MDEV open/close
Michael Kawano (1):
vfio/ccw: Remove UUID from s390 debug log
drivers/s390/cio/vfio_ccw_async.c | 1 -
drivers/s390/cio/vfio_ccw_drv.c | 59 ++++++-------------
drivers/s390/cio/vfio_ccw_fsm.c | 89 ++++++++++++++++++++++++-----
drivers/s390/cio/vfio_ccw_ops.c | 77 ++++++++-----------------
drivers/s390/cio/vfio_ccw_private.h | 9 +--
include/linux/mdev.h | 5 --
6 files changed, 117 insertions(+), 123 deletions(-)
--
2.32.0
next reply other threads:[~2022-06-15 20:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 20:33 Eric Farman [this message]
2022-06-15 20:33 ` [PATCH v2 01/10] vfio/ccw: Remove UUID from s390 debug log Eric Farman
2022-06-15 20:57 ` Kirti Wankhede
2022-06-15 20:33 ` [PATCH v2 02/10] vfio/ccw: Fix FSM state if mdev probe fails Eric Farman
2022-06-15 20:33 ` [PATCH v2 03/10] vfio/ccw: Do not change FSM state in subchannel event Eric Farman
2022-06-16 15:35 ` Matthew Rosato
2022-06-16 17:13 ` Eric Farman
2022-06-15 20:33 ` [PATCH v2 04/10] vfio/ccw: Remove private->mdev Eric Farman
2022-06-16 15:36 ` Matthew Rosato
2022-06-23 14:59 ` Jason Gunthorpe
2022-06-15 20:33 ` [PATCH v2 05/10] vfio/ccw: Pass enum to FSM event jumptable Eric Farman
2022-06-15 20:33 ` [PATCH v2 06/10] vfio/ccw: Flatten MDEV device (un)register Eric Farman
2022-06-15 20:33 ` [PATCH v2 07/10] vfio/ccw: Create an OPEN FSM Event Eric Farman
2022-06-16 16:33 ` Matthew Rosato
2022-06-16 17:14 ` Eric Farman
2022-06-16 17:18 ` Matthew Rosato
2022-06-15 20:33 ` [PATCH v2 08/10] vfio/ccw: Create a CLOSE FSM event Eric Farman
2022-06-16 16:48 ` Matthew Rosato
2022-06-15 20:33 ` [PATCH v2 09/10] vfio/ccw: Refactor vfio_ccw_mdev_reset Eric Farman
2022-06-15 20:33 ` [PATCH v2 10/10] vfio/ccw: Move FSM open/close to MDEV open/close Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615203318.3830778-1-farman@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.