From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720C9C43334 for ; Thu, 16 Jun 2022 00:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349165AbiFPAIE (ORCPT ); Wed, 15 Jun 2022 20:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241580AbiFPAIC (ORCPT ); Wed, 15 Jun 2022 20:08:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C53DB1F1; Wed, 15 Jun 2022 17:08:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 30D07B82200; Thu, 16 Jun 2022 00:07:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0445C3411A; Thu, 16 Jun 2022 00:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655338077; bh=q8YzhSaafF/Ue74x1AOsaawzDagC4rLNcNc0vGwhM+s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=B0FKjk4QfTq6yhSXcj65WKX3BZn7UBumKje7QHw7nZdu75US71YJkgErgGFvCGFSR mtz4EM6lBHI28F3HB2FTFbvzF06UgLZj0fPgZ7W5pem0AXAFQRfUon8IJHvXv85p7B p/YUpIN0z20/x3wSPjDlghT1720Yn65t2F75Og8WPfrR2mDxqPZmUgsIpRx06pTAZa ES7bjWpEdtfot+QDtszxJbjFGWvT7sx9a7YZKkAWqusJG5NixMhuY8D+x2RslmsBx2 fa++65J6sxfrGyarVcNyYsSeMoyLRZmknzrV46pdMrKrcb5naOGaqDB/+c+vdM8WmI lsbU1FO0+zabw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220526101215.1519155-1-jiasheng@iscas.ac.cn> References: <20220526101215.1519155-1-jiasheng@iscas.ac.cn> Subject: Re: [PATCH] clk: samsung: Add check for platform_driver_register From: Stephen Boyd Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiasheng Jiang To: Jiasheng Jiang , alim.akhtar@samsung.com, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, mturquette@baylibre.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com Date: Wed, 15 Jun 2022 17:07:55 -0700 User-Agent: alot/0.10 Message-Id: <20220616000757.D0445C3411A@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jiasheng Jiang (2022-05-26 03:12:15) > As platform_driver_register() could fail, it should be better > to deal with the return value in order to maintain the code > consisitency. >=20 > Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver") > Signed-off-by: Jiasheng Jiang > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A5D6C43334 for ; Thu, 16 Jun 2022 00:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HLb1tWd689TvwW8tQlPOpiZv1Mo3cJk6LF7ztIh5400=; b=Y6vpxJ2uCgsl3S u0uGLp+03eu3DfxYK6eZfcxMjPjJPyt+losCI9cZnxy9OFaTdsQmF+F7kOt90V43qXDdInNpskWiq xJ0IeBjvwu5KvhRfmglzYL6SqFXg2VqMg/+S9u4BVD/DcyMTt9jMERq5UJg9oRNcS7fb4o5UU8q2E 6odSIYJet0bXiNUhBLiyd8nn9SDwh12UrlEILV8cZvdN3/VLpLpyp/+h3CuC1/VxCtuWyTA4WiOnU 3fja83IhTpUu1Qom2ONQgC+HYLo2fJPpD5Srtp8RwBnwXAnawvecWgb1ug3aGr9bX4vcwBM/1GhAE iuNljewEkcCq9qJV9BYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1d3M-00H3Kz-IU; Thu, 16 Jun 2022 00:08:04 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1d3J-00H3K3-9B for linux-arm-kernel@lists.infradead.org; Thu, 16 Jun 2022 00:08:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43189B82201; Thu, 16 Jun 2022 00:07:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0445C3411A; Thu, 16 Jun 2022 00:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655338077; bh=q8YzhSaafF/Ue74x1AOsaawzDagC4rLNcNc0vGwhM+s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=B0FKjk4QfTq6yhSXcj65WKX3BZn7UBumKje7QHw7nZdu75US71YJkgErgGFvCGFSR mtz4EM6lBHI28F3HB2FTFbvzF06UgLZj0fPgZ7W5pem0AXAFQRfUon8IJHvXv85p7B p/YUpIN0z20/x3wSPjDlghT1720Yn65t2F75Og8WPfrR2mDxqPZmUgsIpRx06pTAZa ES7bjWpEdtfot+QDtszxJbjFGWvT7sx9a7YZKkAWqusJG5NixMhuY8D+x2RslmsBx2 fa++65J6sxfrGyarVcNyYsSeMoyLRZmknzrV46pdMrKrcb5naOGaqDB/+c+vdM8WmI lsbU1FO0+zabw== MIME-Version: 1.0 In-Reply-To: <20220526101215.1519155-1-jiasheng@iscas.ac.cn> References: <20220526101215.1519155-1-jiasheng@iscas.ac.cn> Subject: Re: [PATCH] clk: samsung: Add check for platform_driver_register From: Stephen Boyd Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiasheng Jiang To: Jiasheng Jiang , alim.akhtar@samsung.com, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, mturquette@baylibre.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com Date: Wed, 15 Jun 2022 17:07:55 -0700 User-Agent: alot/0.10 Message-Id: <20220616000757.D0445C3411A@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_170801_510612_5B0DC4E2 X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Jiasheng Jiang (2022-05-26 03:12:15) > As platform_driver_register() could fail, it should be better > to deal with the return value in order to maintain the code > consisitency. > > Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver") > Signed-off-by: Jiasheng Jiang > --- Reviewed-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel