From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C74C433EF for ; Thu, 16 Jun 2022 01:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352376AbiFPBvk (ORCPT ); Wed, 15 Jun 2022 21:51:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350843AbiFPBve (ORCPT ); Wed, 15 Jun 2022 21:51:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3FB258E53; Wed, 15 Jun 2022 18:51:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 01B1361CED; Thu, 16 Jun 2022 01:51:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5697EC341C0; Thu, 16 Jun 2022 01:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655344288; bh=VHGuD3oUIVDRtnrxF+nkSpDbHsE8XAqaQQ+vQslwz24=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=JBkr00yLx65g8QqtPLDb+l0cklP3maYgekq569wr7R3nmYSO1gLOvXunnsrAEZdiH AzmlXp/SGpXGfX9MLqakAzE2az8Shk1BGKg+IoPgWR1KQ/wJHjn6LghRyx7lG13EEW ZQQdCwGnZJw+HV4l3wOrrCqM10471yTtKQKrzWmvLMq5ZaViqJwMboJdWzZsQ4Ir6C G4NZ1CwP2Xz01PHkKO4LdwiMOgSOsLd9q0jV2Lgp+BHgUx76wCsNkE260NyjBZNcbI NQ+9itvcbWFDXwBrc60FortDi/gGWjVDgrcbj1fukyxpL2BnhjgpDNhe00HxxAoRC4 y53lDX23NWIvA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220523093346.28493-6-rex-bc.chen@mediatek.com> References: <20220523093346.28493-1-rex-bc.chen@mediatek.com> <20220523093346.28493-6-rex-bc.chen@mediatek.com> Subject: Re: [RESEND v8 05/19] clk: mediatek: reset: Merge and revise reset register function From: Stephen Boyd Cc: p.zabel@pengutronix.de, angelogioacchino.delregno@collabora.com, nfraprado@collabora.com, chun-jie.chen@mediatek.com, wenst@chromium.org, runyang.chen@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Rex-BC Chen To: Rex-BC Chen , krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, mturquette@baylibre.com, robh+dt@kernel.org Date: Wed, 15 Jun 2022 18:51:25 -0700 User-Agent: alot/0.10 Message-Id: <20220616015128.5697EC341C0@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rex-BC Chen (2022-05-23 02:33:32) > There are two versions for clock reset register control for MediaTek > SoCs. The old hardware is one bit per reset control, and does not > have separate registers for bit set, clear and read-back operations. > This matches the scheme supported by the simple reset driver. >=20 > However, because we need to use different data structure from > reset_simple_data, we can not use the operation of simple reset > driver. > For this reason, we keep the original functions and name this version > as "MTK_RST_SIMPLE". >=20 > In this patch: > - Add a version enumeration to separate different reset hardware. > - Merge the reset register function of simple and set_clr into one > function "mtk_register_reset_controller". > - Rename input variable "num_regs" to "rst_bank_nr" to avoid > confusion. This variable is used to define the quantity of reset bank. > - Document mtk_reset_version and mtk_register_reset_controller. >=20 > Signed-off-by: Rex-BC Chen > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: N=C3=ADcolas F. R. A. Prado > Tested-by: N=C3=ADcolas F. R. A. Prado > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBC44C433EF for ; Thu, 16 Jun 2022 01:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xBVlSACbr2EL/WFNAH7LlbSyt8SasWw4+5eDPU6Y9FA=; b=4qVZ+KcAAQ6yf6 XByLytbCyp7LrOG/queHV2IgQNDA/N0Q9vTXMJKfbGuyNRNnRYFZI2IObu/E7qranSmVeL+04x6H2 numarus+AgRTO8EiU0i6+hnfDffu8TlGF/AC8MnNRRvZJDn1eAuyTnDJ2+5Oce4taooyNVJMC+oIo PznWccu2iOsh93OI5QJ97WQE056STs1/HZyOU1CnotuRUzWdBPeSke/OGk5us82KUD5rvc/VDzoRf KhE4zSd08vAZfoprVLe5TDPxoTQPyN3NJNnfaqNaYy0RL58yO4fPtxDyLXswKpvxkfaUyZw2ePENd zf7Z39XQcAtRYpa1Te1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1efr-00HSZO-7i; Thu, 16 Jun 2022 01:51:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1efS-00HSKB-Uk; Thu, 16 Jun 2022 01:51:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7976061D02; Thu, 16 Jun 2022 01:51:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5697EC341C0; Thu, 16 Jun 2022 01:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655344288; bh=VHGuD3oUIVDRtnrxF+nkSpDbHsE8XAqaQQ+vQslwz24=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=JBkr00yLx65g8QqtPLDb+l0cklP3maYgekq569wr7R3nmYSO1gLOvXunnsrAEZdiH AzmlXp/SGpXGfX9MLqakAzE2az8Shk1BGKg+IoPgWR1KQ/wJHjn6LghRyx7lG13EEW ZQQdCwGnZJw+HV4l3wOrrCqM10471yTtKQKrzWmvLMq5ZaViqJwMboJdWzZsQ4Ir6C G4NZ1CwP2Xz01PHkKO4LdwiMOgSOsLd9q0jV2Lgp+BHgUx76wCsNkE260NyjBZNcbI NQ+9itvcbWFDXwBrc60FortDi/gGWjVDgrcbj1fukyxpL2BnhjgpDNhe00HxxAoRC4 y53lDX23NWIvA== MIME-Version: 1.0 In-Reply-To: <20220523093346.28493-6-rex-bc.chen@mediatek.com> References: <20220523093346.28493-1-rex-bc.chen@mediatek.com> <20220523093346.28493-6-rex-bc.chen@mediatek.com> Subject: Re: [RESEND v8 05/19] clk: mediatek: reset: Merge and revise reset register function From: Stephen Boyd Cc: p.zabel@pengutronix.de, angelogioacchino.delregno@collabora.com, nfraprado@collabora.com, chun-jie.chen@mediatek.com, wenst@chromium.org, runyang.chen@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Rex-BC Chen To: Rex-BC Chen , krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, mturquette@baylibre.com, robh+dt@kernel.org Date: Wed, 15 Jun 2022 18:51:25 -0700 User-Agent: alot/0.10 Message-Id: <20220616015128.5697EC341C0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_185131_062959_664D1B6D X-CRM114-Status: GOOD ( 14.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBSZXgtQkMgQ2hlbiAoMjAyMi0wNS0yMyAwMjozMzozMikKPiBUaGVyZSBhcmUgdHdv IHZlcnNpb25zIGZvciBjbG9jayByZXNldCByZWdpc3RlciBjb250cm9sIGZvciBNZWRpYVRlawo+ IFNvQ3MuIFRoZSBvbGQgaGFyZHdhcmUgaXMgb25lIGJpdCBwZXIgcmVzZXQgY29udHJvbCwgYW5k IGRvZXMgbm90Cj4gaGF2ZSBzZXBhcmF0ZSByZWdpc3RlcnMgZm9yIGJpdCBzZXQsIGNsZWFyIGFu ZCByZWFkLWJhY2sgb3BlcmF0aW9ucy4KPiBUaGlzIG1hdGNoZXMgdGhlIHNjaGVtZSBzdXBwb3J0 ZWQgYnkgdGhlIHNpbXBsZSByZXNldCBkcml2ZXIuCj4gCj4gSG93ZXZlciwgYmVjYXVzZSB3ZSBu ZWVkIHRvIHVzZSBkaWZmZXJlbnQgZGF0YSBzdHJ1Y3R1cmUgZnJvbQo+IHJlc2V0X3NpbXBsZV9k YXRhLCB3ZSBjYW4gbm90IHVzZSB0aGUgb3BlcmF0aW9uIG9mIHNpbXBsZSByZXNldAo+IGRyaXZl ci4KPiBGb3IgdGhpcyByZWFzb24sIHdlIGtlZXAgdGhlIG9yaWdpbmFsIGZ1bmN0aW9ucyBhbmQg bmFtZSB0aGlzIHZlcnNpb24KPiBhcyAiTVRLX1JTVF9TSU1QTEUiLgo+IAo+IEluIHRoaXMgcGF0 Y2g6Cj4gLSBBZGQgYSB2ZXJzaW9uIGVudW1lcmF0aW9uIHRvIHNlcGFyYXRlIGRpZmZlcmVudCBy ZXNldCBoYXJkd2FyZS4KPiAtIE1lcmdlIHRoZSByZXNldCByZWdpc3RlciBmdW5jdGlvbiBvZiBz aW1wbGUgYW5kIHNldF9jbHIgaW50byBvbmUKPiAgIGZ1bmN0aW9uICJtdGtfcmVnaXN0ZXJfcmVz ZXRfY29udHJvbGxlciIuCj4gLSBSZW5hbWUgaW5wdXQgdmFyaWFibGUgIm51bV9yZWdzIiB0byAi cnN0X2JhbmtfbnIiIHRvIGF2b2lkCj4gICBjb25mdXNpb24uIFRoaXMgdmFyaWFibGUgaXMgdXNl ZCB0byBkZWZpbmUgdGhlIHF1YW50aXR5IG9mIHJlc2V0IGJhbmsuCj4gLSBEb2N1bWVudCBtdGtf cmVzZXRfdmVyc2lvbiBhbmQgbXRrX3JlZ2lzdGVyX3Jlc2V0X2NvbnRyb2xsZXIuCj4gCj4gU2ln bmVkLW9mZi1ieTogUmV4LUJDIENoZW4gPHJleC1iYy5jaGVuQG1lZGlhdGVrLmNvbT4KPiBSZXZp ZXdlZC1ieTogQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gPGFuZ2Vsb2dpb2FjY2hpbm8uZGVs cmVnbm9AY29sbGFib3JhLmNvbT4KPiBSZXZpZXdlZC1ieTogTsOtY29sYXMgRi4gUi4gQS4gUHJh ZG8gPG5mcmFwcmFkb0Bjb2xsYWJvcmEuY29tPgo+IFRlc3RlZC1ieTogTsOtY29sYXMgRi4gUi4g QS4gUHJhZG8gPG5mcmFwcmFkb0Bjb2xsYWJvcmEuY29tPgo+IC0tLQoKQXBwbGllZCB0byBjbGst bmV4dAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=