From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C42AC43334 for ; Fri, 17 Jun 2022 14:50:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFD26843FB; Fri, 17 Jun 2022 16:50:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Wpm8Phkv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0300E843F2; Fri, 17 Jun 2022 16:50:17 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7C7B6843F4 for ; Fri, 17 Jun 2022 16:50:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id 88so3216413qva.9 for ; Fri, 17 Jun 2022 07:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kguAaRbZ6I9Y80RXBmvT19ofkxU9xEMzC+1WLLw7mrg=; b=Wpm8Phkvtqyj31P/Zr+IEIjewoehdUHEZSg2Nct5gOzlUoz/e0zARdlzWAvf+uxDg2 iFzKSuWD2v7PFV6dZHfeH3plZY8aRBUAc2Ofb8mw5VVOulJaY8zFTuSiA9v9OcD687N9 Me+hEWGI97pxk3bF5Xs0JNCktSWYy/PNNFtYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kguAaRbZ6I9Y80RXBmvT19ofkxU9xEMzC+1WLLw7mrg=; b=cB5yT6/MEH2UdnNTLJ3akXaH3AuOOT6wDAzojboSzeSP7/NDd+UMuAZkHRsy4u7FLb yVej0cy1Vfp26VtH3CTPvTDV9buvO3ONCHtg3/1cPJ7jDPCn7LJzrRCCe6tbDJ+bHxCt kQBXRDLgaf/rwqyAM/xE2yh4gRZVQoP/i7VULzExRN9XC24HlZMh7aFrcueScjRMLqJ+ mztt4fKyjGEKFq2LdcklgIs89NLWByVzpFg0tmQ7UldC8uCN6vfT1Xc8/H71QEhShbzj 9+gTfioErqFnzMpvmkJWc4k7tppxt7UJYyLzibBi2aVPnjN9k78Q2r37qYTQSHHGPOQc vMNA== X-Gm-Message-State: AJIora8Qc049nn6uECD/H9PpptvZQsC1hSFLfkFmYIm/sHx3yj0nA+ij tYWl3ChehhjgEUuxQjxI2Xf8Ag== X-Google-Smtp-Source: AGRyM1sbEH+s0A+ZKUs3jbjgJ8fzGzWOvKdjeQmX5QEgXpU84t9o0S17fWRV1+b3CeAkX5E1278+Ug== X-Received: by 2002:ac8:5b04:0:b0:306:6cea:18e2 with SMTP id m4-20020ac85b04000000b003066cea18e2mr9011055qtw.95.1655477413314; Fri, 17 Jun 2022 07:50:13 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id v1-20020a05620a0f0100b006a787380a5csm4846509qkl.67.2022.06.17.07.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 07:50:12 -0700 (PDT) Date: Fri, 17 Jun 2022 10:50:10 -0400 From: Tom Rini To: Francis Laniel Cc: u-boot@lists.denx.de, Marek Behun , Michael Nazzareno Trimarchi , Simon Glass , Wolfgang Denk , Harald Seiler Subject: Re: [RFC PATCH v4 00/28] Modernize U-Boot shell Message-ID: <20220617145010.GA2484912@bill-the-cat> References: <20220616223158.9225-1-francis.laniel@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="D8HGaWww+jmMTa6P" Content-Disposition: inline In-Reply-To: <20220616223158.9225-1-francis.laniel@amarulasolutions.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --D8HGaWww+jmMTa6P Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 17, 2022 at 12:31:30AM +0200, Francis Laniel wrote: > Hi. >=20 >=20 > First I hope you are fine and the same for your relatives. >=20 > During 2021 summer, Sean Anderson wrote a contribution to add a new shell= , based > on LIL, to U-Boot [1][2]. > While one of the goals of this contribution was to address the fact actual > U-Boot shell, which is based on Busybox hush, is old there was a discussi= on > about adding a new shell versus updating the actual one [3][4]. >=20 > So, in this series, with Harald Seiler, we updated the actual U-Boot shel= l to > reflect what is currently in Busybox source code. > Basically, this contribution is about taking a snapshot of Busybox shell/= hush.c > file (as it exists in commit 37460f5da) and adapt it to suit U-Boot needs. >=20 > This contribution was written to be as backward-compatible as possible to= avoid > breaking the existing. > So, the 2021 hush flavor offers the same as the actual, that is to say: > 1. Variable expansion. > 2. Instruction lists (;, && and ||). > 3. If, then and else. > 4. Loops (for, while and until). > No new features offered by Busybox hush were implemented (e.g. functions). >=20 > It is possible to change the parser at runtime using the "parser" command: > =3D> parser print > old > =3D> parser set 2021 > 2021> parser print > 2021 > 2021> parser set old > =3D> > The default parser is the old one. >=20 > In terms of testing, new unit tests were added to ut to ensure the new be= havior > is the same as the old one and it does not add regression. > Nonetheless, if old behavior was buggy and fixed upstream, the fix is the= n added > to U-Boot [5]. > In sandbox, all of these tests pass smoothly: > =3D> printenv board > board=3Dsandbox > =3D> ut hush > Running 20 hush tests > ... > Failures: 0 > =3D> parser set 2021 > 2021> ut hush > Running 20 hush tests > ... > Failures: 0 >=20 > Thanks to the effort of Harald Seiler, I was successful booting a board: > 2021> printenv board_rev > board_rev=3DiMX8MP > 2021> boot > ... > root@iMX8MPboard:~# fw_printenv board_rev > board_rev=3DiMX8MP >=20 > I also tested another board where both parser were successful to boot it: > =3D> printenv fdtfile > fdtfile=3Damlogic/meson-gxl-s905x-libretech-cc.dtb > =3D> boot > ... > root@lepotato:~# > root@lepotato:~# reboot > ... > =3D> parser set 2021 > 2021> printenv fdtfile > fdtfile=3Damlogic/meson-gxl-s905x-libretech-cc.dtb > 2021> boot > ... > root@lepotato:~# >=20 > Sadly, I was not able to have the CI passes smoothly... > To pass it and be aware of all the troubles, I added the 3 last commits as > "trick" commits. I've replied to those now. And generally I just want to say I'm very happy with the progress here in v3->v4. --=20 Tom --D8HGaWww+jmMTa6P Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKslKIACgkQFHw5/5Y0 tyyMBgv/RoHYr1m5/H/BkYx9defAHcv+rX/ZgH0AjfmQYIJjCWvoYWx2TyuN4U25 GJ5g6XqS/XZU30+4a2aXZkgGDIgnEReqPettUwIu2QGUKcN93/C/JA3JQeBvg3L9 rzcEvvvXnNKdCSOZQXxbX52jGIIqBTf3qUscYh3VDV1XOLogHDdHGxUgVmf0RPys 0zpZrYT8+R2BZgFU6GvqHl5WMH38ZZpoDpkKSGC7NK5idtySCJUN3/1BPctwfHr7 07lu0w91eASFNk7dceZmqPv328qmBtkqz/+yUdJQR6YFKYRxdJe8MXnWW72zp0Ub dm6PXRTzLRVPLP4mYENolfl/dNQMybI+SMmLzpHE7lpEH5b6KeZt7dWHtA/qDvqo 52Y/VErrFoYFf0oqBpWRz6b+J5DzjnsBmR39NeSL5QkDsVvMkCT5hcvUnV1aS7uU AVkZ7wgA4wBt8oeFNUcJLy0Ccc3mMlaSYJkEd4lwiMCZlEbq/BJP6s++Cbkcib/h 3qRhTSof =9K0C -----END PGP SIGNATURE----- --D8HGaWww+jmMTa6P--