From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EC6DC43334 for ; Fri, 17 Jun 2022 18:50:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20AC2843EA; Fri, 17 Jun 2022 20:50:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="T/MZn+hF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D648F83B68; Fri, 17 Jun 2022 20:50:29 +0200 (CEST) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77B5C83B68 for ; Fri, 17 Jun 2022 20:50:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id 89so7754619qvc.0 for ; Fri, 17 Jun 2022 11:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qjV52PYRsT1uXDvNFlefZsSAGtJvSBn0vCteXH19PFQ=; b=T/MZn+hFGNFZn1apIhqXSDXV0YMDH4wu/wKFevg0cl3fEuDP3QP+lnz0l3hxu2NOGe ttwbSPoUxA/r77loCBX5fxVM2XSl+6ydFdXeNG+xPVSw3OMcQgWeyW05qdTGCKG0y1Cj /eGRrDaly4Ip2Jv8r8x9DO3DRLP/KAgm7RC3k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qjV52PYRsT1uXDvNFlefZsSAGtJvSBn0vCteXH19PFQ=; b=7iVxUZb+FlcLmU6iecoEboovFDufk1oD276gsjuV8UBmidoKlJ8CremCU91aDiYYGw YylMu70/RT0n8Q9oZAIKFCe6dIWQ/qBWYCynm9OOtu6tDO4458LgfIMCrOJjhZM+D+WY wEH9okBacPMfY9Uunc5n2wIr8q7VT0SZtNIelETBjWPAEBZMLhqNyhHcblIfvQlHRVNC aGcAOjzmhVEKKUpMAxPAS6cJnWafKwEnvdb5lDUn5qNEHpvG7CklkmfJXmDruCFBYllP 9xqRIRa1pZLcUppodLU9iJrd+0uJ1GIfG7JsEMtHnupkjTcohxAc/OPIzcmCfNtnx8ss 1aWg== X-Gm-Message-State: AJIora9yGB+9I8qpWyg/oz7LdNthtmhcFuas3NBKebmJKdl6a0/wkBUV RSPMXGHvj0E6hk7vlmkdrzVu9g== X-Google-Smtp-Source: AGRyM1tdJ81SnnBSGmYRq/ln2mWrNY/0h/kz6Rz4aM/DGcvHUtVdzRAedB4L3pahc/UqNf82xR6o/w== X-Received: by 2002:a0c:e74e:0:b0:46b:55e7:3152 with SMTP id g14-20020a0ce74e000000b0046b55e73152mr9651788qvn.41.1655491826177; Fri, 17 Jun 2022 11:50:26 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id az32-20020a05620a172000b006a780aa9fc4sm5168463qkb.96.2022.06.17.11.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 11:50:25 -0700 (PDT) Date: Fri, 17 Jun 2022 14:50:22 -0400 From: Tom Rini To: Nishanth Menon Cc: Robert Nelson , gadiyar@ti.com, Praneeth Bajjuri , Jason Kridner , u-boot@lists.denx.de Subject: Re: [PATCH 1/3] board: ti: common: Optimize boot when detecting consecutive bad records Message-ID: <20220617185022.GB2484912@bill-the-cat> References: <20220617182612.12575-1-nm@ti.com> <20220617182612.12575-2-nm@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vED6l2zsv8VR3Sl5" Content-Disposition: inline In-Reply-To: <20220617182612.12575-2-nm@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --vED6l2zsv8VR3Sl5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 17, 2022 at 01:26:10PM -0500, Nishanth Menon wrote: > The eeprom data area is much bigger than the data we intend to store, > however, with bad programming, we might end up reading bad records over > and over till we run out of eeprom space. instead just exit when 10 > consecutive records are read. >=20 > Signed-off-by: Nishanth Menon Why not just stop at the first bad record? Otherwise 10 seems like a fine, small, arbitrary number. If it's not arbitrary but number of total records, do we already enum the total number of records or something where we could say that we tried to read all possible records, everyone was bad, stop? --=20 Tom --vED6l2zsv8VR3Sl5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKszOQACgkQFHw5/5Y0 tyyOwgv/Ww6eUMBNq59mNc/hV7AJ0N3aZGPu/UUP0nRPl4cEuz0tKkMaedlje6ue IzTePtQZwqC8J3xWZjZNXICubqgeqLDJHN1N+R633W6NvpO4DBu1M4VwKAS0r9iO 7h3DwcQHoLDQRoMOCUpRmnEPoF8993QE8OEjN5ItgMUchSiXF0Ol3+eyuAT0pGyR nPs/8ntgqSey7MHf0cAX7vQbtvUNGBiKxXG7jLaD/NvIIvSuAv7CCar6DEXftC12 sAyqwZ8odCaxkjRSvC2tBu5pDbXej76KhvS/aVN4BN3mx9MzZ6lpvOfi6iRczNsI 50QP1xh5xPimJAY1v1/iA0S0YW/ckGr6tgTr/FvbmdOZt5ydfL8oRtUTxlkwWHAc rBfwoAIty6eIploUH3at3hNS+3NxLLloIKYcaAzwaQVL14gF6DhmU3UIJHoP25r/ zBmLjE8FlkYUxnQd12AplV7yWZF1nDegylkX6JZvh1k4wUNxjEpLwvPRA0NL0ycj bYiaa1P/ =3/+4 -----END PGP SIGNATURE----- --vED6l2zsv8VR3Sl5--