From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71531C433EF for ; Sat, 18 Jun 2022 14:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239499AbiFROGe (ORCPT ); Sat, 18 Jun 2022 10:06:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239472AbiFROG0 (ORCPT ); Sat, 18 Jun 2022 10:06:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 795F113E3C; Sat, 18 Jun 2022 07:06:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 391FEB8013C; Sat, 18 Jun 2022 14:06:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 787ADC3411A; Sat, 18 Jun 2022 14:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655561182; bh=C5dR11nmIbd7ulhKg+caNcYU9xH6pSpJ8aq4v29W2BU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DReMJwDyEA1rcbhV7Wyw0PnbBvnKJgwDNmNDXZH9pP3SmmsLbJOO1DGD2skMuNudA mHpUBsKzkhPIXv000C2dhc6HAG/hgWkDq16QbQE3Ab+m7MaPVK9a68XLmJyK4Pj8P5 8Fn/fVD9N8RYPM4gxc0KKMJrYt5/HrojBDyhiAj9tagHYWSMRJjylJHMv/Sjde33TZ pRWw/OJz5IilCqdu/a7b/zErgY93zaO8F/SbjHZyvBqDjDNvZYySzgG8wWhmyIO3vO Iol28XLu7Rw4p0QLtt6iiHHyMI3hfxa3X/28TIS4b+IGJqmtPN4+AKMHq1CbJnl9UC bB7e/whQTcRRA== Date: Sat, 18 Jun 2022 15:15:38 +0100 From: Jonathan Cameron To: Jakob Hauser Cc: Andy Shevchenko , Lars-Peter Clausen , Linus Walleij , Hans de Goede , linux-iio , devicetree , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 7/7] iio: magnetometer: yas530: Add YAS537 variant Message-ID: <20220618151538.3d142682@jic23-huawei> In-Reply-To: <033f64ea-4ba7-eb89-3259-688008e29989@rocketmail.com> References: <033f64ea-4ba7-eb89-3259-688008e29989@rocketmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org > > >> + /* Sanity check, is this all zeroes? */ > >> + if (memchr_inv(data, 0x00, 16) == NULL) { > > > > if (!memchr_inv(...)) > > > >> + if (FIELD_GET(GENMASK(5, 0), data[16]) == 0) > >> + dev_warn(yas5xx->dev, "calibration is blank!\n"); > >> + } > > No problem to change for YAS537. > > At YAS530/532, there is a similar line that should be changed > accordingly. However, there is a patch by Linus that was already added > to "fixes-togreg" branch in iio.git quite a while ago [5]. The patch is > not included in torvalds/linux v5.19-rc1 or -rc2 and neither in iio.git > testing branch. So I'm unsure what I should base the patchset on if I > want to change that line. I will probably choose linux-next, as the > patch is included there and in Kconfig also patch "iio: magnetometer: > ak8974: Drop dependency on OF" is included (which on the other hand > isn't included in "fixes-togreg" branch in iio.git). > > [5] > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=bb52d3691db8cf24cea049235223f3599778f264 Busy couple of weeks for me and that fix got caught up in the merge window timing before that. I should get a pull request out shortly. Jonathan