From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 516AEC43334 for ; Sat, 18 Jun 2022 17:04:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F058842F2; Sat, 18 Jun 2022 19:04:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uoHRklde"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F00D9842FA; Sat, 18 Jun 2022 19:04:09 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B2BC840DD for ; Sat, 18 Jun 2022 19:04:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf31.google.com with SMTP id 89so10674716qvc.0 for ; Sat, 18 Jun 2022 10:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wGfdtOcRyf8MupnJILR6i0w2C2ZHBqsGn9i/5PT5/ik=; b=uoHRkldeWDCBLyCK1acoYZiS3VK/urUYJC3F5oYqIOJdmtEtJ9l5dAJ39tWgJB1YIl 5XuZPrGQMNw24+21qSMmJQZMTRqErJOf370PVJItykaSuvfKA2eQo/Bk7BYI1ZEFhzeP Mhp/Fynxf8TuoIbS4vu82mHvPO172+kX7qvJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wGfdtOcRyf8MupnJILR6i0w2C2ZHBqsGn9i/5PT5/ik=; b=WL7V4dibnuwH4dh5xIFs/nwPyKvaG9L+XhguOdTtr48LFAe5Fy06loYq0/XvwiodPd N73E7hlrfHV8L+BZ5FTkZPVgP8arozpbLMKFV63NCcfK4ibyPRZUWYTqBXcTsgQRSRGB mZPyeJ4q2ztg/5Pr7YATE+2ErcTL40whU1nJCc2iV2/7HrxtX2EpA0QpfhWNQS7bOrD0 YrH5N2X9dayb8G6d4Vr0UjEluTCk5TLraZuqzpWElgWohVyF6gtF3kwQNTVmb+qJYdhV blWBkPjoBvumeKogoHTnL7Tns8ajwAuZ5sjV47wzgKBZLGvZBdS2xZhrT60pJ+9x/syz uicg== X-Gm-Message-State: AJIora9VPCxEPL+hzi0KptK5118j/S0FHjcs6GCdh4FbbAsDzELjdvwB 8EQTDTPSMwEuODQUaHz/SRBhtw== X-Google-Smtp-Source: AGRyM1vHnwaHdxE0QXNKAFfSy9/52iJsIMhfJ8fgMoF/CRKwaLCKLcvzjJsaZAn708sl1lX1u4T6lg== X-Received: by 2002:ac8:5f8e:0:b0:305:c71:3aa0 with SMTP id j14-20020ac85f8e000000b003050c713aa0mr13438405qta.152.1655571844848; Sat, 18 Jun 2022 10:04:04 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id az17-20020a05620a171100b006a6f57fe2e1sm7302503qkb.98.2022.06.18.10.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 10:04:03 -0700 (PDT) Date: Sat, 18 Jun 2022 13:04:01 -0400 From: Tom Rini To: Nishanth Menon Cc: Robert Nelson , gadiyar@ti.com, Praneeth Bajjuri , Jason Kridner , u-boot@lists.denx.de Subject: Re: [PATCH 2/3] board: ti: common: Handle the legacy eeprom address width properly Message-ID: <20220618170401.GF2484912@bill-the-cat> References: <20220617182612.12575-1-nm@ti.com> <20220617182612.12575-3-nm@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Fw7vhCbfQ9G+Xyh+" Content-Disposition: inline In-Reply-To: <20220617182612.12575-3-nm@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --Fw7vhCbfQ9G+Xyh+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 17, 2022 at 01:26:11PM -0500, Nishanth Menon wrote: > Due to supply chain issues, we are starting to see a mixture of eeprom > usage including the smaller 7-bit addressing eeproms such as 24c04 > used for eeproms. >=20 > These eeproms don't respond well to 2 byte addressing and fail the > read operation. We do have a check to ensure that we are reading the > alternate addressing size, however the valid failure prevents us > from checking at 1 byte anymore. >=20 > Rectify the same by falling through and depend on header data comparison > to ensure that we have valid data. >=20 > Signed-off-by: Nishanth Menon Reviewed-by: Tom Rini --=20 Tom --Fw7vhCbfQ9G+Xyh+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGyBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKuBYEACgkQFHw5/5Y0 tyzkTwv42P7AImOP33kkDAUYGLHZ5eGzxC1V0WQyMifbHZxSJXvL9VTgHEpKpxQw gyVK5Q9h5JMj0+fxua1ZtzyPiWMCrMm5VMOID1dwDX02Jz3mphp5/cfgC1jo1sCI NNnVBrOUdNq8wGUiqZELHzlQj4b4mU74nD0VWpSndjGJAU/SgNDwXAJdpFBKx6AZ hYcQ/9mqwimnHcEXYCnPQiJiE/5BHhHW+jZxA4roC0O+Dh91KSTUXwXdYzyaHUzS zkAmB+AYSI6D84HIK99GKRw2efDLLsT4NH7QL+TNcrUfAxEaMRDuXRvlupx7eD9t 45vnJNsDhxy9yUx/cTk+SYcEHssnRfIYnqMKyAA3Cvuf9r8YCKCuaLj8AA3v7g7Z tVnfwGtlCnqpmZn0Xx7KHnKeoBhL/eBIEh3qS1NDc405/usAPZyB8spDzwJotVGp EQYGv7MTroL8XEkqEY3/FizM+OixZrKacGaDvdn85ayZKvoHB5x80FYeoGxCVLdU hAhyJlU= =kFJS -----END PGP SIGNATURE----- --Fw7vhCbfQ9G+Xyh+--