All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
	rostedt@goodmis.org, enozhatsky@chromium.org,
	linux@rasmusvillemoes.dk, willy@infradead.org,
	Dan Williams <dan.j.williams@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	nvdimm@lists.linux.dev
Subject: [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf
Date: Sun, 19 Jun 2022 20:42:25 -0400	[thread overview]
Message-ID: <20220620004233.3805-27-kent.overstreet@gmail.com> (raw)
In-Reply-To: <20220620004233.3805-1-kent.overstreet@gmail.com>

This converts from seq_buf to printbuf. Here we're using printbuf with
an external buffer, meaning it's a direct conversion.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: nvdimm@lists.linux.dev
---
 tools/testing/nvdimm/test/ndtest.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c
index 4d1a947367..a2097955da 100644
--- a/tools/testing/nvdimm/test/ndtest.c
+++ b/tools/testing/nvdimm/test/ndtest.c
@@ -12,7 +12,7 @@
 #include <linux/ndctl.h>
 #include <nd-core.h>
 #include <linux/printk.h>
-#include <linux/seq_buf.h>
+#include <linux/printbuf.h>
 
 #include "../watermark.h"
 #include "nfit_test.h"
@@ -740,32 +740,30 @@ static ssize_t flags_show(struct device *dev,
 {
 	struct nvdimm *nvdimm = to_nvdimm(dev);
 	struct ndtest_dimm *dimm = nvdimm_provider_data(nvdimm);
-	struct seq_buf s;
+	struct printbuf s = PRINTBUF_EXTERN(buf, PAGE_SIZE);
 	u64 flags;
 
 	flags = dimm->flags;
 
-	seq_buf_init(&s, buf, PAGE_SIZE);
 	if (flags & PAPR_PMEM_UNARMED_MASK)
-		seq_buf_printf(&s, "not_armed ");
+		prt_printf(&s, "not_armed ");
 
 	if (flags & PAPR_PMEM_BAD_SHUTDOWN_MASK)
-		seq_buf_printf(&s, "flush_fail ");
+		prt_printf(&s, "flush_fail ");
 
 	if (flags & PAPR_PMEM_BAD_RESTORE_MASK)
-		seq_buf_printf(&s, "restore_fail ");
+		prt_printf(&s, "restore_fail ");
 
 	if (flags & PAPR_PMEM_SAVE_MASK)
-		seq_buf_printf(&s, "save_fail ");
+		prt_printf(&s, "save_fail ");
 
 	if (flags & PAPR_PMEM_SMART_EVENT_MASK)
-		seq_buf_printf(&s, "smart_notify ");
+		prt_printf(&s, "smart_notify ");
 
+	if (printbuf_written(&s))
+		prt_printf(&s, "\n");
 
-	if (seq_buf_used(&s))
-		seq_buf_printf(&s, "\n");
-
-	return seq_buf_used(&s);
+	return printbuf_written(&s);
 }
 static DEVICE_ATTR_RO(flags);
 
-- 
2.36.1


  parent reply	other threads:[~2022-06-20  0:43 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  0:41 [PATCH v4 00/34] Printbufs - new data structure for building strings Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 01/34] lib/printbuf: New data structure for printing strings Kent Overstreet
2022-06-20  4:44   ` David Laight
2022-06-20 15:30     ` Kent Overstreet
2022-06-20 15:53       ` David Laight
2022-06-20 16:14         ` Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 02/34] lib/string_helpers: Convert string_escape_mem() to printbuf Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 03/34] vsprintf: Convert " Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 04/34] lib/hexdump: " Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 05/34] vsprintf: %pf(%p) Kent Overstreet
2022-06-21  7:04   ` Rasmus Villemoes
2022-06-21  7:51     ` Kent Overstreet
2022-06-21  8:47       ` Rasmus Villemoes
2022-06-21 11:11     ` David Laight
2022-06-20  0:42 ` [PATCH v4 06/34] lib/string_helpers: string_get_size() now returns characters wrote Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 07/34] lib/printbuf: Heap allocation Kent Overstreet
2022-06-21  7:58   ` Rasmus Villemoes
2022-06-20  0:42 ` [PATCH v4 08/34] lib/printbuf: Tabstops, indenting Kent Overstreet
2022-06-21  8:14   ` Rasmus Villemoes
2022-06-20  0:42 ` [PATCH v4 09/34] lib/printbuf: Unit specifiers Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 10/34] lib/pretty-printers: prt_string_option(), prt_bitflags() Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 11/34] vsprintf: Improve number() Kent Overstreet
2022-06-21  8:33   ` Rasmus Villemoes
2022-06-20  0:42 ` [PATCH v4 12/34] vsprintf: prt_u64_minwidth(), prt_u64() Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 13/34] test_printf: Drop requirement that sprintf not write past nul Kent Overstreet
2022-06-21  7:19   ` Rasmus Villemoes
2022-06-21  7:52     ` Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 14/34] vsprintf: Start consolidating printf_spec handling Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 15/34] vsprintf: Refactor resource_string() Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 16/34] vsprintf: Refactor fourcc_string() Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 17/34] vsprintf: Refactor ip_addr_string() Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 18/34] vsprintf: Refactor mac_address_string() Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 19/34] vsprintf: time_and_date() no longer takes printf_spec Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 20/34] vsprintf: flags_string() " Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 21/34] vsprintf: Refactor device_node_string, fwnode_string Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 22/34] vsprintf: Refactor hex_string, bitmap_string_list, bitmap_string Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 23/34] Input/joystick/analog: Convert from seq_buf -> printbuf Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 24/34] mm/memcontrol.c: Convert to printbuf Kent Overstreet
2022-06-20 11:37   ` Michal Hocko
2022-06-20 15:13     ` Kent Overstreet
2022-06-20 15:52       ` Michal Hocko
2022-06-20  0:42 ` [PATCH v4 25/34] clk: tegra: bpmp: " Kent Overstreet
2022-06-20  0:42 ` Kent Overstreet [this message]
2022-06-24 19:32   ` [PATCH v4 26/34] tools/testing/nvdimm: " Dan Williams
2022-06-24 23:42     ` Santosh Sivaraj
2022-07-01  6:32       ` Shivaprasad G Bhat
2022-06-20  0:42 ` [PATCH v4 27/34] powerpc: " Kent Overstreet
2022-06-20  0:42   ` Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 28/34] x86/resctrl: " Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 29/34] PCI/P2PDMA: " Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 30/34] tracing: trace_events_synth: " Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 31/34] d_path: prt_path() Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 32/34] ACPI/APEI: Add missing include Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 33/34] tracing: Convert to printbuf Kent Overstreet
2022-06-20  0:42 ` [PATCH v4 34/34] Delete seq_buf Kent Overstreet
2022-06-20  4:19 ` [PATCH v4 00/34] Printbufs - new data structure for building strings David Laight
2022-06-20  4:54   ` Matthew Wilcox
2022-06-20  8:00     ` David Laight
2022-06-20 15:07   ` Kent Overstreet
2022-06-20 15:21     ` David Laight
2022-06-21  0:38     ` Joe Perches
2022-06-21  0:57       ` Kent Overstreet
2022-06-21  1:26         ` Joe Perches
2022-06-21  2:10           ` Joe Perches
2022-06-26 19:53             ` [RFC[ Alloc in vsprintf Joe Perches
2022-06-26 20:06               ` Kent Overstreet
2022-06-26 20:13                 ` Joe Perches
2022-06-26 20:19               ` Linus Torvalds
2022-06-26 20:39                 ` Joe Perches
2022-06-26 20:51                   ` Kent Overstreet
2022-06-26 21:02                     ` Joe Perches
2022-06-26 21:10                       ` Kent Overstreet
2022-06-26 20:54                   ` Linus Torvalds
2022-06-27  8:25                 ` David Laight
2022-06-28  2:56                   ` Kent Overstreet
2022-06-21  2:31           ` [PATCH v4 00/34] Printbufs - new data structure for building strings Kent Overstreet
2022-06-21  3:11   ` Kent Overstreet
2022-06-21  6:11 ` Rasmus Villemoes
2022-06-21  8:01   ` Kent Overstreet
2022-07-19 23:15 ` Steven Rostedt
2022-07-19 23:43   ` Kent Overstreet
2022-07-20  0:05     ` Steven Rostedt
2022-07-20  0:17       ` Kent Overstreet
2022-07-20  1:11         ` Steven Rostedt
2022-07-20  1:31           ` Kent Overstreet
2022-07-20  1:37             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220620004233.3805-27-kent.overstreet@gmail.com \
    --to=kent.overstreet@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=enozhatsky@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=nvdimm@lists.linux.dev \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.