From: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
To: dev@dpdk.org
Cc: gakhil@marvell.com, stable@dpdk.org,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: [PATCH v2] test/ipsec: fix performance test failure
Date: Tue, 21 Jun 2022 13:30:45 +0000 [thread overview]
Message-ID: <20220621133046.2827485-1-vladimir.medvedkin@intel.com> (raw)
In-Reply-To: <20220617171842.2788040-1-vladimir.medvedkin@intel.com>
This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct.
Before it was passed uninitialized to rte_ipsec_sa_init(),
which does not check whether prm->ipsec_xform.esn.value is greater
than sa->sqn_mask.
Bugzilla ID: 1023
Fixes: f7f3ac6dcbe2 ("test/ipsec: add performance cases")
Cc: stable@dpdk.org
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
Notes:
v2:
- fix gcc4 warnings
app/test/test_ipsec_perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_ipsec_perf.c b/app/test/test_ipsec_perf.c
index 346a851648..11de9a6aac 100644
--- a/app/test/test_ipsec_perf.c
+++ b/app/test/test_ipsec_perf.c
@@ -592,8 +592,8 @@ testsuite_teardown(void)
static int
test_libipsec_perf(void)
{
- struct ipsec_sa sa_out;
- struct ipsec_sa sa_in;
+ struct ipsec_sa sa_out = { .sa_prm = { 0 } };
+ struct ipsec_sa sa_in = { .sa_prm = { 0 } };
uint32_t i;
int ret;
--
2.25.1
next prev parent reply other threads:[~2022-06-21 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 17:18 [PATCH] test/ipsec: fix performance test failure Vladimir Medvedkin
2022-06-21 11:08 ` [EXT] " Akhil Goyal
2022-06-21 13:30 ` Vladimir Medvedkin [this message]
2022-06-21 17:23 ` [EXT] [PATCH v2] " Akhil Goyal
2022-06-23 11:18 ` Jiang, YuX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621133046.2827485-1-vladimir.medvedkin@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.