From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEEC2C43334 for ; Tue, 21 Jun 2022 19:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354094AbiFUTvL (ORCPT ); Tue, 21 Jun 2022 15:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354091AbiFUTvJ (ORCPT ); Tue, 21 Jun 2022 15:51:09 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5930624F01 for ; Tue, 21 Jun 2022 12:51:06 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3jtg-0004jI-BC; Tue, 21 Jun 2022 21:50:48 +0200 Received: from pengutronix.de (2a03-f580-87bc-d400-f72d-4f6f-99c1-0b72.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:f72d:4f6f:99c1:b72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E4FDB9BBB0; Tue, 21 Jun 2022 19:50:46 +0000 (UTC) Date: Tue, 21 Jun 2022 21:50:46 +0200 From: Marc Kleine-Budde To: Francesco Dolcini Cc: Shawn Guo , devicetree@vger.kernel.org, Krzysztof Kozlowski , Marcel Ziswiler , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Andrejs Cainikovs , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz Message-ID: <20220621195046.rnv66d2333wjmtow@pengutronix.de> References: <20220512104019.19725-1-andrejs.cainikovs@toradex.com> <20220621180749.GA22098@francesco-nb.int.toradex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cymwswx3km3vprca" Content-Disposition: inline In-Reply-To: <20220621180749.GA22098@francesco-nb.int.toradex.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cymwswx3km3vprca Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21.06.2022 20:07:49, Francesco Dolcini wrote: > Hello Shawn, just a ping on this. >=20 > Francesco >=20 > On Thu, May 12, 2022 at 12:40:19PM +0200, Andrejs Cainikovs wrote: > > Update SPI CAN controller clock to match current hardware design. > >=20 > > Signed-off-by: Andrejs Cainikovs > > --- > > arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > >=20 > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/ar= m64/boot/dts/freescale/imx8mm-verdin.dtsi > > index 0d84d29e70f1..d309bc0ab8f6 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > @@ -32,10 +32,10 @@ backlight: backlight { > > }; > > =20 > > /* Fixed clock dedicated to SPI CAN controller */ > > - clk20m: oscillator { > > + clk40m: oscillator { > > compatible =3D "fixed-clock"; > > #clock-cells =3D <0>; > > - clock-frequency =3D <20000000>; > > + clock-frequency =3D <40000000>; > > }; > > =20 > > gpio-keys { > > @@ -194,7 +194,7 @@ &ecspi3 { > > =20 > > can1: can@0 { > > compatible =3D "microchip,mcp251xfd"; > > - clocks =3D <&clk20m>; > > + clocks =3D <&clk40m>; > > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_EDGE_FALLING>; You don't want to use an edge triggered interrupt with the mcp251xfd chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --cymwswx3km3vprca Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKyIRMACgkQrX5LkNig 013PCAf9HxzrgOryxn9dqLo2SGEyP6jPeoxhZTOyjTQ00GRTYV2EaKa9f23ylcxz SeiRPsfCf8mj2DcONhgkHTxDGGCL3mp7CJLnGa5hVEVqCMqSq8D7ThFx6RflDNg+ 96Qf8F9LoQOlA+jBmR2KhSNFDzYWTKiwlGur/FrRRpvQephmk/9onhw/fzgZZkCx 2xwSEcE7hZyMy6KBOxcFEg4yVeN7t6TQuXfmzyuV/KqEEGacTwWXovoagVQFDElo poDx/GH++myJCfZgOKNh1Wrm39A6Q+YI3XLscKWgj+dMf5EdOxdl7Vw7lKpAmLI2 ElEYlv+GQ2vDD8mLXwEMuVArHhzKPA== =E6rx -----END PGP SIGNATURE----- --cymwswx3km3vprca-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2377C433EF for ; Tue, 21 Jun 2022 19:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tNvg5hX/du5Ux5XhKoA9Ri0xjxxnp2DtMW1pn7NbV9g=; b=pur+Z9yTRCOdQXzTuteox7IaCy t9Lm8GkUDnmTPSQTxH8s66lnipdajn8Jtpwpi8yvUUiUdMFTzTT0VSi/rVrLjcnEpd3QpcYqymd+5 i87gsa67disnwttPZVAZTlUCkdYAPF9f1V2Dh6m4rVVSPOo9aeQdgyny7ZskNrkFkv3g7UxLpkjcP cfYVA1Xmo5Oe3kVDPeMQilH/gKZA44KKRKkJQlnM/dyZGva/ZK0nmaV0hnGEw2yvGhI5FNpg2oWqn 1AnWBPyvl7bQwaUp4qQia4JTNEHwihdt3095kW7mKmsFXCyvTSkEd4VpXDveOsa0PJ4PKqbc0aAqC JzrdFrCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3ju0-006zM4-Sz; Tue, 21 Jun 2022 19:51:08 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3jtx-006zLE-BD for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 19:51:07 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3jtg-0004jI-BC; Tue, 21 Jun 2022 21:50:48 +0200 Received: from pengutronix.de (2a03-f580-87bc-d400-f72d-4f6f-99c1-0b72.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:f72d:4f6f:99c1:b72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E4FDB9BBB0; Tue, 21 Jun 2022 19:50:46 +0000 (UTC) Date: Tue, 21 Jun 2022 21:50:46 +0200 From: Marc Kleine-Budde To: Francesco Dolcini Cc: Shawn Guo , devicetree@vger.kernel.org, Krzysztof Kozlowski , Marcel Ziswiler , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Andrejs Cainikovs , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz Message-ID: <20220621195046.rnv66d2333wjmtow@pengutronix.de> References: <20220512104019.19725-1-andrejs.cainikovs@toradex.com> <20220621180749.GA22098@francesco-nb.int.toradex.com> MIME-Version: 1.0 In-Reply-To: <20220621180749.GA22098@francesco-nb.int.toradex.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_125105_423361_7912D174 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4991776152087862896==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4991776152087862896== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cymwswx3km3vprca" Content-Disposition: inline --cymwswx3km3vprca Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21.06.2022 20:07:49, Francesco Dolcini wrote: > Hello Shawn, just a ping on this. >=20 > Francesco >=20 > On Thu, May 12, 2022 at 12:40:19PM +0200, Andrejs Cainikovs wrote: > > Update SPI CAN controller clock to match current hardware design. > >=20 > > Signed-off-by: Andrejs Cainikovs > > --- > > arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > >=20 > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/ar= m64/boot/dts/freescale/imx8mm-verdin.dtsi > > index 0d84d29e70f1..d309bc0ab8f6 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > @@ -32,10 +32,10 @@ backlight: backlight { > > }; > > =20 > > /* Fixed clock dedicated to SPI CAN controller */ > > - clk20m: oscillator { > > + clk40m: oscillator { > > compatible =3D "fixed-clock"; > > #clock-cells =3D <0>; > > - clock-frequency =3D <20000000>; > > + clock-frequency =3D <40000000>; > > }; > > =20 > > gpio-keys { > > @@ -194,7 +194,7 @@ &ecspi3 { > > =20 > > can1: can@0 { > > compatible =3D "microchip,mcp251xfd"; > > - clocks =3D <&clk20m>; > > + clocks =3D <&clk40m>; > > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_EDGE_FALLING>; You don't want to use an edge triggered interrupt with the mcp251xfd chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --cymwswx3km3vprca Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKyIRMACgkQrX5LkNig 013PCAf9HxzrgOryxn9dqLo2SGEyP6jPeoxhZTOyjTQ00GRTYV2EaKa9f23ylcxz SeiRPsfCf8mj2DcONhgkHTxDGGCL3mp7CJLnGa5hVEVqCMqSq8D7ThFx6RflDNg+ 96Qf8F9LoQOlA+jBmR2KhSNFDzYWTKiwlGur/FrRRpvQephmk/9onhw/fzgZZkCx 2xwSEcE7hZyMy6KBOxcFEg4yVeN7t6TQuXfmzyuV/KqEEGacTwWXovoagVQFDElo poDx/GH++myJCfZgOKNh1Wrm39A6Q+YI3XLscKWgj+dMf5EdOxdl7Vw7lKpAmLI2 ElEYlv+GQ2vDD8mLXwEMuVArHhzKPA== =E6rx -----END PGP SIGNATURE----- --cymwswx3km3vprca-- --===============4991776152087862896== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4991776152087862896==--