All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PULL 01/19] aspeed: Remove fake RTC device on ast2500-evb
Date: Wed, 22 Jun 2022 11:55:02 +0200	[thread overview]
Message-ID: <20220622095520.3683321-2-clg@kaod.org> (raw)
In-Reply-To: <20220622095520.3683321-1-clg@kaod.org>

The board has no such device. It might have been useful for some tests
in the past, it's not anymore and the same can be achieved on the
command line.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/arm/aspeed.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 98dc185acd9a..c49772e2eb59 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -519,10 +519,6 @@ static void ast2500_evb_i2c_init(AspeedMachineState *bmc)
     /* The AST2500 EVB expects a LM75 but a TMP105 is compatible */
     i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7),
                      TYPE_TMP105, 0x4d);
-
-    /* The AST2500 EVB does not have an RTC. Let's pretend that one is
-     * plugged on the I2C bus header */
-    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 11), "ds1338", 0x32);
 }
 
 static void ast2600_evb_i2c_init(AspeedMachineState *bmc)
-- 
2.35.3



  reply	other threads:[~2022-06-22  9:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  9:55 [PULL 00/19] aspeed queue Cédric Le Goater
2022-06-22  9:55 ` Cédric Le Goater [this message]
2022-06-22  9:55 ` [PULL 02/19] test/avocado/machine_aspeed.py: Move OpenBMC tests Cédric Le Goater
2022-06-22  9:55 ` [PULL 03/19] test/avocado/machine_aspeed.py: Add tests using buildroot images Cédric Le Goater
2022-06-22  9:55 ` [PULL 04/19] test/avocado/machine_aspeed.py: Add I2C tests to ast2500-evb Cédric Le Goater
2022-06-22  9:55 ` [PULL 05/19] test/avocado/machine_aspeed.py: Add I2C tests to ast2600-evb Cédric Le Goater
2022-06-22  9:55 ` [PULL 06/19] test/avocado/machine_aspeed.py: Add an I2C RTC test Cédric Le Goater
2022-06-22  9:55 ` [PULL 07/19] hw/registerfields: Add shared fields macros Cédric Le Goater
2022-06-22  9:55 ` [PULL 08/19] aspeed: i2c: Migrate to registerfields API Cédric Le Goater
2022-06-22  9:55 ` [PULL 09/19] aspeed: i2c: Use reg array instead of individual vars Cédric Le Goater
2022-06-22  9:55 ` [PULL 10/19] aspeed: i2c: Add new mode support Cédric Le Goater
2022-06-22  9:55 ` [PULL 11/19] aspeed: i2c: Add PKT_DONE IRQ to trace Cédric Le Goater
2022-06-22  9:55 ` [PULL 12/19] aspeed: i2c: Move regs and helpers to header file Cédric Le Goater
2022-06-22  9:55 ` [PULL 13/19] aspeed/i2c: Add ast1030 controller models Cédric Le Goater
2022-06-22  9:55 ` [PULL 14/19] aspeed: Add I2C buses to AST1030 model Cédric Le Goater
2022-06-22  9:55 ` [PULL 15/19] hw/i2c/aspeed: rework raise interrupt trace event Cédric Le Goater
2022-06-22  9:55 ` [PULL 16/19] hw/i2c/aspeed: add DEV_ADDR in old register mode Cédric Le Goater
2022-06-22  9:55 ` [PULL 17/19] aspeed/i2c: Enable SLAVE_ADDR_RX_MATCH always Cédric Le Goater
2022-06-22  9:55 ` [PULL 18/19] aspeed/hace: Add missing newlines to unimp messages Cédric Le Goater
2022-06-22  9:55 ` [PULL 19/19] hw: m25p80: fixing individual test failure when tests are running in isolation Cédric Le Goater
2022-06-22 15:52 ` [PULL 00/19] aspeed queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220622095520.3683321-2-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.