From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51CCEC43334 for ; Thu, 23 Jun 2022 06:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=URjVvC7P5TBPmqCj/Mhbq08/2Z2rUvpmsSxVHyG4mJk=; b=rDzys2rG6mGnp7wMAZqJoG1yzb 0HGr26ljp7cEPufvgwsD8aPTeERHDfQoZ65/Q3FfwpWXdq2jEqgR/neOvxkUIseyyk5EEuUfm/54C /ACIYtI4CFJXxkiTDU0XMf6nChdaLCCSZl4DXM3j/HkJgfMcRXZzsLf40SjXd2+VF03sdAlPoC0Sp gvhCZm8voBpmH5aQ1fPOEfOjeN+hS2diAmCVLvIQ53T62YSg13mzFMqTqd83HBIUNmmd/y1svOjgr Fj39A3gBfr1PpqOD87y2jFSHuQfyx+arMzaH6QsQ5QvNG2Nc/T2uhz8x78MocFoiXvbxb6v/u6+V/ y1PbwNXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4G9w-00DdQG-8L; Thu, 23 Jun 2022 06:17:44 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4G9t-00DdMq-5X for linux-nvme@lists.infradead.org; Thu, 23 Jun 2022 06:17:42 +0000 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 04E8921C5E; Thu, 23 Jun 2022 06:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655965056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=URjVvC7P5TBPmqCj/Mhbq08/2Z2rUvpmsSxVHyG4mJk=; b=YJnAa9wQ7PMa9EGJvPBw93iDbrSD+yEaSYtgbm92fVxxVNIH8ULG//iAhhkC2qO2K0/sR3 n2VfQAFDMZHtovM6xO/O6IEowRLIMehZl6DTkMVlM7SphEE7+LSM+bRvz/gxY06Fc6ixqm rbN6vi7yeuQ2cuft4AqMvBA2eeNXP50= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655965056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=URjVvC7P5TBPmqCj/Mhbq08/2Z2rUvpmsSxVHyG4mJk=; b=aE8lvEJbTODaDercR4WPqI2MP/fx+27FSk8tROMKA5jF22slt5pQsOOfBHnOeOGTqohtV1 hyt+DnS7kyg0UoAQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id E9DEC2C14F; Thu, 23 Jun 2022 06:17:35 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 1E9BB5194D72; Thu, 23 Jun 2022 08:17:35 +0200 (CEST) From: Hannes Reinecke To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , linux-nvme@lists.infradead.org, Hannes Reinecke , Chaitanya Kulkarni , Himanshu Madhani Subject: [PATCH 05/11] nvme-fabrics: decode 'authentication required' connect error Date: Thu, 23 Jun 2022 08:17:24 +0200 Message-Id: <20220623061730.51490-6-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20220623061730.51490-1-hare@suse.de> References: <20220623061730.51490-1-hare@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_231741_422103_C7569FF7 X-CRM114-Status: UNSURE ( 8.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we should be decoding this error, too. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Reviewed-by: Himanshu Madhani --- drivers/nvme/host/fabrics.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index 0a0512300f1b..e4b1520862d8 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -331,6 +331,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, dev_err(ctrl->device, "Connect command failed: host path error\n"); break; + case NVME_SC_AUTH_REQUIRED: + dev_err(ctrl->device, + "Connect command failed: authentication required\n"); + break; default: dev_err(ctrl->device, "Connect command failed, error wo/DNR bit: %d\n", -- 2.29.2