From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE8CECCA473 for ; Fri, 24 Jun 2022 07:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230271AbiFXHA1 (ORCPT ); Fri, 24 Jun 2022 03:00:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbiFXHAY (ORCPT ); Fri, 24 Jun 2022 03:00:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6A28769270 for ; Fri, 24 Jun 2022 00:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656054022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wmJan+T8jkPhz0Jx0HS+GqAkBjBvRA/O1PfxaSokA/k=; b=NyHCQyoPKW4PTip4n4FFTTjsk+AkhOupO2tpMY4Np7kS3dVm+rGrJMTqGiWvoc+wIMUD8K 9jla6Je3Ev5F61bllpvv44BLwhWarkuUtpay2ETRzAAaQtYmVS1gJxal4E2dfqnfEMJo5l iRoG/ylAU3LiXb0X3e0e57YW9NnELMQ= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-T6zt0nfuMx6WJmvR0yGVBw-1; Fri, 24 Jun 2022 03:00:21 -0400 X-MC-Unique: T6zt0nfuMx6WJmvR0yGVBw-1 Received: by mail-ej1-f70.google.com with SMTP id ne36-20020a1709077ba400b00722d5f547d8so462309ejc.19 for ; Fri, 24 Jun 2022 00:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wmJan+T8jkPhz0Jx0HS+GqAkBjBvRA/O1PfxaSokA/k=; b=EQQ3Gv28HPMnwg2qJNapRjgKndmDcpGXNNWT1Pma0iQq4YR+gDg4Qc8RfjQxo7EYoZ HMDrKOrGz6RUJ84J86j6tIu9wK0K6PxWpVy6pZJvlsHZNsiCT+8ymbxTnoOzBdQnleAE bWZvVtJqbIgK0rzHOTOwObxlsy8Fi8q8iNxkJ7w7fHwCnD7Na9rBtDMijqe+EuHUEMrS dQ7Zleqcx7sOpymBBmuHN2WiVlT5RBRfSV9xvwJNU5gT66lSX2orMtKd4rTOzjnqZfd2 mpx2fTbaU8kJqmy689ek2zb7VlIM8bQVOSJca/dsC/xL8NOsflTc22CSPXaedK4/BLYg DV0Q== X-Gm-Message-State: AJIora+K0/1pyyjFkEQOm4wWxHuYC7yQahgayHQLFJ1+8duLRowYUwCU 0R6y1AsTOZg4r4lLaAH+ei4+W3FE1fs58/HzhYW7mZWX1AsKatlw31CpC9bQq/5c/R8pPvlbnSy yIiYv4zW8YNVS4EQ0ADZNgjBJGVKK4Q== X-Received: by 2002:a17:906:51de:b0:722:e9a7:83de with SMTP id v30-20020a17090651de00b00722e9a783demr11981763ejk.130.1656054020052; Fri, 24 Jun 2022 00:00:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vuZPrYT6oN35kbqkreO6xutvaC1wAQFjbV9H/fxZNSgI7sAYj2ZRT+vtMwhuJY/8e+TdPqZg== X-Received: by 2002:a17:906:51de:b0:722:e9a7:83de with SMTP id v30-20020a17090651de00b00722e9a783demr11981742ejk.130.1656054019815; Fri, 24 Jun 2022 00:00:19 -0700 (PDT) Received: from redhat.com ([2.55.188.216]) by smtp.gmail.com with ESMTPSA id n22-20020a1709067b5600b00722ea7a7febsm576805ejo.194.2022.06.24.00.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 00:00:19 -0700 (PDT) Date: Fri, 24 Jun 2022 03:00:12 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: virtualization@lists.linux-foundation.org, Richard Weinberger , Anton Ivanov , Johannes Berg , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com Subject: Re: [PATCH v10 00/41] virtio pci support VIRTIO_F_RING_RESET Message-ID: <20220624025954-mutt-send-email-mst@kernel.org> References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri, Jun 24, 2022 at 10:55:40AM +0800, Xuan Zhuo wrote: > The virtio spec already supports the virtio queue reset function. This patch set > is to add this function to the kernel. The relevant virtio spec information is > here: > > https://github.com/oasis-tcs/virtio-spec/issues/124 > https://github.com/oasis-tcs/virtio-spec/issues/139 > > Also regarding MMIO support for queue reset, I plan to support it after this > patch is passed. > > This patch set implements the refactoring of vring. Finally, the > virtuque_resize() interface is provided based on the reset function of the > transport layer. > > Test environment: > Host: 4.19.91 > Qemu: QEMU emulator version 6.2.50 (with vq reset support) > Test Cmd: ethtool -G eth1 rx $1 tx $2; ethtool -g eth1 > > The default is split mode, modify Qemu virtio-net to add PACKED feature to test > packed mode. > > Qemu code: > https://github.com/fengidri/qemu/compare/89f3bfa3265554d1d591ee4d7f1197b6e3397e84...master Pls rebase on top of my latest tree, there are some conflicts. > In order to simplify the review of this patch set, the function of reusing > the old buffers after resize will be introduced in subsequent patch sets. > > Please review. Thanks. > > v10: > 1. on top of the harden vring IRQ > 2. factor out split and packed from struct vring_virtqueue > 3. some suggest from @Jason Wang > > v9: > 1. Provide a virtqueue_resize() interface directly > 2. A patch set including vring resize, virtio pci reset, virtio-net resize > 3. No more separate structs > > v8: > 1. Provide a virtqueue_reset() interface directly > 2. Split the two patch sets, this is the first part > 3. Add independent allocation helper for allocating state, extra > > v7: > 1. fix #6 subject typo > 2. fix #6 ring_size_in_bytes is uninitialized > 3. check by: make W=12 > > v6: > 1. virtio_pci: use synchronize_irq(irq) to sync the irq callbacks > 2. Introduce virtqueue_reset_vring() to implement the reset of vring during > the reset process. May use the old vring if num of the vq not change. > 3. find_vqs() support sizes to special the max size of each vq > > v5: > 1. add virtio-net support set_ringparam > > v4: > 1. just the code of virtio, without virtio-net > 2. Performing reset on a queue is divided into these steps: > 1. reset_vq: reset one vq > 2. recycle the buffer from vq by virtqueue_detach_unused_buf() > 3. release the ring of the vq by vring_release_virtqueue() > 4. enable_reset_vq: re-enable the reset queue > 3. Simplify the parameters of enable_reset_vq() > 4. add container structures for virtio_pci_common_cfg > > v3: > 1. keep vq, irq unreleased > > *** BLURB HERE *** > > Xuan Zhuo (41): > remoteproc: rename len of rpoc_vring to num > virtio: add helper virtqueue_get_vring_max_size() > virtio: struct virtio_config_ops add callbacks for queue_reset > virtio_ring: update the document of the virtqueue_detach_unused_buf > for queue reset > virtio_ring: remove the arg vq of vring_alloc_desc_extra() > virtio_ring: extract the logic of freeing vring > virtio_ring: split vring_virtqueue > virtio_ring: introduce virtqueue_init() > virtio_ring: split: introduce vring_free_split() > virtio_ring: split: extract the logic of alloc queue > virtio_ring: split: extract the logic of alloc state and extra > virtio_ring: split: extract the logic of attach vring > virtio_ring: split: extract the logic of vring init > virtio_ring: split: introduce virtqueue_reinit_split() > virtio_ring: split: reserve vring_align, may_reduce_num > virtio_ring: split: introduce virtqueue_resize_split() > virtio_ring: packed: introduce vring_free_packed > virtio_ring: packed: extract the logic of alloc queue > virtio_ring: packed: extract the logic of alloc state and extra > virtio_ring: packed: extract the logic of attach vring > virtio_ring: packed: extract the logic of vring init > virtio_ring: packed: introduce virtqueue_reinit_packed() > virtio_ring: packed: introduce virtqueue_resize_packed() > virtio_ring: introduce virtqueue_resize() > virtio_pci: struct virtio_pci_common_cfg add queue_notify_data > virtio: queue_reset: add VIRTIO_F_RING_RESET > virtio: allow to unbreak/break virtqueue individually > virtio_pci: update struct virtio_pci_common_cfg > virtio_pci: introduce helper to get/set queue reset > virtio_pci: extract the logic of active vq for modern pci > virtio_pci: support VIRTIO_F_RING_RESET > virtio: find_vqs() add arg sizes > virtio_pci: support the arg sizes of find_vqs() > virtio_mmio: support the arg sizes of find_vqs() > virtio: add helper virtio_find_vqs_ctx_size() > virtio_net: set the default max ring size by find_vqs() > virtio_net: get ringparam by virtqueue_get_vring_max_size() > virtio_net: split free_unused_bufs() > virtio_net: support rx queue resize > virtio_net: support tx queue resize > virtio_net: support set_ringparam > > arch/um/drivers/virtio_uml.c | 3 +- > drivers/net/virtio_net.c | 209 +++++- > drivers/platform/mellanox/mlxbf-tmfifo.c | 3 + > drivers/remoteproc/remoteproc_core.c | 4 +- > drivers/remoteproc/remoteproc_virtio.c | 13 +- > drivers/s390/virtio/virtio_ccw.c | 4 + > drivers/virtio/virtio_mmio.c | 11 +- > drivers/virtio/virtio_pci_common.c | 32 +- > drivers/virtio/virtio_pci_common.h | 3 +- > drivers/virtio/virtio_pci_legacy.c | 8 +- > drivers/virtio/virtio_pci_modern.c | 157 ++++- > drivers/virtio/virtio_pci_modern_dev.c | 39 ++ > drivers/virtio/virtio_ring.c | 794 +++++++++++++++++------ > drivers/virtio/virtio_vdpa.c | 3 + > include/linux/remoteproc.h | 4 +- > include/linux/virtio.h | 9 + > include/linux/virtio_config.h | 38 +- > include/linux/virtio_pci_modern.h | 2 + > include/uapi/linux/virtio_config.h | 7 +- > include/uapi/linux/virtio_pci.h | 14 + > 20 files changed, 1063 insertions(+), 294 deletions(-) > > -- > 2.31.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F4D7C433EF for ; Fri, 24 Jun 2022 07:00:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 03FAF40CD1; Fri, 24 Jun 2022 07:00:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 03FAF40CD1 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NyHCQyoP X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Py4hlFmskPSf; Fri, 24 Jun 2022 07:00:27 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6494D4046B; Fri, 24 Jun 2022 07:00:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6494D4046B Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3E7C0C0039; Fri, 24 Jun 2022 07:00:26 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1B940C002D for ; Fri, 24 Jun 2022 07:00:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E898E40C76 for ; Fri, 24 Jun 2022 07:00:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E898E40C76 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1bvxmX5fS8M5 for ; Fri, 24 Jun 2022 07:00:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B82304046B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id B82304046B for ; Fri, 24 Jun 2022 07:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656054022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wmJan+T8jkPhz0Jx0HS+GqAkBjBvRA/O1PfxaSokA/k=; b=NyHCQyoPKW4PTip4n4FFTTjsk+AkhOupO2tpMY4Np7kS3dVm+rGrJMTqGiWvoc+wIMUD8K 9jla6Je3Ev5F61bllpvv44BLwhWarkuUtpay2ETRzAAaQtYmVS1gJxal4E2dfqnfEMJo5l iRoG/ylAU3LiXb0X3e0e57YW9NnELMQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-404--S2Wpzo7Pzq2ySuldnRWOw-1; Fri, 24 Jun 2022 03:00:21 -0400 X-MC-Unique: -S2Wpzo7Pzq2ySuldnRWOw-1 Received: by mail-ej1-f72.google.com with SMTP id sg40-20020a170907a42800b00722faf0aacbso483450ejc.3 for ; Fri, 24 Jun 2022 00:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wmJan+T8jkPhz0Jx0HS+GqAkBjBvRA/O1PfxaSokA/k=; b=i6yl8lrT43YsLNJ3emnCAJp8FzseL39uXpKK4WejrYs+XvBwBr44/aNrkZsnYmAkWj F/0gVY1+gGrWjhKhSpaYgPV/aq8wRsRNHJAQXc4n65jplVLvSHAkQZfOEp/U1z2aY55v i9LhZNcGPL5RX/nqd5uS5ZwhZV3j/HqWEQjXEhq6bM1y7c/xGvhRApNN7+MbLEXa6IH3 K1druy607qy95yCrTRiCvSnPQH7pyyWQFS8ealnYKufy82CX2JKVPfSjC3ZNc2+pFjFt n+y6Njpr4V3G242WosEReEKvW6jW1UWSfn3TqQRsZpe4OK5uyveZwxER6KnDkzHYhx2W udlg== X-Gm-Message-State: AJIora9Sc1/XEBUhfkWy0Tgn4sTl+2N4/VOOK7lzaUoI9wGbYl70WPrB bftBtmymFa7Qv6VNh7wEgQdaQwqGqErKbgQDwikomAi4mB5EdJR2hViEy0R8FgoSOEQDYQsvawU w7b4uyEvmke1X7YYyVCwVMRw2psl8+CpWbS29CrYHDg== X-Received: by 2002:a17:906:51de:b0:722:e9a7:83de with SMTP id v30-20020a17090651de00b00722e9a783demr11981774ejk.130.1656054020053; Fri, 24 Jun 2022 00:00:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vuZPrYT6oN35kbqkreO6xutvaC1wAQFjbV9H/fxZNSgI7sAYj2ZRT+vtMwhuJY/8e+TdPqZg== X-Received: by 2002:a17:906:51de:b0:722:e9a7:83de with SMTP id v30-20020a17090651de00b00722e9a783demr11981742ejk.130.1656054019815; Fri, 24 Jun 2022 00:00:19 -0700 (PDT) Received: from redhat.com ([2.55.188.216]) by smtp.gmail.com with ESMTPSA id n22-20020a1709067b5600b00722ea7a7febsm576805ejo.194.2022.06.24.00.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 00:00:19 -0700 (PDT) Date: Fri, 24 Jun 2022 03:00:12 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Subject: Re: [PATCH v10 00/41] virtio pci support VIRTIO_F_RING_RESET Message-ID: <20220624025954-mutt-send-email-mst@kernel.org> References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Vadim Pasternak , linux-remoteproc@vger.kernel.org, Alexei Starovoitov , virtualization@lists.linux-foundation.org, Eric Dumazet , Alexander Gordeev , Anton Ivanov , linux-s390@vger.kernel.org, kvm@vger.kernel.org, Daniel Borkmann , Richard Weinberger , Vincent Whitchurch , John Fastabend , Halil Pasic , Jakub Kicinski , platform-driver-x86@vger.kernel.org, Eric Farman , Jesper Dangaard Brouer , Vasily Gorbik , kangjie.xu@linux.alibaba.com, Heiko Carstens , linux-um@lists.infradead.org, Mark Gross , Hans de Goede , Bjorn Andersson , bpf@vger.kernel.org, Paolo Abeni , Mathieu Poirier , netdev@vger.kernel.org, Cornelia Huck , Sven Schnelle , Johannes Berg , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Fri, Jun 24, 2022 at 10:55:40AM +0800, Xuan Zhuo wrote: > The virtio spec already supports the virtio queue reset function. This patch set > is to add this function to the kernel. The relevant virtio spec information is > here: > > https://github.com/oasis-tcs/virtio-spec/issues/124 > https://github.com/oasis-tcs/virtio-spec/issues/139 > > Also regarding MMIO support for queue reset, I plan to support it after this > patch is passed. > > This patch set implements the refactoring of vring. Finally, the > virtuque_resize() interface is provided based on the reset function of the > transport layer. > > Test environment: > Host: 4.19.91 > Qemu: QEMU emulator version 6.2.50 (with vq reset support) > Test Cmd: ethtool -G eth1 rx $1 tx $2; ethtool -g eth1 > > The default is split mode, modify Qemu virtio-net to add PACKED feature to test > packed mode. > > Qemu code: > https://github.com/fengidri/qemu/compare/89f3bfa3265554d1d591ee4d7f1197b6e3397e84...master Pls rebase on top of my latest tree, there are some conflicts. > In order to simplify the review of this patch set, the function of reusing > the old buffers after resize will be introduced in subsequent patch sets. > > Please review. Thanks. > > v10: > 1. on top of the harden vring IRQ > 2. factor out split and packed from struct vring_virtqueue > 3. some suggest from @Jason Wang > > v9: > 1. Provide a virtqueue_resize() interface directly > 2. A patch set including vring resize, virtio pci reset, virtio-net resize > 3. No more separate structs > > v8: > 1. Provide a virtqueue_reset() interface directly > 2. Split the two patch sets, this is the first part > 3. Add independent allocation helper for allocating state, extra > > v7: > 1. fix #6 subject typo > 2. fix #6 ring_size_in_bytes is uninitialized > 3. check by: make W=12 > > v6: > 1. virtio_pci: use synchronize_irq(irq) to sync the irq callbacks > 2. Introduce virtqueue_reset_vring() to implement the reset of vring during > the reset process. May use the old vring if num of the vq not change. > 3. find_vqs() support sizes to special the max size of each vq > > v5: > 1. add virtio-net support set_ringparam > > v4: > 1. just the code of virtio, without virtio-net > 2. Performing reset on a queue is divided into these steps: > 1. reset_vq: reset one vq > 2. recycle the buffer from vq by virtqueue_detach_unused_buf() > 3. release the ring of the vq by vring_release_virtqueue() > 4. enable_reset_vq: re-enable the reset queue > 3. Simplify the parameters of enable_reset_vq() > 4. add container structures for virtio_pci_common_cfg > > v3: > 1. keep vq, irq unreleased > > *** BLURB HERE *** > > Xuan Zhuo (41): > remoteproc: rename len of rpoc_vring to num > virtio: add helper virtqueue_get_vring_max_size() > virtio: struct virtio_config_ops add callbacks for queue_reset > virtio_ring: update the document of the virtqueue_detach_unused_buf > for queue reset > virtio_ring: remove the arg vq of vring_alloc_desc_extra() > virtio_ring: extract the logic of freeing vring > virtio_ring: split vring_virtqueue > virtio_ring: introduce virtqueue_init() > virtio_ring: split: introduce vring_free_split() > virtio_ring: split: extract the logic of alloc queue > virtio_ring: split: extract the logic of alloc state and extra > virtio_ring: split: extract the logic of attach vring > virtio_ring: split: extract the logic of vring init > virtio_ring: split: introduce virtqueue_reinit_split() > virtio_ring: split: reserve vring_align, may_reduce_num > virtio_ring: split: introduce virtqueue_resize_split() > virtio_ring: packed: introduce vring_free_packed > virtio_ring: packed: extract the logic of alloc queue > virtio_ring: packed: extract the logic of alloc state and extra > virtio_ring: packed: extract the logic of attach vring > virtio_ring: packed: extract the logic of vring init > virtio_ring: packed: introduce virtqueue_reinit_packed() > virtio_ring: packed: introduce virtqueue_resize_packed() > virtio_ring: introduce virtqueue_resize() > virtio_pci: struct virtio_pci_common_cfg add queue_notify_data > virtio: queue_reset: add VIRTIO_F_RING_RESET > virtio: allow to unbreak/break virtqueue individually > virtio_pci: update struct virtio_pci_common_cfg > virtio_pci: introduce helper to get/set queue reset > virtio_pci: extract the logic of active vq for modern pci > virtio_pci: support VIRTIO_F_RING_RESET > virtio: find_vqs() add arg sizes > virtio_pci: support the arg sizes of find_vqs() > virtio_mmio: support the arg sizes of find_vqs() > virtio: add helper virtio_find_vqs_ctx_size() > virtio_net: set the default max ring size by find_vqs() > virtio_net: get ringparam by virtqueue_get_vring_max_size() > virtio_net: split free_unused_bufs() > virtio_net: support rx queue resize > virtio_net: support tx queue resize > virtio_net: support set_ringparam > > arch/um/drivers/virtio_uml.c | 3 +- > drivers/net/virtio_net.c | 209 +++++- > drivers/platform/mellanox/mlxbf-tmfifo.c | 3 + > drivers/remoteproc/remoteproc_core.c | 4 +- > drivers/remoteproc/remoteproc_virtio.c | 13 +- > drivers/s390/virtio/virtio_ccw.c | 4 + > drivers/virtio/virtio_mmio.c | 11 +- > drivers/virtio/virtio_pci_common.c | 32 +- > drivers/virtio/virtio_pci_common.h | 3 +- > drivers/virtio/virtio_pci_legacy.c | 8 +- > drivers/virtio/virtio_pci_modern.c | 157 ++++- > drivers/virtio/virtio_pci_modern_dev.c | 39 ++ > drivers/virtio/virtio_ring.c | 794 +++++++++++++++++------ > drivers/virtio/virtio_vdpa.c | 3 + > include/linux/remoteproc.h | 4 +- > include/linux/virtio.h | 9 + > include/linux/virtio_config.h | 38 +- > include/linux/virtio_pci_modern.h | 2 + > include/uapi/linux/virtio_config.h | 7 +- > include/uapi/linux/virtio_pci.h | 14 + > 20 files changed, 1063 insertions(+), 294 deletions(-) > > -- > 2.31.0 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4dIl-000wif-GM for linux-um@lists.infradead.org; Fri, 24 Jun 2022 07:00:25 +0000 Received: by mail-ed1-f69.google.com with SMTP id m8-20020a056402430800b00435cfa7c6d1so1210776edc.9 for ; Fri, 24 Jun 2022 00:00:21 -0700 (PDT) Date: Fri, 24 Jun 2022 03:00:12 -0400 From: "Michael S. Tsirkin" Subject: Re: [PATCH v10 00/41] virtio pci support VIRTIO_F_RING_RESET Message-ID: <20220624025954-mutt-send-email-mst@kernel.org> References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Xuan Zhuo Cc: virtualization@lists.linux-foundation.org, Richard Weinberger , Anton Ivanov , Johannes Berg , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com On Fri, Jun 24, 2022 at 10:55:40AM +0800, Xuan Zhuo wrote: > The virtio spec already supports the virtio queue reset function. This patch set > is to add this function to the kernel. The relevant virtio spec information is > here: > > https://github.com/oasis-tcs/virtio-spec/issues/124 > https://github.com/oasis-tcs/virtio-spec/issues/139 > > Also regarding MMIO support for queue reset, I plan to support it after this > patch is passed. > > This patch set implements the refactoring of vring. Finally, the > virtuque_resize() interface is provided based on the reset function of the > transport layer. > > Test environment: > Host: 4.19.91 > Qemu: QEMU emulator version 6.2.50 (with vq reset support) > Test Cmd: ethtool -G eth1 rx $1 tx $2; ethtool -g eth1 > > The default is split mode, modify Qemu virtio-net to add PACKED feature to test > packed mode. > > Qemu code: > https://github.com/fengidri/qemu/compare/89f3bfa3265554d1d591ee4d7f1197b6e3397e84...master Pls rebase on top of my latest tree, there are some conflicts. > In order to simplify the review of this patch set, the function of reusing > the old buffers after resize will be introduced in subsequent patch sets. > > Please review. Thanks. > > v10: > 1. on top of the harden vring IRQ > 2. factor out split and packed from struct vring_virtqueue > 3. some suggest from @Jason Wang > > v9: > 1. Provide a virtqueue_resize() interface directly > 2. A patch set including vring resize, virtio pci reset, virtio-net resize > 3. No more separate structs > > v8: > 1. Provide a virtqueue_reset() interface directly > 2. Split the two patch sets, this is the first part > 3. Add independent allocation helper for allocating state, extra > > v7: > 1. fix #6 subject typo > 2. fix #6 ring_size_in_bytes is uninitialized > 3. check by: make W=12 > > v6: > 1. virtio_pci: use synchronize_irq(irq) to sync the irq callbacks > 2. Introduce virtqueue_reset_vring() to implement the reset of vring during > the reset process. May use the old vring if num of the vq not change. > 3. find_vqs() support sizes to special the max size of each vq > > v5: > 1. add virtio-net support set_ringparam > > v4: > 1. just the code of virtio, without virtio-net > 2. Performing reset on a queue is divided into these steps: > 1. reset_vq: reset one vq > 2. recycle the buffer from vq by virtqueue_detach_unused_buf() > 3. release the ring of the vq by vring_release_virtqueue() > 4. enable_reset_vq: re-enable the reset queue > 3. Simplify the parameters of enable_reset_vq() > 4. add container structures for virtio_pci_common_cfg > > v3: > 1. keep vq, irq unreleased > > *** BLURB HERE *** > > Xuan Zhuo (41): > remoteproc: rename len of rpoc_vring to num > virtio: add helper virtqueue_get_vring_max_size() > virtio: struct virtio_config_ops add callbacks for queue_reset > virtio_ring: update the document of the virtqueue_detach_unused_buf > for queue reset > virtio_ring: remove the arg vq of vring_alloc_desc_extra() > virtio_ring: extract the logic of freeing vring > virtio_ring: split vring_virtqueue > virtio_ring: introduce virtqueue_init() > virtio_ring: split: introduce vring_free_split() > virtio_ring: split: extract the logic of alloc queue > virtio_ring: split: extract the logic of alloc state and extra > virtio_ring: split: extract the logic of attach vring > virtio_ring: split: extract the logic of vring init > virtio_ring: split: introduce virtqueue_reinit_split() > virtio_ring: split: reserve vring_align, may_reduce_num > virtio_ring: split: introduce virtqueue_resize_split() > virtio_ring: packed: introduce vring_free_packed > virtio_ring: packed: extract the logic of alloc queue > virtio_ring: packed: extract the logic of alloc state and extra > virtio_ring: packed: extract the logic of attach vring > virtio_ring: packed: extract the logic of vring init > virtio_ring: packed: introduce virtqueue_reinit_packed() > virtio_ring: packed: introduce virtqueue_resize_packed() > virtio_ring: introduce virtqueue_resize() > virtio_pci: struct virtio_pci_common_cfg add queue_notify_data > virtio: queue_reset: add VIRTIO_F_RING_RESET > virtio: allow to unbreak/break virtqueue individually > virtio_pci: update struct virtio_pci_common_cfg > virtio_pci: introduce helper to get/set queue reset > virtio_pci: extract the logic of active vq for modern pci > virtio_pci: support VIRTIO_F_RING_RESET > virtio: find_vqs() add arg sizes > virtio_pci: support the arg sizes of find_vqs() > virtio_mmio: support the arg sizes of find_vqs() > virtio: add helper virtio_find_vqs_ctx_size() > virtio_net: set the default max ring size by find_vqs() > virtio_net: get ringparam by virtqueue_get_vring_max_size() > virtio_net: split free_unused_bufs() > virtio_net: support rx queue resize > virtio_net: support tx queue resize > virtio_net: support set_ringparam > > arch/um/drivers/virtio_uml.c | 3 +- > drivers/net/virtio_net.c | 209 +++++- > drivers/platform/mellanox/mlxbf-tmfifo.c | 3 + > drivers/remoteproc/remoteproc_core.c | 4 +- > drivers/remoteproc/remoteproc_virtio.c | 13 +- > drivers/s390/virtio/virtio_ccw.c | 4 + > drivers/virtio/virtio_mmio.c | 11 +- > drivers/virtio/virtio_pci_common.c | 32 +- > drivers/virtio/virtio_pci_common.h | 3 +- > drivers/virtio/virtio_pci_legacy.c | 8 +- > drivers/virtio/virtio_pci_modern.c | 157 ++++- > drivers/virtio/virtio_pci_modern_dev.c | 39 ++ > drivers/virtio/virtio_ring.c | 794 +++++++++++++++++------ > drivers/virtio/virtio_vdpa.c | 3 + > include/linux/remoteproc.h | 4 +- > include/linux/virtio.h | 9 + > include/linux/virtio_config.h | 38 +- > include/linux/virtio_pci_modern.h | 2 + > include/uapi/linux/virtio_config.h | 7 +- > include/uapi/linux/virtio_pci.h | 14 + > 20 files changed, 1063 insertions(+), 294 deletions(-) > > -- > 2.31.0 _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um