From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A023C43334 for ; Fri, 24 Jun 2022 17:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbiFXRR7 (ORCPT ); Fri, 24 Jun 2022 13:17:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbiFXRR5 (ORCPT ); Fri, 24 Jun 2022 13:17:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF97B80 for ; Fri, 24 Jun 2022 10:17:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5498B82AC8 for ; Fri, 24 Jun 2022 17:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68E79C34114; Fri, 24 Jun 2022 17:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656091072; bh=KhHu6RjvU6nUOfug66RM/DBmrS6LdvU77ltvI9ZXcMw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=muWwRQt34LiXgVi8Xu2nEOEVGZTFxqTSVpabClmaiKmX2mp4NXv6gXcJ0AxlNRpZW kA/APyGkRW4phreY2GsgF0sVDAbXWU3pWMan7PN1NUM6mf0Hg+MJy+YJlgtfrgverR HsTfrOKaS9COugjGQnpf3oQXrjsCs7ws711FTo5akIHsNqUvvQnG05Blk01WrrIs/I 1LxhMxfKrbI52RHwc5eanT1Sl5lm4KGpMkJ9GnNpm7iXSJnlJuQDh2P7BaBzc58cXq z8pXe8LvpNKxI4l88UazZK9PhqaQzqxszUsiNG/OW2fV867WfIBZX14a7q4oqe+r/r 3x4PgXgZk46qQ== Date: Fri, 24 Jun 2022 10:17:43 -0700 From: Jakub Kicinski To: Aleksey Shumnik Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, xeb@mail.ru Subject: Re: [PATCH] net/ipv4/ip_gre.c net/ipv6/ip6_gre.c: ip and gre header are recorded twice Message-ID: <20220624101743.78d0ece7@kernel.org> In-Reply-To: References: <20220622171929.77078c4d@kernel.org> <20220623202602.650ed2e6@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 24 Jun 2022 16:51:41 +0300 Aleksey Shumnik wrote: > On Fri, Jun 24, 2022 at 6:26 AM Jakub Kicinski wrote: > > > I use SOCK_DGRAM > > > > Strange. > > Why is it strange? I meant surprising, I'd have thought we could miss something like that for RAW sockets maybe but DGRAM/ICMP should work. > > > I want to find out, the creation of gre and ip header twice, is it a > > > feature or a bug? > > > > I can't think why that'd be a feature. Could add this case to selftests > > to show how to repro and catch regressions? > > I don't really know how to do it, but I'll try > If we just talk about selftests/net, then everything has passed What I'm looking for is a bash(?) script which sets up the tunnel sends a packet and checks if the headers are valid. > > > I did everything according to the instructions, hope everything is > > > correct this time. > > > > Nope, still mangled. > > Strangely, everything works fine for me Depends on definition of "works", are you saying you can download this: https://lore.kernel.org/all/CAJGXZLiNo=G=5889sPyiCZVjRf65Ygov3=DWFgKmay+Dy3wCYw@mail.gmail.com/raw which is your email in text form and `git am` will accept that as a patch?