From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9A45C433EF for ; Fri, 24 Jun 2022 10:34:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E9A97843C0; Fri, 24 Jun 2022 12:33:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=toradex.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 92684843D0; Fri, 24 Jun 2022 12:33:49 +0200 (CEST) Received: from de-smtp-delivery-113.mimecast.com (de-smtp-delivery-113.mimecast.com [194.104.111.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0E069843EA for ; Fri, 24 Jun 2022 12:33:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=toradex.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco.dolcini@toradex.com Received: from CHE01-GV0-obe.outbound.protection.outlook.com (mail-gv0che01lp2048.outbound.protection.outlook.com [104.47.22.48]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-zsXUn2nvMD26B-T0TXe0yA-3; Fri, 24 Jun 2022 12:33:41 +0200 X-MC-Unique: zsXUn2nvMD26B-T0TXe0yA-3 Received: from ZRAP278MB0495.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:2e::8) by ZR0P278MB0586.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:39::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 10:33:39 +0000 Received: from ZRAP278MB0495.CHEP278.PROD.OUTLOOK.COM ([fe80::f0b6:54ca:c3ff:48c1]) by ZRAP278MB0495.CHEP278.PROD.OUTLOOK.COM ([fe80::f0b6:54ca:c3ff:48c1%5]) with mapi id 15.20.5373.016; Fri, 24 Jun 2022 10:33:39 +0000 From: Francesco Dolcini To: Stefano Babic , Fabio Estevam , Marek Vasut , Marcel Ziswiler CC: Francesco Dolcini , "NXP i.MX U-Boot Team" , Tim Harvey , u-boot@lists.denx.de Subject: [PATCH v1 1/2] mx6: ddr: Fix disabling on-die termination Date: Fri, 24 Jun 2022 12:33:35 +0200 Message-ID: <20220624103336.536999-2-francesco.dolcini@toradex.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220624103336.536999-1-francesco.dolcini@toradex.com> References: <20220624103336.536999-1-francesco.dolcini@toradex.com> X-ClientProxiedBy: MR1P264CA0093.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::21) To ZRAP278MB0495.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:2e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2490a34-21d2-4672-b042-08da55cd0056 X-MS-TrafficTypeDiagnostic: ZR0P278MB0586:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: fNnrMz/eN5sYwHSTLDVOWskVUfCyUMcit2q/ZsBzjIglAbWuG2wWzlj/7zEjTwid3UaTXaI6TOckEl2RLOXqQQ+TilLaY6uaiRQywu9nukr3l63wJCvHRFV34LmGs0bwmIvRc8X5Y7pLMwqWmRGtVhcOz3rntFEHBmvMUylhfOIRID9gcafGfZHyg3QgcLGzNBN6UrndgiNDJRe/xxaLV887Q5xzmX+8SaXStP2SulMPnMsH2OskbJsD4aziQITMGhgHg/AjjOlj5xjR6M48Olcfix137EIMB0eFsR5vksE5P5e2MYz8EUWWHD/Cmej+tadfhidt28riIsRlFlnXCG2E/nbt0P9F+mQv/Xh7pgO56YWrfyOvN4R5swoGI9GtziCZLo3flGJRNG4LP1IJxKGV/YVTwF1BafOi/KXa3lK1bHQoh/t0TJ25QVrOQBtM4xwmxSFra/B/FOwQJZHWR/y0WVmlk5GpRcYraicPLZyv5aCqqF4eMNx2SesH0fXcLF58D0j+LJjU/5+oHvQ7H1OWXqtUDycj2WKQU6BvYvvQ+AkCOYxAms4ienPmjHfx39trJXfxwSuhFrqbFK1S6DmzkWjahHshP+HX/NUx55qLcrWvc+TaZi0Omy9XTyyxmJHuWU7f7f4gARuhn7p0XvXNzmYX4Iu7yrEybwKx+ZsCcQLpaRI2dvXR/I6S2ROMsgnnKl/NoVJXAsY3fMNTURv7oCp42X6cZtj4OnYWR5J2aaS383onaVOMrRNi8QF6J8lg7EWRZ7PuAFYRRNggqhuB/2USwNljyZcRALLDwYY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:ZRAP278MB0495.CHEP278.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(39840400004)(136003)(376002)(346002)(366004)(6666004)(52116002)(26005)(86362001)(6506007)(5660300002)(41300700001)(478600001)(38100700002)(186003)(6512007)(1076003)(38350700002)(8676002)(2616005)(316002)(66946007)(6636002)(8936002)(66556008)(36756003)(4326008)(66476007)(110136005)(54906003)(2906002)(44832011)(6486002)(83380400001); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1cnDmEm0yp5sAoOdgvj5JU2Xecsy3NibPAJsgSYA4P/8VJbSyz6lSt4sQtYm?= =?us-ascii?Q?NKegXoOc1vKpUkM3vRwqdc/SYDqPksFbcUkCVeh5czG+re2TDO1W/Hza1tHK?= =?us-ascii?Q?BwGmVjKFwRXKPUoKfFl+KxNj0TYlNLOZ+0QamBDtGgdsBU3fS/LRL/CmHqEh?= =?us-ascii?Q?TLtgUXXyFU079RMtH8LXLplBKsOF57PbEQrfNKQtUXvsIYZRgL/NrxPGROrs?= =?us-ascii?Q?mQe4qnXInHoi3GEMKvGJKEqa4kO57bBA3DYziUWlMEQ8BXwH/J7JUoQgT5+v?= =?us-ascii?Q?sfB1a6syxx0hTGuRtNb7AFMTMpd9/XtCrz0ztyfJCzx8RX9uTZodS68169RL?= =?us-ascii?Q?zyMv2bbuPIEPxuhpfjSgsy5QMUz1wBtBryn09Wh8WyyrViDDWfeCHCf4lhz9?= =?us-ascii?Q?as+Qfi6E2M4HKbRuUTEcF57Ek5uwiN58qoJuWchrM+p2JLyvKtrIPar/fI6c?= =?us-ascii?Q?tp4lGyuvZwvWjmftfYffpUBtItdosIqDAjKOM173XMKKMONJzIuJ9Oxw3UPX?= =?us-ascii?Q?5eLUmAPYLWy0Rjp1YOPm/lNTl4Ans5L+kuVHRsXj5pyYk7xvgL9srDTZncLq?= =?us-ascii?Q?F/MNzTQANt7BRp+4I5Kc4f/44QaDOe1ZRS2RMxPulDqFq3jCb6Fy3gAhnHx6?= =?us-ascii?Q?QJjXUX4/v2WV1NfszSblTEpDI3ZQW2y3tj5Cn6Lju9o/pd04xjQASQDmGvW7?= =?us-ascii?Q?GL3uu54Euw/wnTOzOg2/XskyWgopQWT/UY1MSCtmj+fShnT5zTNIeLF0U1PH?= =?us-ascii?Q?B5szTK7yGp5w1PBhHJUBv0//5H31VNC9n6Rf9g1LerY8GyBtHpuqHoyFoNyp?= =?us-ascii?Q?U03SqTzlrUVm3wigeDOwUN8jxG7G5ax3Rw4LZ4PSETlBtKlhZULxLkfVcB43?= =?us-ascii?Q?vYuJLrlWTMGdeyNV5ebTIv/YTgtU+2E9mITtb9OOE+1Y8AdRoxZSFS/ieDiM?= =?us-ascii?Q?GjRTE5TqpS1iBzDzO6hmmF0n3LIwBj1Hg+ihi4A5Sw4ee7+qUYT9dq4mbEay?= =?us-ascii?Q?IWChC9J1CxXyh+92k6e5KRmzfwtvW/NnCMs9XKXqOfOxycxX2BETV8NAem4c?= =?us-ascii?Q?C90Tj7dgALH7SC0leZcbW+uh7dJSMMe+2mxzlWVMfqyw2j8bGVRQMOmy6yV5?= =?us-ascii?Q?ogee9ghqlW4uaxCaqVwMX/PYIlahRLIJ6t5eRDChZOQvKZFJvUUg/yqyxzW6?= =?us-ascii?Q?J6DSPkX9QXQIFLIFUs0KJ0IY+7NsZuZzWvb2pSnwZxI4dQGCYji082ePv6Kr?= =?us-ascii?Q?9WxMa+VfN1zJaXMLUHqsDl9ajyhFeDKYvQygJqBK4g3xAH+q8x1yhBvIS3Js?= =?us-ascii?Q?iZZKswm8T/bXgwZl66ynpRJ4iAtXOZDyWGVIWWVuiahl/dxiWoqY8QMhEo8Q?= =?us-ascii?Q?9YuLBw8OuDVWsvWCryZSNuJn4Xg1VuJYRQCp9hPO+jOPYXwjn0Q5xNxyNqc7?= =?us-ascii?Q?1OBDF+MiGF5tAeHNkvxC0Xq7ffPTfjvqi3FSW2SVceklwXG4nySYC6oIaU9m?= =?us-ascii?Q?l1dsf9P3dj8pkBp19T8AaXROHVsJaldkgIUYNL6JpbrQ8ixQ+98ZxX26bR9Y?= =?us-ascii?Q?QK8ARrTiKz2TxoenapxpNgn8+eqVh3EBbeG3QhQaNnUxgoIYBU63aTMZtnvm?= =?us-ascii?Q?ug=3D=3D?= X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2490a34-21d2-4672-b042-08da55cd0056 X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0495.CHEP278.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 10:33:39.0090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iVFmy7cfq2I/jMoi8W9FzCx45bKe1iX4hm0nLJnF8oSTmoJ+6hspd/hrhU34veVlPvLmzg9F00drgVcmBa9NLcoBhcbUksJ+F8ugSHipTwQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0586 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CDE13A77 smtp.mailfrom=francesco.dolcini@toradex.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: toradex.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=WINDOWS-1252 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean In case rtt_nom is set to 0 keep ODT disabled (MMDC MPODTCTRL =3D 0). No changes required for DDR MR1 Rtt_Nom impedance register, 0 value is already handled correctly. No board is currently affected by this change (rtt_nom !=3D 0 on all i.MX6 ddr3 boards), this will be used by a follow-up change. Fixes: fe0f7f7842e1 ("mx6: add mmdc configuration for MX6Q/MX6DL") Signed-off-by: Francesco Dolcini --- arch/arm/mach-imx/mx6/ddr.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-imx/mx6/ddr.c b/arch/arm/mach-imx/mx6/ddr.c index 73a637c42d6c..3c87c577737b 100644 --- a/arch/arm/mach-imx/mx6/ddr.c +++ b/arch/arm/mach-imx/mx6/ddr.c @@ -1469,8 +1469,17 @@ void mx6_ddr3_cfg(const struct mx6_ddr_sysinfo *sysi= nfo, =09=09MMDC1(mprddqby3dl, 0x33333333); =09} =20 -=09/* MMDC Termination: rtt_nom:2 RZQ/2(120ohm), rtt_nom:1 RZQ/4(60ohm) */ -=09val =3D (sysinfo->rtt_nom =3D=3D 2) ? 0x00011117 : 0x00022227; +=09/* +=09 * MMDC Termination: rtt_nom:2 RZQ/2(120ohm), +=09 * rtt_nom:1 RZQ/4(60ohm), +=09 * rtt_nom:0 Disabled +=09 */ +=09if (sysinfo->rtt_nom =3D=3D 0) +=09=09val =3D 0x00000000; +=09else if (sysinfo->rtt_nom =3D=3D 2) +=09=09val =3D 0x00011117; +=09else +=09=09val =3D 0x00022227; =09mmdc0->mpodtctrl =3D val; =09if (sysinfo->dsize > 1) =09=09MMDC1(mpodtctrl, val); --=20 2.25.1