From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4468C433EF for ; Fri, 24 Jun 2022 20:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbiFXUNP (ORCPT ); Fri, 24 Jun 2022 16:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbiFXUNN (ORCPT ); Fri, 24 Jun 2022 16:13:13 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 254E731532 for ; Fri, 24 Jun 2022 13:13:12 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id r66so3385982pgr.2 for ; Fri, 24 Jun 2022 13:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JO7J5gYwMc2oJpLpkWigLEC53bU/Q4t+rjJSx2/0CdY=; b=eGNfcAvYM1eEBkUwfnn/Tbo9MYHzrrNAEqTo3aweTmsmcvdHJIQolhJdks3ZI06Hnz ToODfaBXKu5XQl3iJjSxgXgx6b2mCmS/au7xy6QtVRe0KR4YlQCAc0i1LzEkzN2B9d7a f9wuhNf0912A84p4kuE5f2tjgeK9s/ObIhPYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JO7J5gYwMc2oJpLpkWigLEC53bU/Q4t+rjJSx2/0CdY=; b=1Bt2df7BaGPbNgXSm0l5F9V97mH8RKzWvU57PKjiETF59feUOondqfWt9KMgHKzkb7 9mpFqnJzF+x+0ZQLrcJ7aY4vVM2eWi6V3Xg1UaKburufBYrYzx8I3iQGM2HRkqyAocYI 36vi2qwj7gPqhkWi0eVFV0QL5uOGxhMvjLeZeA3ADJz8UDFt7BqDYLBEGkMrT5OJqaO/ yQH6s5S5jX9BV0lMcqhsdXb1ALonfbWnPIp13AwQhfVH2inlfILE7ALGxPsLSmpVmCdx tKNG8LBDERpkkpRiSsfaFJm6zFN4HNziPArWMBv0KMAC4ighG8gHqUMfiZ/7wEFsEM2m ZPsg== X-Gm-Message-State: AJIora+nhvWN1Q54fI7X6hiozBc+FwK5wZTtRkLUtgnckEeVd7iSXubA RLlsDbxcMUk+CwIvxNMB6Cd9uw== X-Google-Smtp-Source: AGRyM1skZyJeAmzbptZd5plp8ZRer/MKu/mlvmAuyKbVM9kantiVUC5Iiok1Xs7xFNvbtfSGSAKjZw== X-Received: by 2002:a63:8c1b:0:b0:40c:7af0:cdaa with SMTP id m27-20020a638c1b000000b0040c7af0cdaamr513452pgd.326.1656101591612; Fri, 24 Jun 2022 13:13:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d10-20020a170902e14a00b0016196bd15f4sm2228549pla.15.2022.06.24.13.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 13:13:11 -0700 (PDT) Date: Fri, 24 Jun 2022 13:13:10 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: linux-kernel@vger.kernel.org, Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 3/4][next] scsi: megaraid_sas: Replace one-element array with flexible-array member in MR_DRV_RAID_MAP Message-ID: <202206241312.EC413977@keescook> References: <202206221457.1A12D768EF@keescook> <20220623014533.GA7132@embeddedor> <20220623031401.GA8896@embeddedor> <202206230816.1383511C@keescook> <20220623153825.GA6458@embeddedor> <202206241047.903049ED@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202206241047.903049ED@keescook> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2022 at 10:48:39AM -0700, Kees Cook wrote: > On Thu, Jun 23, 2022 at 05:38:25PM +0200, Gustavo A. R. Silva wrote: > > Which object files are you comparing here? because I don't see the zero > > change when comparing the before and after of megaraid_sas_fp.o with > > the change you propose. > > Hm, maybe I did something wrong. But I was looking at megaraid_sas_fp.o Explaining my process got a bit long, so I wrote a blog post on it. Here's how I did my examination of the resulting output: https://outflux.net/blog/archives/2022/06/24/finding-binary-differences/ -- Kees Cook