All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: haris iqbal <haris.phnx@gmail.com>
Cc: linux-rdma@vger.kernel.org, Leon Romanovsky <leon@kernel.org>,
	zyjzyj2000@gmail.com, haris.iqbal@ionos.com,
	Jinpu Wang <jinpu.wang@ionos.com>,
	aleksei.marov@ionos.com, rpearsonhpe@gmail.com
Subject: Re: [PATCH v2] RDMA/rxe: Split rxe_invalidate_mr into local and remote versions
Date: Fri, 24 Jun 2022 17:02:50 -0300	[thread overview]
Message-ID: <20220624200250.GC23621@ziepe.ca> (raw)
In-Reply-To: <CAE_WKMypM1pTCpQV_yJUwa9DzVZnB9grCM=kiVt_6m3HD98eiA@mail.gmail.com>

On Wed, Jun 22, 2022 at 04:12:01PM +0200, haris iqbal wrote:
> On Thu, Jun 16, 2022 at 4:09 PM Md Haris Iqbal <haris.phnx@gmail.com> wrote:
> >
> > Currently rxe_invalidate_mr does invalidate for both local ops, and remote
> > ones. This means that MR being invalidated is compared with rkey for both,
> > which is incorrect. For local invalidate, comparison should happen with
> > lkey, and for the remote one, it should happen with rkey.
> >
> > This commit splits the rxe_invalidate_mr into local and remote versions.
> > Each of them does comparison the right way as described above (with lkey
> > for local, and rkey for remote).
> >
> > Fixes: 3902b429ca14 ("RDMA/rxe: Implement invalidate MW operations")
> > Cc: rpearsonhpe@gmail.com
> > Signed-off-by: Md Haris Iqbal <haris.phnx@gmail.com>

> ping.

The commit message makes sense to me - is anyone else working on rxe
going to test or review this patch?

There are now many patches for rxe that I would like the rxe community
to mutually review/test/ack.

Jason

  reply	other threads:[~2022-06-24 20:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 14:09 [PATCH v2] RDMA/rxe: Split rxe_invalidate_mr into local and remote versions Md Haris Iqbal
2022-06-22 14:12 ` haris iqbal
2022-06-24 20:02   ` Jason Gunthorpe [this message]
2022-06-27  0:33     ` Bob Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624200250.GC23621@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=aleksei.marov@ionos.com \
    --cc=haris.iqbal@ionos.com \
    --cc=haris.phnx@gmail.com \
    --cc=jinpu.wang@ionos.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.