From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D661CC43334 for ; Fri, 24 Jun 2022 20:59:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231880AbiFXU7I (ORCPT ); Fri, 24 Jun 2022 16:59:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230448AbiFXU7H (ORCPT ); Fri, 24 Jun 2022 16:59:07 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0BDB3057A; Fri, 24 Jun 2022 13:59:06 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id b21so3408979ljf.1; Fri, 24 Jun 2022 13:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=QtMwHvmYMWJKh0ZLqnKgANF/OLV82B74Mco6zvnuZeUejNoYhy3/XMUTG/IZxeWN1g kJdFX7Hjjll5/gBbGDFfE6NZ8Z29REr8unbv/+Rw3EywhBgZrzUKHOFbsy+9hm74n6W9 FgxFz9+BxFFugBZ7wGl/0JzWCFktsdwHV3yRMFgHnNXL54N/hJPqiRFrtpAHgfAV26va xmrjOfYjXA5cjt979wG15bgUAfQ9zTnFdadgyXYvvGP+unwebPCQDrxzW6mC4gLjZm8L VBd3ejedJJ834pxFVJIh0zkDdBaoMunu6IPVDte8eqiNoRGsva/W17BJryh5PbVTYkVi zfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=srRWHy+1Q5eq91BIM22aSW3pP28nz3PL/RyrY0cFyN+RbqWFoIjjxxb0Jn+FS5u/eQ xDVNsR07FBNvGw7aLAev+67NSq6GXiKK0LMzy7eL3CHN3T9C9ZcTXqJqKdIo9FF9Mjmw dnnvXFhhx6KvmmfEPVH+JC6iPYCcqtMhYrzEWAA0wWc6aA2tjqpg0uO7SMRWh8LngAIU Z65BnY/PmbbFNJ+4TZsaPzmWyibIah85QxUcR0VacEfFi/gfisLw/8O8UHZRks7D5niL 4xaCfQiNS4JNUTaFYjXVODj70YnGBAg9kmnKT5RKa3cVdXS033LHv1UrsFqGLgVi7WU4 v3Kw== X-Gm-Message-State: AJIora/jLz8l1kUXmMWsAgZSsbNFuxlau7KZADqzYMOeF8T44yBNIfxS Ix8ClrQwHGuGddcLH1CeArM= X-Google-Smtp-Source: AGRyM1v6fuennno+VmySkb2y5X/FFQLPUJh7sXw3iLNDmiKty2pRq4AJTIzsRg4onyEuYZ8fkJyBPA== X-Received: by 2002:a05:651c:1617:b0:25a:9e88:af82 with SMTP id f23-20020a05651c161700b0025a9e88af82mr401410ljq.106.1656104345088; Fri, 24 Jun 2022 13:59:05 -0700 (PDT) Received: from mobilestation ([95.79.189.214]) by smtp.gmail.com with ESMTPSA id 13-20020ac2568d000000b0047fa40b5052sm523338lfr.62.2022.06.24.13.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 13:59:04 -0700 (PDT) Date: Fri, 24 Jun 2022 23:59:02 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Serge Semin , Andy Gross , Bjorn Andersson , Felipe Balbi , Michael Ellerman , Vladimir Zapolskiy , Alexey Brodkin , Vineet Gupta , Rob Herring , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Khuong Dinh , Krzysztof Kozlowski , Patrice Chotard , Benjamin Herrenschmidt , Paul Mackerras , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Message-ID: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: > On 24/06/2022 16:16, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named despite of the warning comment about possible backward > > compatibility issues. > > Sometimes node name is exposed to user-space which depends on it. How > did you check there is no issue here? I well remember the Qcom problem caused by one of my patch: https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ The next patch caused the same problem, but hasn't been reverted. https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ As before I am more inclined to thinking that the problem was mainly caused by the improper node-name utilization. Anyway John later noted that the problem was fixed in the user-space. That why afterwards you were able to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 node names and unit addresses"). Anyway I am not able to track the way the node-name is used on the affected platform and can't make sure that the dts would be still working well on that devices. But seeing nobody responded/commented on this patch for more than a year we can at least try to merge this in and see whether it causes any problem should the denoted platform is still in use. If it does we can revert the update back and forget about it. -Sergey > > > > > Signed-off-by: Serge Semin > > Acked-by: Krzysztof Kozlowski > > --- > > arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- > > arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > index a83c82c50e29..832dd85b00bd 100644 > > --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > @@ -597,8 +597,8 @@ serial0: serial@10600000 { > > interrupts = <0x0 0x4c 0x4>; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > index 0f37e77f5459..1520a945b7f9 100644 > > --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > @@ -923,8 +923,8 @@ sata3: sata@1a800000 { > > phy-names = "sata-phy"; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > @@ -933,7 +933,7 @@ usb0: dwusb@19000000 { > > dr_mode = "host"; > > }; > > > > - usb1: dwusb@19800000 { > > + usb1: usb@19800000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19800000 0x0 0x100000>; > > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CE2FC43334 for ; Fri, 24 Jun 2022 20:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rXSXfyqlVQFXkO4QJLU2VXH2FM7gbDW4tGiHPNnEejU=; b=Jfwmrj1WrvXj7E GEC3v1YvQCaa1gfWJt33ybEnipacD6WFfFo2g4i0XMwx34wk++rPOEKin5C4pzD9YCyIyEOkT0tWo TJiBdUVFrqmUnwYpqhtJEtVsTp5PjwyorSpZC3KMsL43yyCH9IWwkYlKlQkHdMInKd733WZx/+srR K11z/Rn1TBENHZos7+anpGvtWjGoXSgm958JPp8B5zGz+bXmT1JcocjPAYDRlTauDM1o3jc5nSxyi XzqXZgV94bPeNRT44Wbo6GGlQzquWwLgI6ekCggTq5OQWnE/QvOS9ZDpxwbpj4T1BX3RiCW0UTbFb 5MX1HGHvEjRPQ4E3XbRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4qOc-003o61-Md; Fri, 24 Jun 2022 20:59:18 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4qOR-003o3g-Rn; Fri, 24 Jun 2022 20:59:09 +0000 Received: by mail-lj1-x22b.google.com with SMTP id c30so4065955ljr.9; Fri, 24 Jun 2022 13:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=QtMwHvmYMWJKh0ZLqnKgANF/OLV82B74Mco6zvnuZeUejNoYhy3/XMUTG/IZxeWN1g kJdFX7Hjjll5/gBbGDFfE6NZ8Z29REr8unbv/+Rw3EywhBgZrzUKHOFbsy+9hm74n6W9 FgxFz9+BxFFugBZ7wGl/0JzWCFktsdwHV3yRMFgHnNXL54N/hJPqiRFrtpAHgfAV26va xmrjOfYjXA5cjt979wG15bgUAfQ9zTnFdadgyXYvvGP+unwebPCQDrxzW6mC4gLjZm8L VBd3ejedJJ834pxFVJIh0zkDdBaoMunu6IPVDte8eqiNoRGsva/W17BJryh5PbVTYkVi zfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=J9tIHWVciedvLpkPJUVb5iuzFUUxCRZQvVCNBKOFTT77gPkHWxytopDRpTdtfaty2s EhcdVfv/RInCWUBM8QQ9HYNV2U7Zi6vzBP0lcTrSoAFHuIrjfSzeGILtXfUW5NMk5EID i9NwnB3T/iSjvwM+wVq3a2sQMgGuYtydxKgzxb0L0trTdFxWy3VS76D60CTveN7IApmK PKQXkMKRUf3Oan7BxJvFOixwlQ47DY8sYFPhs9/CjwoFTV90L114KO9c56Rtc+rYYNkb EbrLFAX8xCJn/hSkC4+DUEMxoxAyfVuJE1O5MnOXgo1WYU8lgR8dn+kXH7UG7lYiWBKZ +bPA== X-Gm-Message-State: AJIora9CWasoYe9t9k9e2/lmmHJcUH2bnLwBAcD2FWDmIUnB2McA7lXZ NWljj4v5pdRroBDtVSaBct8= X-Google-Smtp-Source: AGRyM1v6fuennno+VmySkb2y5X/FFQLPUJh7sXw3iLNDmiKty2pRq4AJTIzsRg4onyEuYZ8fkJyBPA== X-Received: by 2002:a05:651c:1617:b0:25a:9e88:af82 with SMTP id f23-20020a05651c161700b0025a9e88af82mr401410ljq.106.1656104345088; Fri, 24 Jun 2022 13:59:05 -0700 (PDT) Received: from mobilestation ([95.79.189.214]) by smtp.gmail.com with ESMTPSA id 13-20020ac2568d000000b0047fa40b5052sm523338lfr.62.2022.06.24.13.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 13:59:04 -0700 (PDT) Date: Fri, 24 Jun 2022 23:59:02 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Serge Semin , Andy Gross , Bjorn Andersson , Felipe Balbi , Michael Ellerman , Vladimir Zapolskiy , Alexey Brodkin , Vineet Gupta , Rob Herring , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Khuong Dinh , Krzysztof Kozlowski , Patrice Chotard , Benjamin Herrenschmidt , Paul Mackerras , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Message-ID: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_135907_939667_DF47FAC8 X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: > On 24/06/2022 16:16, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named despite of the warning comment about possible backward > > compatibility issues. > > Sometimes node name is exposed to user-space which depends on it. How > did you check there is no issue here? I well remember the Qcom problem caused by one of my patch: https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ The next patch caused the same problem, but hasn't been reverted. https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ As before I am more inclined to thinking that the problem was mainly caused by the improper node-name utilization. Anyway John later noted that the problem was fixed in the user-space. That why afterwards you were able to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 node names and unit addresses"). Anyway I am not able to track the way the node-name is used on the affected platform and can't make sure that the dts would be still working well on that devices. But seeing nobody responded/commented on this patch for more than a year we can at least try to merge this in and see whether it causes any problem should the denoted platform is still in use. If it does we can revert the update back and forget about it. -Sergey > > > > > Signed-off-by: Serge Semin > > Acked-by: Krzysztof Kozlowski > > --- > > arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- > > arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > index a83c82c50e29..832dd85b00bd 100644 > > --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > @@ -597,8 +597,8 @@ serial0: serial@10600000 { > > interrupts = <0x0 0x4c 0x4>; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > index 0f37e77f5459..1520a945b7f9 100644 > > --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > @@ -923,8 +923,8 @@ sata3: sata@1a800000 { > > phy-names = "sata-phy"; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > @@ -933,7 +933,7 @@ usb0: dwusb@19000000 { > > dr_mode = "host"; > > }; > > > > - usb1: dwusb@19800000 { > > + usb1: usb@19800000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19800000 0x0 0x100000>; > > > Best regards, > Krzysztof _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BDFAC43334 for ; Fri, 24 Jun 2022 20:59:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LV8dL3QMYz3dQw for ; Sat, 25 Jun 2022 06:59:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=QtMwHvmY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::233; helo=mail-lj1-x233.google.com; envelope-from=fancer.lancer@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=QtMwHvmY; dkim-atps=neutral Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LV8cb4mphz3c7h for ; Sat, 25 Jun 2022 06:59:09 +1000 (AEST) Received: by mail-lj1-x233.google.com with SMTP id n15so4072879ljg.8 for ; Fri, 24 Jun 2022 13:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=QtMwHvmYMWJKh0ZLqnKgANF/OLV82B74Mco6zvnuZeUejNoYhy3/XMUTG/IZxeWN1g kJdFX7Hjjll5/gBbGDFfE6NZ8Z29REr8unbv/+Rw3EywhBgZrzUKHOFbsy+9hm74n6W9 FgxFz9+BxFFugBZ7wGl/0JzWCFktsdwHV3yRMFgHnNXL54N/hJPqiRFrtpAHgfAV26va xmrjOfYjXA5cjt979wG15bgUAfQ9zTnFdadgyXYvvGP+unwebPCQDrxzW6mC4gLjZm8L VBd3ejedJJ834pxFVJIh0zkDdBaoMunu6IPVDte8eqiNoRGsva/W17BJryh5PbVTYkVi zfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=SIf3gI/zYVIINnr5swTqkQxc5yX1sBXPsGG4Z0Edrr2cCrw7xegppkXa1dxE3dVsPg GUpKqGlXlJtsYdOKxzZJr0ZobzufcKy/ge2Uy2sBSsQEZirXO/nzIyFlNGvMn67vJElP x6M5Dxb8X75kYnB+Cfm1i/9H/Y3XxexamDBsJeh9TcLEp3fXZ1wqse4EgRUcXS10YGtG tTRQEXpLFtBaoAaeEtn3nMHrK/Ijtx1W/w5G/WVZGC2LbkabvxjaeDhGIeX/1bLkwBJr xh9+4v3fZY+0iGy5qRJlHYfNQRvpVxpsHXaaagb/kPllORkv7IvOQ2tPyiHLi7FtZfMz jTfw== X-Gm-Message-State: AJIora/gNKCb+Yd11g9zAXseNmIH45eaY6RKoooQc74qrJpyjBkN6HXt bfaID9RqSE/YZ5jYHAqU/eo= X-Google-Smtp-Source: AGRyM1v6fuennno+VmySkb2y5X/FFQLPUJh7sXw3iLNDmiKty2pRq4AJTIzsRg4onyEuYZ8fkJyBPA== X-Received: by 2002:a05:651c:1617:b0:25a:9e88:af82 with SMTP id f23-20020a05651c161700b0025a9e88af82mr401410ljq.106.1656104345088; Fri, 24 Jun 2022 13:59:05 -0700 (PDT) Received: from mobilestation ([95.79.189.214]) by smtp.gmail.com with ESMTPSA id 13-20020ac2568d000000b0047fa40b5052sm523338lfr.62.2022.06.24.13.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 13:59:04 -0700 (PDT) Date: Fri, 24 Jun 2022 23:59:02 +0300 From: Serge Semin To: Krzysztof Kozlowski Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Message-ID: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bjorn Andersson , Paul Mackerras , Krzysztof Kozlowski , Rob Herring , Khuong Dinh , Alexey Brodkin , Krzysztof Kozlowski , Andy Gross , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vladimir Zapolskiy , Rob Herring , linux-arm-kernel@lists.infradead.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Patrice Chotard , linux-kernel@vger.kernel.org, Serge Semin , Vineet Gupta , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: > On 24/06/2022 16:16, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named despite of the warning comment about possible backward > > compatibility issues. > > Sometimes node name is exposed to user-space which depends on it. How > did you check there is no issue here? I well remember the Qcom problem caused by one of my patch: https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ The next patch caused the same problem, but hasn't been reverted. https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ As before I am more inclined to thinking that the problem was mainly caused by the improper node-name utilization. Anyway John later noted that the problem was fixed in the user-space. That why afterwards you were able to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 node names and unit addresses"). Anyway I am not able to track the way the node-name is used on the affected platform and can't make sure that the dts would be still working well on that devices. But seeing nobody responded/commented on this patch for more than a year we can at least try to merge this in and see whether it causes any problem should the denoted platform is still in use. If it does we can revert the update back and forget about it. -Sergey > > > > > Signed-off-by: Serge Semin > > Acked-by: Krzysztof Kozlowski > > --- > > arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- > > arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > index a83c82c50e29..832dd85b00bd 100644 > > --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > @@ -597,8 +597,8 @@ serial0: serial@10600000 { > > interrupts = <0x0 0x4c 0x4>; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > index 0f37e77f5459..1520a945b7f9 100644 > > --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > @@ -923,8 +923,8 @@ sata3: sata@1a800000 { > > phy-names = "sata-phy"; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > @@ -933,7 +933,7 @@ usb0: dwusb@19000000 { > > dr_mode = "host"; > > }; > > > > - usb1: dwusb@19800000 { > > + usb1: usb@19800000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19800000 0x0 0x100000>; > > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FE84C43334 for ; Fri, 24 Jun 2022 21:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u2HaPDX9zxFfGGDkYevCMhVtp1b/XFP55ZiicYij9NU=; b=Jr5Bgl2jiadGga HlRTCSM2K5qwSVdZsdVzHh3OHgBL4VIA68TqtjetiTrVwyQVjKzlgBUjvN/Q0iS9HQlio7cexOuYz h/e/4diBeFt2Rp2dWnsa+oMUpl+RjMaHuBUpfVNepNAyJbUcplx4tBcQlqHrhSsvs57vkOt6elvf2 VVtAWYhy2rfZsas0ZbeQCNoMgg0f4ECCuRiATmzzoQAj0/4TW/505ntUp+hBzF8WGMKuqevkQY7SK kaIrFdNgBngr4CmaioDCE03fnYIsXfoOApYK3S38/P4NwyDHlUYO3YNR4YsqJfFGPAiHohS0BsaiQ kXNllFr5HryvIQw2CkvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4qOU-003o4K-Ky; Fri, 24 Jun 2022 20:59:10 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4qOR-003o3g-Rn; Fri, 24 Jun 2022 20:59:09 +0000 Received: by mail-lj1-x22b.google.com with SMTP id c30so4065955ljr.9; Fri, 24 Jun 2022 13:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=QtMwHvmYMWJKh0ZLqnKgANF/OLV82B74Mco6zvnuZeUejNoYhy3/XMUTG/IZxeWN1g kJdFX7Hjjll5/gBbGDFfE6NZ8Z29REr8unbv/+Rw3EywhBgZrzUKHOFbsy+9hm74n6W9 FgxFz9+BxFFugBZ7wGl/0JzWCFktsdwHV3yRMFgHnNXL54N/hJPqiRFrtpAHgfAV26va xmrjOfYjXA5cjt979wG15bgUAfQ9zTnFdadgyXYvvGP+unwebPCQDrxzW6mC4gLjZm8L VBd3ejedJJ834pxFVJIh0zkDdBaoMunu6IPVDte8eqiNoRGsva/W17BJryh5PbVTYkVi zfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eZSZCpbsimxpe8y0nI2vhGyb3S9o4fusHBXGkJK5Cfc=; b=J9tIHWVciedvLpkPJUVb5iuzFUUxCRZQvVCNBKOFTT77gPkHWxytopDRpTdtfaty2s EhcdVfv/RInCWUBM8QQ9HYNV2U7Zi6vzBP0lcTrSoAFHuIrjfSzeGILtXfUW5NMk5EID i9NwnB3T/iSjvwM+wVq3a2sQMgGuYtydxKgzxb0L0trTdFxWy3VS76D60CTveN7IApmK PKQXkMKRUf3Oan7BxJvFOixwlQ47DY8sYFPhs9/CjwoFTV90L114KO9c56Rtc+rYYNkb EbrLFAX8xCJn/hSkC4+DUEMxoxAyfVuJE1O5MnOXgo1WYU8lgR8dn+kXH7UG7lYiWBKZ +bPA== X-Gm-Message-State: AJIora9CWasoYe9t9k9e2/lmmHJcUH2bnLwBAcD2FWDmIUnB2McA7lXZ NWljj4v5pdRroBDtVSaBct8= X-Google-Smtp-Source: AGRyM1v6fuennno+VmySkb2y5X/FFQLPUJh7sXw3iLNDmiKty2pRq4AJTIzsRg4onyEuYZ8fkJyBPA== X-Received: by 2002:a05:651c:1617:b0:25a:9e88:af82 with SMTP id f23-20020a05651c161700b0025a9e88af82mr401410ljq.106.1656104345088; Fri, 24 Jun 2022 13:59:05 -0700 (PDT) Received: from mobilestation ([95.79.189.214]) by smtp.gmail.com with ESMTPSA id 13-20020ac2568d000000b0047fa40b5052sm523338lfr.62.2022.06.24.13.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 13:59:04 -0700 (PDT) Date: Fri, 24 Jun 2022 23:59:02 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Serge Semin , Andy Gross , Bjorn Andersson , Felipe Balbi , Michael Ellerman , Vladimir Zapolskiy , Alexey Brodkin , Vineet Gupta , Rob Herring , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Khuong Dinh , Krzysztof Kozlowski , Patrice Chotard , Benjamin Herrenschmidt , Paul Mackerras , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Message-ID: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_135907_939667_DF47FAC8 X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: > On 24/06/2022 16:16, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named despite of the warning comment about possible backward > > compatibility issues. > > Sometimes node name is exposed to user-space which depends on it. How > did you check there is no issue here? I well remember the Qcom problem caused by one of my patch: https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ The next patch caused the same problem, but hasn't been reverted. https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ As before I am more inclined to thinking that the problem was mainly caused by the improper node-name utilization. Anyway John later noted that the problem was fixed in the user-space. That why afterwards you were able to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 node names and unit addresses"). Anyway I am not able to track the way the node-name is used on the affected platform and can't make sure that the dts would be still working well on that devices. But seeing nobody responded/commented on this patch for more than a year we can at least try to merge this in and see whether it causes any problem should the denoted platform is still in use. If it does we can revert the update back and forget about it. -Sergey > > > > > Signed-off-by: Serge Semin > > Acked-by: Krzysztof Kozlowski > > --- > > arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- > > arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > index a83c82c50e29..832dd85b00bd 100644 > > --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > @@ -597,8 +597,8 @@ serial0: serial@10600000 { > > interrupts = <0x0 0x4c 0x4>; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > index 0f37e77f5459..1520a945b7f9 100644 > > --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi > > +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi > > @@ -923,8 +923,8 @@ sata3: sata@1a800000 { > > phy-names = "sata-phy"; > > }; > > > > - /* Do not change dwusb name, coded for backward compatibility */ > > - usb0: dwusb@19000000 { > > + /* Node-name might need to be coded as dwusb for backward compatibility */ > > + usb0: usb@19000000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19000000 0x0 0x100000>; > > @@ -933,7 +933,7 @@ usb0: dwusb@19000000 { > > dr_mode = "host"; > > }; > > > > - usb1: dwusb@19800000 { > > + usb1: usb@19800000 { > > status = "disabled"; > > compatible = "snps,dwc3"; > > reg = <0x0 0x19800000 0x0 0x100000>; > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel