[PATCH v6 03/15] block/blklogwrites: don't care to remove bs->file child on failure - Vladimir Sementsov-Ogievskiy

From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com,
	vsementsov@yandex-team.ru, Ari Sundholm <ari@tuxera.com>
Subject: [PATCH v6 03/15] block/blklogwrites: don't care to remove bs->file child on failure
Date: Sat, 25 Jun 2022 00:28:18 +0300	[thread overview]
Message-ID: <20220624212830.316919-4-vsementsov@yandex-team.ru> (raw)
In-Reply-To: <20220624212830.316919-1-vsementsov@yandex-team.ru>

We don't need to remove bs->file, generic layer takes care of it. No
other driver cares to remove bs->file on failure by hand.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
 block/blklogwrites.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/block/blklogwrites.c b/block/blklogwrites.c
index f66a617eb3..7d25df97cc 100644
--- a/block/blklogwrites.c
+++ b/block/blklogwrites.c
@@ -254,10 +254,6 @@ fail_log:
         s->log_file = NULL;
     }
 fail:
-    if (ret < 0) {
-        bdrv_unref_child(bs, bs->file);
-        bs->file = NULL;
-    }
     qemu_opts_del(opts);
     return ret;
 }
-- 
2.25.1


