Re: [PATCH 20/36] iio: light: al3320a: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()

From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Brian Masney" <masneyb@onstation.org>,
	"David Heidelberg" <david@ixit.cz>,
	"Cai Huoqing" <cai.huoqing@linux.dev>,
	"Christian Eggers" <ceggers@arri.de>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	"Eugen Hristev" <eugen.hristev@microchip.com>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Hui Liu" <hui.liu@mediatek.com>,
	"Joe Sandom" <joe.g.sandom@gmail.com>,
	"Ismail H . Kose" <ihkose@gmail.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Mathieu Othacehe" <m.othacehe@gmail.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Parthiban Nallathambi" <pn@denx.de>,
	"Philippe Reynes" <tremyfr@yahoo.fr>,
	"Philippe Schenker" <philippe.schenker@toradex.com>,
	"Rishi Gupta" <gupt21@gmail.com>,
	"Roan van Dijk" <roan@protonic.nl>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Tomasz Duszynski" <tduszyns@gmail.com>,
	"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 20/36] iio: light: al3320a: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()
Date: Sat, 25 Jun 2022 14:06:02 +0100	[thread overview]
Message-ID: <20220625140602.1d6967c2@jic23-huawei> (raw)
In-Reply-To: <20220621202719.13644-21-jic23@kernel.org>

On Tue, 21 Jun 2022 21:27:03 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Using these newer macros allows the compiler to remove the unused
> structure and functions when !CONFIG_PM_SLEEP + removes the need to
> mark pm functions __maybe_unused.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: David Heidelberg <david@ixit.cz>
I'll just copy this here from reply to patch 19 so b4 will do
everything automatically for me. 

both patches 19 and 20:

Reviewed-by: David Heidelberg <david@ixit.cz>

> ---
>  drivers/iio/light/al3320a.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c
> index cc1407ccc10a..bc99179728ed 100644
> --- a/drivers/iio/light/al3320a.c
> +++ b/drivers/iio/light/al3320a.c
> @@ -223,17 +223,18 @@ static int al3320a_probe(struct i2c_client *client,
>  	return devm_iio_device_register(&client->dev, indio_dev);
>  }
>  
> -static int __maybe_unused al3320a_suspend(struct device *dev)
> +static int al3320a_suspend(struct device *dev)
>  {
>  	return al3320a_set_pwr(to_i2c_client(dev), false);
>  }
>  
> -static int __maybe_unused al3320a_resume(struct device *dev)
> +static int al3320a_resume(struct device *dev)
>  {
>  	return al3320a_set_pwr(to_i2c_client(dev), true);
>  }
>  
> -static SIMPLE_DEV_PM_OPS(al3320a_pm_ops, al3320a_suspend, al3320a_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(al3320a_pm_ops, al3320a_suspend,
> +				al3320a_resume);
>  
>  static const struct i2c_device_id al3320a_id[] = {
>  	{"al3320a", 0},
> @@ -251,7 +252,7 @@ static struct i2c_driver al3320a_driver = {
>  	.driver = {
>  		.name = AL3320A_DRV_NAME,
>  		.of_match_table = al3320a_of_match,
> -		.pm = &al3320a_pm_ops,
> +		.pm = pm_sleep_ptr(&al3320a_pm_ops),
>  	},
>  	.probe		= al3320a_probe,
>  	.id_table	= al3320a_id,