From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98ACDC43334 for ; Mon, 27 Jun 2022 22:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242517AbiF0WQM (ORCPT ); Mon, 27 Jun 2022 18:16:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240366AbiF0WQM (ORCPT ); Mon, 27 Jun 2022 18:16:12 -0400 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3ED66251; Mon, 27 Jun 2022 15:16:10 -0700 (PDT) Received: by mail-io1-f50.google.com with SMTP id p69so11088041iod.10; Mon, 27 Jun 2022 15:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sEUUUlDAYju/2YLxlXSh5PX7GI5wJxClR/yx3HviGBQ=; b=cb6PrlkbRo3vOv7wrhjDQBQjQ70Gewlgnw6Qv+BskiCEH5lafK5r8hK8XcRzs9252M +HZ2JcpkiuEFXTTnee9qt888sIFbmoJRVM4k/zc+5fs+hozEOekljRy2zWnrDs5Hsf3/ fhnjNA28tNfBvwjk/lEOqdG0l5fN5JzoVuUueEa0uhFK1TPmkXe9HPTCdpBI7v0OKm0R x/zkAZPUpCfbAiilxVTqKqC/E0VBCV7Qg0NN2QJcVvXSu9wfEgElbYwweKDXKuBGRuuq 2ECJ6O6wJcfM7rKXsLQ6rO9fNebbAWag3YrhHsQMKu10DMpwvP9kmWYcMzw8lL7RLK8b 10yQ== X-Gm-Message-State: AJIora/pX1WEoFIaQ28CJhT0xeqbZiX/yH4YXodEoPgizIR3//L2Ls9+ JBCnGARXgE4+zey0mqS7WQ== X-Google-Smtp-Source: AGRyM1ul6meQjPMho4PaYYVmeFu5wv9y8tgdGZfqXlC28iBRP2OmhPocanyd1Cb9iwo5OiHmJL6b0g== X-Received: by 2002:a05:6602:2d0e:b0:64f:d1ff:ac9c with SMTP id c14-20020a0566022d0e00b0064fd1ffac9cmr7870131iow.41.1656368170082; Mon, 27 Jun 2022 15:16:10 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id m2-20020a02cdc2000000b00339e6168237sm4805432jap.34.2022.06.27.15.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 15:16:09 -0700 (PDT) Received: (nullmailer pid 3062972 invoked by uid 1000); Mon, 27 Jun 2022 22:16:08 -0000 Date: Mon, 27 Jun 2022 16:16:08 -0600 From: Rob Herring To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Sakari Ailus , Jacopo Mondi , Eugen Hristev , Hugues Fruchet , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Fabio Estevam , Shawn Guo Subject: Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples Message-ID: <20220627221608.GA3060504-robh@kernel.org> References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-3-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615221410.27459-3-laurent.pinchart@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote: > Now that a header exists with macros for the media interface bus-type > values, replace hardcoding numerical constants with the corresponding > macros in the DT binding examples. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Go back to PARALLEL > > Changes since v1: > > - Rename PARALLEL to BT601 > --- > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 + > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++- > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++- > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++- > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++- > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++- > 6 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 35a48515836e..b0e5585f93e2 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -118,6 +118,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c0 { > #address-cells = <1>; > diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > index 39395ea8c318..edde4201116f 100644 > --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > @@ -104,6 +104,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c2 { > #address-cells = <1>; > @@ -124,7 +125,7 @@ examples: > remote-endpoint = <&csi2a_ep>; > link-frequencies = /bits/ 64 <199200000 210000000 > 499200000>; > - bus-type = <4>; > + bus-type = ; > }; > }; > }; > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > index 44529425ce3a..161e6d598e1c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > @@ -105,6 +105,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c0 { > #address-cells = <1>; > @@ -118,7 +119,7 @@ examples: > > port { > ov772x_0: endpoint { > - bus-type = <5>; > + bus-type = ; > vsync-active = <0>; > hsync-active = <0>; > pclk-sample = <0>; > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > index b39b84c5f012..0e3478551e13 100644 > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > @@ -68,6 +68,7 @@ additionalProperties: false > examples: > - | > #include > + #include > #include > > camera@d420a000 { > @@ -83,7 +84,7 @@ examples: > port { > camera0_0: endpoint { > remote-endpoint = <&ov7670_0>; > - bus-type = <5>; /* Parallel */ > + bus-type = ; > hsync-active = <1>; /* Active high */ > vsync-active = <1>; /* Active high */ > pclk-sample = <0>; /* Falling */ > diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml > index 8b37fccab5e2..25f5f79d40ce 100644 > --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml > +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml > @@ -106,6 +106,7 @@ examples: > #include > #include > #include > + #include > > xisc: xisc@e1408000 { > compatible = "microchip,sama7g5-isc"; > @@ -118,7 +119,7 @@ examples: > > port { > xisc_in: endpoint { > - bus-type = <5>; /* Parallel */ > + bus-type = ; > remote-endpoint = <&csi2dc_out>; > hsync-active = <1>; > vsync-active = <1>; > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > index 9c1262a276b5..285c6075950a 100644 > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > @@ -90,7 +90,9 @@ examples: > - | > #include > #include > + #include > #include > + # ? In any case, Reviewed-by: Rob Herring > dcmi: dcmi@4c006000 { > compatible = "st,stm32-dcmi"; > reg = <0x4c006000 0x400>; > @@ -104,7 +106,7 @@ examples: > port { > dcmi_0: endpoint { > remote-endpoint = <&ov5640_0>; > - bus-type = <5>; > + bus-type = ; > bus-width = <8>; > hsync-active = <0>; > vsync-active = <0>; > -- > Regards, > > Laurent Pinchart > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9108DC433EF for ; Mon, 27 Jun 2022 22:16:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B130310E1A5; Mon, 27 Jun 2022 22:16:12 +0000 (UTC) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id C447110E1A5 for ; Mon, 27 Jun 2022 22:16:10 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id r133so11127330iod.3 for ; Mon, 27 Jun 2022 15:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sEUUUlDAYju/2YLxlXSh5PX7GI5wJxClR/yx3HviGBQ=; b=dBplf7i+idxy3DeStwGlSrprQlTcojHdpNTp+kXVKc9/bq3K+po1vXbULuP5MRtbVO ihRyCunzM9RoBvxIIqb7JgudpBTi1DAahUUD2YdNFSUa59zfTxNvMjbdJqrpJIV9E9wN +7SkIFuiNXLTvOdKUua9MoxyAg2BSsPyQbYK89qhXBZdk3+UN/rT/ZNYKXobozifkiGv lOk+cz4y5GUilRVsfvKPvYkj0VI0+5Da3MG/zco4bJaAK+IRvQOX5/2FUb29Zt9fss1H xIxhdOL6MH33wC/mqYxTk9fVxnCXqoJowwAzmgFRaknooiX6wXG12R7QDt2dmnxeos2S FOEA== X-Gm-Message-State: AJIora/9ZlMwSxEDab34qt5lJirg7rFPPQsDqUhzeXhGn760e8lL3+eA 40P9ceSBhZF0UodSEay+BA== X-Google-Smtp-Source: AGRyM1ul6meQjPMho4PaYYVmeFu5wv9y8tgdGZfqXlC28iBRP2OmhPocanyd1Cb9iwo5OiHmJL6b0g== X-Received: by 2002:a05:6602:2d0e:b0:64f:d1ff:ac9c with SMTP id c14-20020a0566022d0e00b0064fd1ffac9cmr7870131iow.41.1656368170082; Mon, 27 Jun 2022 15:16:10 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id m2-20020a02cdc2000000b00339e6168237sm4805432jap.34.2022.06.27.15.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 15:16:09 -0700 (PDT) Received: (nullmailer pid 3062972 invoked by uid 1000); Mon, 27 Jun 2022 22:16:08 -0000 Date: Mon, 27 Jun 2022 16:16:08 -0600 From: Rob Herring To: Laurent Pinchart Subject: Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples Message-ID: <20220627221608.GA3060504-robh@kernel.org> References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-3-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615221410.27459-3-laurent.pinchart@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , Hugues Fruchet , Alexandre Torgue , dri-devel@lists.freedesktop.org, Lad Prabhakar , Sakari Ailus , Eugen Hristev , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote: > Now that a header exists with macros for the media interface bus-type > values, replace hardcoding numerical constants with the corresponding > macros in the DT binding examples. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Go back to PARALLEL > > Changes since v1: > > - Rename PARALLEL to BT601 > --- > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 + > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++- > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++- > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++- > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++- > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++- > 6 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 35a48515836e..b0e5585f93e2 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -118,6 +118,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c0 { > #address-cells = <1>; > diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > index 39395ea8c318..edde4201116f 100644 > --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > @@ -104,6 +104,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c2 { > #address-cells = <1>; > @@ -124,7 +125,7 @@ examples: > remote-endpoint = <&csi2a_ep>; > link-frequencies = /bits/ 64 <199200000 210000000 > 499200000>; > - bus-type = <4>; > + bus-type = ; > }; > }; > }; > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > index 44529425ce3a..161e6d598e1c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > @@ -105,6 +105,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c0 { > #address-cells = <1>; > @@ -118,7 +119,7 @@ examples: > > port { > ov772x_0: endpoint { > - bus-type = <5>; > + bus-type = ; > vsync-active = <0>; > hsync-active = <0>; > pclk-sample = <0>; > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > index b39b84c5f012..0e3478551e13 100644 > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > @@ -68,6 +68,7 @@ additionalProperties: false > examples: > - | > #include > + #include > #include > > camera@d420a000 { > @@ -83,7 +84,7 @@ examples: > port { > camera0_0: endpoint { > remote-endpoint = <&ov7670_0>; > - bus-type = <5>; /* Parallel */ > + bus-type = ; > hsync-active = <1>; /* Active high */ > vsync-active = <1>; /* Active high */ > pclk-sample = <0>; /* Falling */ > diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml > index 8b37fccab5e2..25f5f79d40ce 100644 > --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml > +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml > @@ -106,6 +106,7 @@ examples: > #include > #include > #include > + #include > > xisc: xisc@e1408000 { > compatible = "microchip,sama7g5-isc"; > @@ -118,7 +119,7 @@ examples: > > port { > xisc_in: endpoint { > - bus-type = <5>; /* Parallel */ > + bus-type = ; > remote-endpoint = <&csi2dc_out>; > hsync-active = <1>; > vsync-active = <1>; > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > index 9c1262a276b5..285c6075950a 100644 > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > @@ -90,7 +90,9 @@ examples: > - | > #include > #include > + #include > #include > + # ? In any case, Reviewed-by: Rob Herring > dcmi: dcmi@4c006000 { > compatible = "st,stm32-dcmi"; > reg = <0x4c006000 0x400>; > @@ -104,7 +106,7 @@ examples: > port { > dcmi_0: endpoint { > remote-endpoint = <&ov5640_0>; > - bus-type = <5>; > + bus-type = ; > bus-width = <8>; > hsync-active = <0>; > vsync-active = <0>; > -- > Regards, > > Laurent Pinchart > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51585C433EF for ; Mon, 27 Jun 2022 22:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YuJct5pspLWt5v+Kryi9tVYCcLPDfjHXeq5WuNN9LiA=; b=dG0tsIZ0hkIgd9 UIHH3VG8G73O1NP7O0nD7eUvBNje/5RfSTiDD+/rl7+iXNLcR6LEhGd5MUPc/AeH53C0aVHxiQor4 FF13MOohpTRlLNUltImnNAnIt3A2HhB5+NOlou2uiVxy68Tvh6NMQhbgFp81ixjE4/Z2t2fmC94t8 MmXLFa1kFONoyIhNb2phgH4BwT5rNNLnxuy4+sb1jTd5CxEYLyhHgU0dYdzoS/ViJEldsrKbnj/CO Qxg6MRJWoS0t+O6cZREdmtURoPsQFPZyy7EwC6xnq4Jh1P6gwI1D44SYKucBgO0EC8/k7jcepfnPw MmhCwPMmeiaz4A0RTS9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5x1j-0034Nt-Me; Mon, 27 Jun 2022 22:16:15 +0000 Received: from mail-io1-f44.google.com ([209.85.166.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5x1f-0034Mp-V8 for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 22:16:13 +0000 Received: by mail-io1-f44.google.com with SMTP id i194so11056471ioa.12 for ; Mon, 27 Jun 2022 15:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sEUUUlDAYju/2YLxlXSh5PX7GI5wJxClR/yx3HviGBQ=; b=Up/SeOslvr0XTlwNva46VjwgZeDB5Wy3KYZNp56VB4l+XlbEbMMsUvYIaqUq1DEWMK brI5wfSIkMKUAay21fDRzEjk/N2Aus5ej8LW4HV6ic2QkO/swlXeYh9mDMiNnR7LA44I SKe6UJqG08AobAZo9lP6iM1Mc8WcX525xCRFzmzX5j+iTmcOfu9v7jRNl37nl+Cwp8M5 pALFpeOvJe3v3VtB3dM1peDuxzB4n4EvtlD5FDHyuiPLd91TP4htnET81Y/UqPjjRPiM so6cEelFNHR5LQnEZCAC74zouivCbYXJMxF2Hq3X3SiiT6pBus7LYEBeOban1Q+MAlo3 aYCg== X-Gm-Message-State: AJIora8nTgiifJ6qUBBJaoKaEzfqS9pfudyFRH+NZ1djCm6XjiYAXKm3 P6GY7cu9jOtoUY5lbvanBg== X-Google-Smtp-Source: AGRyM1ul6meQjPMho4PaYYVmeFu5wv9y8tgdGZfqXlC28iBRP2OmhPocanyd1Cb9iwo5OiHmJL6b0g== X-Received: by 2002:a05:6602:2d0e:b0:64f:d1ff:ac9c with SMTP id c14-20020a0566022d0e00b0064fd1ffac9cmr7870131iow.41.1656368170082; Mon, 27 Jun 2022 15:16:10 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id m2-20020a02cdc2000000b00339e6168237sm4805432jap.34.2022.06.27.15.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 15:16:09 -0700 (PDT) Received: (nullmailer pid 3062972 invoked by uid 1000); Mon, 27 Jun 2022 22:16:08 -0000 Date: Mon, 27 Jun 2022 16:16:08 -0600 From: Rob Herring To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Sakari Ailus , Jacopo Mondi , Eugen Hristev , Hugues Fruchet , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Fabio Estevam , Shawn Guo Subject: Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples Message-ID: <20220627221608.GA3060504-robh@kernel.org> References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-3-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220615221410.27459-3-laurent.pinchart@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_151612_066727_900918E1 X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote: > Now that a header exists with macros for the media interface bus-type > values, replace hardcoding numerical constants with the corresponding > macros in the DT binding examples. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Go back to PARALLEL > > Changes since v1: > > - Rename PARALLEL to BT601 > --- > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 + > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++- > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++- > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++- > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++- > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++- > 6 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 35a48515836e..b0e5585f93e2 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -118,6 +118,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c0 { > #address-cells = <1>; > diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > index 39395ea8c318..edde4201116f 100644 > --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml > @@ -104,6 +104,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c2 { > #address-cells = <1>; > @@ -124,7 +125,7 @@ examples: > remote-endpoint = <&csi2a_ep>; > link-frequencies = /bits/ 64 <199200000 210000000 > 499200000>; > - bus-type = <4>; > + bus-type = ; > }; > }; > }; > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > index 44529425ce3a..161e6d598e1c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > @@ -105,6 +105,7 @@ additionalProperties: false > examples: > - | > #include > + #include > > i2c0 { > #address-cells = <1>; > @@ -118,7 +119,7 @@ examples: > > port { > ov772x_0: endpoint { > - bus-type = <5>; > + bus-type = ; > vsync-active = <0>; > hsync-active = <0>; > pclk-sample = <0>; > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > index b39b84c5f012..0e3478551e13 100644 > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > @@ -68,6 +68,7 @@ additionalProperties: false > examples: > - | > #include > + #include > #include > > camera@d420a000 { > @@ -83,7 +84,7 @@ examples: > port { > camera0_0: endpoint { > remote-endpoint = <&ov7670_0>; > - bus-type = <5>; /* Parallel */ > + bus-type = ; > hsync-active = <1>; /* Active high */ > vsync-active = <1>; /* Active high */ > pclk-sample = <0>; /* Falling */ > diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml > index 8b37fccab5e2..25f5f79d40ce 100644 > --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml > +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml > @@ -106,6 +106,7 @@ examples: > #include > #include > #include > + #include > > xisc: xisc@e1408000 { > compatible = "microchip,sama7g5-isc"; > @@ -118,7 +119,7 @@ examples: > > port { > xisc_in: endpoint { > - bus-type = <5>; /* Parallel */ > + bus-type = ; > remote-endpoint = <&csi2dc_out>; > hsync-active = <1>; > vsync-active = <1>; > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > index 9c1262a276b5..285c6075950a 100644 > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > @@ -90,7 +90,9 @@ examples: > - | > #include > #include > + #include > #include > + # ? In any case, Reviewed-by: Rob Herring > dcmi: dcmi@4c006000 { > compatible = "st,stm32-dcmi"; > reg = <0x4c006000 0x400>; > @@ -104,7 +106,7 @@ examples: > port { > dcmi_0: endpoint { > remote-endpoint = <&ov5640_0>; > - bus-type = <5>; > + bus-type = ; > bus-width = <8>; > hsync-active = <0>; > vsync-active = <0>; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel