From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A1CC433EF for ; Tue, 28 Jun 2022 06:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245550AbiF1Gc0 (ORCPT ); Tue, 28 Jun 2022 02:32:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245560AbiF1GcV (ORCPT ); Tue, 28 Jun 2022 02:32:21 -0400 Received: from smtp15.bhosted.nl (smtp15.bhosted.nl [IPv6:2a02:9e0:8000::26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 363D22654D for ; Mon, 27 Jun 2022 23:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonic.nl; s=202111; h=content-transfer-encoding:content-type:mime-version:references:in-reply-to: message-id:subject:cc:to:from:date:from; bh=RC0dY5L9XAcoIfZpib9R8/Dug9940SnIQoL7Lw1IR6o=; b=sz+xVbds6vckjtdcoQEUAP69lh4ZEEiW+/G9QrUv7COUHZO2dlfG48J8Tc2Eoe7WdxRPdnmtpOWNl 9FoOiT9zC2GVTOEwHLh04VBAxIGiqCx2JdLcYxScNGnmnkZuNwPh75GU5Zc4p5BphE4laxCe7XBKng M4i5VvUzgbjVtfGphKcVC+Pxw7SX4HfS9znOlruCpO+PSJOIIgHO5/ekbtT++MIkhieJOx2BzLRmYn RwixNeA7GLNCYcLkNRXinGZajNyBB9wymgKoJYfBKHlmLNrcgQk2kAoX9tV+G/sOU6VrwH+fLhyRyq q0m8bbFf/a9gl82KMJARETcWQfxHMiQ== X-MSG-ID: 0c926d8f-f6ac-11ec-ba03-0050569d3a82 Date: Tue, 28 Jun 2022 08:32:14 +0200 From: David Jander To: Mark Brown Cc: linux-spi@vger.kernel.org, Marc Kleine-Budde , Andrew Lunn Subject: Re: [PATCH v3 00/11] Optimize spi_sync path Message-ID: <20220628083214.566e76da@erd992> In-Reply-To: References: <20220621061234.3626638-1-david@protonic.nl> Organization: Protonic Holland X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, 24 Jun 2022 21:31:18 +0100 Mark Brown wrote: > On Tue, Jun 21, 2022 at 08:12:23AM +0200, David Jander wrote: > > These patches optimize the spi_sync call for the common case that the > > worker thread is idle and the queue is empty. It also opens the > > possibility to potentially further optimize the async path also, since > > it doesn't need to take into account the direct sync path anymore. > > > > As an example for the performance gain, on an i.MX8MM SoC with a SPI CAN > > controller attached (MCP2518FD), the time the interrupt line stays > > active (which corresponds roughly with the time it takes to send 3 > > relatively short consecutive spi_sync messages) is reduced from 98us to > > only 72us by this patch. > > This seems to be testing fine so far so I'm thinking it's probably a > good idea to get it into -next which will hopefully trigger wider > testing, unless someone shouts I'll look into that early next week. The > only feedback I've seen was Andy's review which is broadly stylistic so > can safely be addressed incrementally (like the improvement in patch 4 > already does for example), I didn't see any comments there which went to > correctness. Great. So I will wait for this series to hit -next and then send incremental patches to address Andy's feedback, or do you prefer I re-submit a v4 with Andy's comments addressed right away? Best regards, -- David Jander