From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C319EC433EF for ; Tue, 28 Jun 2022 20:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yYgRakDzDgGowIIO7DjywX+ra+yVE19VJv9zjXnksPQ=; b=1VRpE/reqZxnog kKPoKbz1bs11GiIndqvPLfRq8Tl6jO8gIaCncT1xS60YJFl+BNNsTtdIQ5R3pWuTtX3XhG2P8ki2H OiCY64o2izrKR6PJkASQl2O4HxClTDu87QboP+0IAt6L75akpwcROLoQLv8GJqoj3RCivZ26sFgOE q3xvLU0IoHXhPv+Xhi/GLN/RmC/FldOCswxNA+/zEzcpJy/Tldl45MOQwNmuHDW1k6sKM8EeXroRc s6YkWt4OcIZBZZKfDSCMS5RqHJID0D3uS69B7JpgyUbujpGH/ofCrwie3mPWGUgHEzg9uI52ef3Bo Hmefgl2YtQLTWBKFKyuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6HRA-007wwM-MT; Tue, 28 Jun 2022 20:03:52 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6HQv-007wr0-OY for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 20:03:39 +0000 Received: by mail-pf1-x432.google.com with SMTP id p14so12970295pfh.6 for ; Tue, 28 Jun 2022 13:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O18BNoD4QYCw1F/lcnmrBO02etfQ8RJzYCuHpe3r1UU=; b=WfoNeWhEisMXHw5gKjvS2MXabo67b3Z/nvM+Hu6P5rFQcz5RiovYr+SgXKFZCPAnu+ 8SkXvBTBEMKOvbe7WIfHh9yQ9/kZ6t/pSmdnph97VMUZtsqCL4GqgZcoTMr6K0uhN8yX XdNdBMYnw8MJ5S26JSmBevqE0LKT1uNeLPPektGhz41QbxTRPF5g/fuvVOLNwzfkTo1Z J3zHD6GVk39F1Q+r72HGLxot8k8bkQ0eRpmtWimLlRVHTap4+2KfMYBzKU/57kLv1Gd1 ZORdMMbgko7I+rhIEiYd0zpEJ/laM5qNrBKxCvCS/oh/+7P/9doUelEEcnwZL02oxrGv PS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=O18BNoD4QYCw1F/lcnmrBO02etfQ8RJzYCuHpe3r1UU=; b=nSXHRoh3gVwj4TaiQDK/3IziblaK4J3VC/VUjvzI//wfqn5ejdHlrE0jnB7AvmZa8Y 7IVJ1ogjRBjG/KFxEo0yFBMi2OymKhsM1ajlOYBb2ffb4yQEjz/9AoqLamt0/tIoltVi PeoNIIzfOK2d2AAK+qjJZq79kkITluM8DvkpAjhpGoWu3sZbzUg9Q/J8qrVoa8zw3Wy/ X6PKGYq3Fsqpj4ju0Baf8WypZyD1QhXPZShaec+W3RJfCsvW4ZW2Dd3IjWoXb3JgCKsO Sb+Tv6XQW7oU4s9PVhUJA6tchubWpqG1nfGxHNLeuwpxHQXd+4MGS9s/uOBeBpfkV6ra XRNg== X-Gm-Message-State: AJIora+GOoCh3EoccVwr8xfIQ/Srk0lejVMYmjc+W3vzHU0Av46ZLPOa 8tdQp+O9VMhx/h6zOgTv8/Y= X-Google-Smtp-Source: AGRyM1tOSUOdH1tsZ10Yv3CJ6SOKVD9V7qWVI5vrnJJSlqRo4SbPIpMFUDTGM28+dy/vfss5mPwWnQ== X-Received: by 2002:a63:91c1:0:b0:40d:33cb:3d57 with SMTP id l184-20020a6391c1000000b0040d33cb3d57mr19527523pge.10.1656446615765; Tue, 28 Jun 2022 13:03:35 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id a11-20020a170902b58b00b0015e8d4eb26esm9687241pls.184.2022.06.28.13.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 13:03:35 -0700 (PDT) Date: Tue, 28 Jun 2022 13:03:34 -0700 From: Guenter Roeck To: Paul Cercueil Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Patrice Chotard , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/8] watchdog: st_lpc_wdt: Remove #ifdef guards for PM related functions Message-ID: <20220628200334.GF3633970@roeck-us.net> References: <20220628193449.160585-1-paul@crapouillou.net> <20220628193449.160585-7-paul@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220628193449.160585-7-paul@crapouillou.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_130337_921085_36EBFBF4 X-CRM114-Status: GOOD ( 25.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 28, 2022 at 08:34:47PM +0100, Paul Cercueil wrote: > Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to > handle the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without having > to use #ifdef guards. Not using #ifdef guards means that the code is > always compiled independently of any Kconfig option, and thanks to that > bugs and regressions are easier to catch. > > Signed-off-by: Paul Cercueil > Cc: Patrice Chotard > Cc: linux-arm-kernel@lists.infradead.org Reviewed-by: Guenter Roeck > --- > drivers/watchdog/st_lpc_wdt.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c > index 14ab6559c748..39abecdb9dd1 100644 > --- a/drivers/watchdog/st_lpc_wdt.c > +++ b/drivers/watchdog/st_lpc_wdt.c > @@ -248,7 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int st_wdog_suspend(struct device *dev) > { > struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev); > @@ -285,16 +284,14 @@ static int st_wdog_resume(struct device *dev) > > return 0; > } > -#endif > > -static SIMPLE_DEV_PM_OPS(st_wdog_pm_ops, > - st_wdog_suspend, > - st_wdog_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(st_wdog_pm_ops, > + st_wdog_suspend, st_wdog_resume); > > static struct platform_driver st_wdog_driver = { > .driver = { > .name = "st-lpc-wdt", > - .pm = &st_wdog_pm_ops, > + .pm = pm_sleep_ptr(&st_wdog_pm_ops), > .of_match_table = st_wdog_match, > }, > .probe = st_wdog_probe, > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E24C43334 for ; Tue, 28 Jun 2022 20:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbiF1UOi (ORCPT ); Tue, 28 Jun 2022 16:14:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbiF1UL5 (ORCPT ); Tue, 28 Jun 2022 16:11:57 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BFE613DC8; Tue, 28 Jun 2022 13:03:36 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id a15so12932379pfv.13; Tue, 28 Jun 2022 13:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O18BNoD4QYCw1F/lcnmrBO02etfQ8RJzYCuHpe3r1UU=; b=WfoNeWhEisMXHw5gKjvS2MXabo67b3Z/nvM+Hu6P5rFQcz5RiovYr+SgXKFZCPAnu+ 8SkXvBTBEMKOvbe7WIfHh9yQ9/kZ6t/pSmdnph97VMUZtsqCL4GqgZcoTMr6K0uhN8yX XdNdBMYnw8MJ5S26JSmBevqE0LKT1uNeLPPektGhz41QbxTRPF5g/fuvVOLNwzfkTo1Z J3zHD6GVk39F1Q+r72HGLxot8k8bkQ0eRpmtWimLlRVHTap4+2KfMYBzKU/57kLv1Gd1 ZORdMMbgko7I+rhIEiYd0zpEJ/laM5qNrBKxCvCS/oh/+7P/9doUelEEcnwZL02oxrGv PS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=O18BNoD4QYCw1F/lcnmrBO02etfQ8RJzYCuHpe3r1UU=; b=vvwHwx1yB69hOGuG/p21ohjle6FYpruc4gYbL/Mp7x9br+IGFPcizuSzJ9mXSf6wXH 5ZCQ925r6cV1uHBQCCsbM/4CjvJFTPDQqJ7zU64tkqhUKWHHonFBQUl9HNecUzXAd/Id 9G5yWF5fJurAKNhO/oWqgH5nBLpS4JtkVJp5IgWvc5Nuw+1CFEUQuGfaI7UeJnIOQTGx 2sT0vdF4czZhR1hAm8a212RqcwQHclfUFiRHjzenspKeDhD1/WQLHss/Sgg3zV/B3V/c MH5+2GSjGccOVQUW9IdJmXhAejTn9xC4LWYA+SrxGmY24Rh6hD76HJQR+7EUim91hgTj qx+w== X-Gm-Message-State: AJIora8q0P5cqd05scN3yrSGowcrherTeOA14J7Ibjsi3WBsi6fStfJq 8x6G8fc9V3oMzNRZWMP3cm/hkX3JDx0= X-Google-Smtp-Source: AGRyM1tOSUOdH1tsZ10Yv3CJ6SOKVD9V7qWVI5vrnJJSlqRo4SbPIpMFUDTGM28+dy/vfss5mPwWnQ== X-Received: by 2002:a63:91c1:0:b0:40d:33cb:3d57 with SMTP id l184-20020a6391c1000000b0040d33cb3d57mr19527523pge.10.1656446615765; Tue, 28 Jun 2022 13:03:35 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id a11-20020a170902b58b00b0015e8d4eb26esm9687241pls.184.2022.06.28.13.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 13:03:35 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 28 Jun 2022 13:03:34 -0700 From: Guenter Roeck To: Paul Cercueil Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Patrice Chotard , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/8] watchdog: st_lpc_wdt: Remove #ifdef guards for PM related functions Message-ID: <20220628200334.GF3633970@roeck-us.net> References: <20220628193449.160585-1-paul@crapouillou.net> <20220628193449.160585-7-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628193449.160585-7-paul@crapouillou.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 08:34:47PM +0100, Paul Cercueil wrote: > Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to > handle the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without having > to use #ifdef guards. Not using #ifdef guards means that the code is > always compiled independently of any Kconfig option, and thanks to that > bugs and regressions are easier to catch. > > Signed-off-by: Paul Cercueil > Cc: Patrice Chotard > Cc: linux-arm-kernel@lists.infradead.org Reviewed-by: Guenter Roeck > --- > drivers/watchdog/st_lpc_wdt.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c > index 14ab6559c748..39abecdb9dd1 100644 > --- a/drivers/watchdog/st_lpc_wdt.c > +++ b/drivers/watchdog/st_lpc_wdt.c > @@ -248,7 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int st_wdog_suspend(struct device *dev) > { > struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev); > @@ -285,16 +284,14 @@ static int st_wdog_resume(struct device *dev) > > return 0; > } > -#endif > > -static SIMPLE_DEV_PM_OPS(st_wdog_pm_ops, > - st_wdog_suspend, > - st_wdog_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(st_wdog_pm_ops, > + st_wdog_suspend, st_wdog_resume); > > static struct platform_driver st_wdog_driver = { > .driver = { > .name = "st-lpc-wdt", > - .pm = &st_wdog_pm_ops, > + .pm = pm_sleep_ptr(&st_wdog_pm_ops), > .of_match_table = st_wdog_match, > }, > .probe = st_wdog_probe, > -- > 2.35.1 >